Firestore: TestingHooks code simplification #4975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 160 files - 330 160 suites - 330 2m 7s ⏱️ - 14m 47s Results for commit 408c77e. ± Comparison against base commit b1f2130. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
milaGGL
reviewed
May 3, 2023
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up TestingHooks code to be simpler and more consistent with the Web and iOS SDKs.
First, make the existence filter mismatch listener callbacks synchronous (instead of asynchronous). This greatly simplifies the testing and test helper code. Seconds, replace the
ExistenceFilterMismatchListenertest helper class with a static methodcaptureExistenceFilterMismatches(), which invokes a callback and captures existence filter mismatches during the callback.Both of these changes bring the Android SDK into parity with the web and iOS SDKs.