Skip to content

add manual override to avoid releasing everyone with cleanup PRs #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2023
Merged

add manual override to avoid releasing everyone with cleanup PRs #4978

merged 1 commit into from
May 4, 2023

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

buildSrc Test Results

27 tests   27 ✔️  1m 47s ⏱️
  5 suites    0 💤
  5 files      0 ❌

Results for commit cb48f9e.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023 •
edited
Loading

Unit Test Results

   790 files  +   300     790 suites  +300   36m 48s ⏱️ + 19m 54s
4 866 tests +1 499  4 845 ✔️ +1 500  21 💤 +2  0 ❌  - 3 
9 641 runs  +3 019  9 599 ✔️ +3 018  42 💤 +4  0 ❌  - 3 

Results for commit cb48f9e. ± Comparison against base commit b1f2130.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (b1f2130) and merge commit (5f3e3c3).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Fgq0xKQuyb.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (b1f2130) to 50.19% (5f3e3c3) by +0.01%.

    FilenameBase (b1f2130)Merge (5f3e3c3)Diff
    QueryParams.java89.76%90.36%+0.60%

  • firebase-messaging

    Overall coverage changed from 85.18% (b1f2130) to 85.22% (5f3e3c3) by +0.04%.

    FilenameBase (b1f2130)Merge (5f3e3c3)Diff
    FirebaseMessaging.java75.77%76.21%+0.44%

  • firebase-firestore

    FilenameBase (b1f2130)Merge (5f3e3c3)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WYkRQNt0w0.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,048 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gpW3KfxTci/index.html

@davidmotson davidmotson requested review from daymxn and rlazo May 4, 2023 17:57
@davidmotson davidmotson merged commit 441ebc4 into master May 4, 2023
@davidmotson davidmotson deleted the davidmotson.release_change_manual_override branch May 4, 2023 18:58
@firebase firebase locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmotson @google-oss-bot @rlazo