Skip to content

typo: limted --> limited #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

typo: limted --> limited #4980

merged 1 commit into from
May 5, 2023

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented May 4, 2023

Equivalent change internally: cl/529542160

@thatfiredev thatfiredev requested a review from rlazo May 4, 2023 23:15
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Unit Test Results

  88 files   -      72    88 suites   - 72   7m 45s ⏱️ + 5m 14s
240 tests  -    885  240 ✔️  -    869  0 💤  - 16  0 ±0 
480 runs   - 1 770  480 ✔️  - 1 738  0 💤  - 32  0 ±0 

Results for commit ae7c1dc. ± Comparison against base commit 5c2b381.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-app-check

    DeviceStatisticsDistributions
    oriole-32
    Percentile5c2b3815a05543DiffSignificant (?)
    p10229 ±66 μs349 ±350 μs+119 μs (+51.9%)NO
    p25248 ±73 μs367 ±369 μs+119 μs (+48.0%)NO
    p50277 ±76 μs408 ±387 μs+131 μs (+47.4%)NO
    p75317 ±98 μs474 ±469 μs+157 μs (+49.5%)NO
    p90448 ±210 μs688 ±862 μs+240 μs (+53.5%)NO

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh
    redfin-30
    Percentile5c2b3815a05543DiffSignificant (?)
    p102.24 ±2 ms437 ±67 μs-1.81 ms (-80.5%)NO
    p252.40 ±2 ms487 ±99 μs-1.92 ms (-79.7%)NO
    p502.63 ±3 ms578 ±178 μs-2.05 ms (-78.0%)NO
    p752.97 ±3 ms780 ±366 μs-2.19 ms (-73.8%)NO
    p903.76 ±4 ms1.05 ±0.6 ms-2.71 ms (-72.1%)NO

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh
  • fire-gcs

    DeviceStatisticsDistributions
    oriole-32
    Percentile5c2b3815a05543DiffSignificant (?)
    p1037.2 ±5 μs40.5 ±6 μs+3.33 μs (+9.0%)NO
    p2540.0 ±7 μs43.1 ±6 μs+3.11 μs (+7.8%)NO
    p5043.9 ±9.7 μs48.4 ±9 μs+4.49 μs (+10.2%)NO
    p7550.0 ±14 μs54.4 ±13 μs+4.38 μs (+8.8%)NO
    p9057.6 ±19 μs70.4 ±27 μs+12.8 μs (+22.2%)NO

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh
    redfin-30
    Percentile5c2b3815a05543DiffSignificant (?)
    p1089.7 ±13 μs81.7 ±14 μs-8.02 μs (-8.9%)NO
    p2593.1 ±12 μs85.9 ±16 μs-7.18 μs (-7.7%)NO
    p5099.3 ±12 μs91.8 ±17 μs-7.44 μs (-7.5%)NO
    p75112 ±13 μs101 ±21 μs-10.9 μs (-9.8%)NO
    p90131 ±16 μs117 ±27 μs-13.8 μs (-10.5%)NO

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile5c2b3815a05543DiffSignificant (?)
    p10194 ±9.8 ms200 ±9.8 ms+5.83 ms (+3.0%)NO
    p25201 ±12 ms206 ±9 ms+4.99 ms (+2.5%)NO
    p50210 ±20 ms214 ±11 ms+3.67 ms (+1.7%)NO
    p75220 ±23 ms222 ±12 ms+2.48 ms (+1.1%)NO
    p90230 ±27 ms233 ±16 ms+3.67 ms (+1.6%)NO

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh
    redfin-30
    Percentile5c2b3815a05543DiffSignificant (?)
    p10228 ±4 ms254 ±3 ms+25.7 ms (+11.3%)YES
    p25234 ±4 ms259 ±3 ms+25.4 ms (+10.9%)YES
    p50241 ±4 ms267 ±3 ms+26.3 ms (+10.9%)YES
    p75249 ±5 ms275 ±4 ms+26.5 ms (+10.7%)YES
    p90258 ±5 ms289 ±5 ms+30.8 ms (+11.9%)YES

    19 test runs in comparison
    CommitTest Runs
    5c2b381
    • 2023-05-04_19:25:12.474522_FgDH
    • 2023-05-04_19:25:12.477694_Qwsa
    • 2023-05-04_19:25:12.477833_SeEw
    • 2023-05-04_19:25:12.477840_MKve
    • 2023-05-04_19:25:12.477846_BHZV
    • 2023-05-04_19:25:12.477852_mUsu
    • 2023-05-04_19:25:12.477859_hruz
    • 2023-05-04_19:25:12.477864_PRwq
    • 2023-05-04_19:25:12.477870_MGCN
    • 2023-05-04_19:25:12.477875_ImjG
    5a05543
    • 2023-05-04_23:32:50.232890_PSDM
    • 2023-05-04_23:32:50.232905_QbAF
    • 2023-05-04_23:32:50.232912_bKKO
    • 2023-05-04_23:32:50.232917_HWcW
    • 2023-05-04_23:32:50.232923_KlGI
    • 2023-05-04_23:32:50.232929_JuPV
    • 2023-05-04_23:32:50.232934_teHk
    • 2023-05-04_23:32:50.232939_osig
    • 2023-05-04_23:32:50.232945_vfQh

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aY9Hx0ZKFe/index.html

@rlazo rlazo merged commit 41890a0 into master May 5, 2023
@rlazo rlazo deleted the rpf-fac-changelog-typo branch May 5, 2023 03:58
@firebase firebase locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants