Skip to content

Add os_version, app_build_version, device_manufacturer for Sessions #11222 #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2023

Conversation

samedson
Copy link
Contributor

@samedson samedson commented May 5, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Unit Test Results

22 files  22 suites   33s ⏱️
35 tests 35 ✔️ 0 💤 0
70 runs  70 ✔️ 0 💤 0

Results for commit a977f68.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (c3b0dcc) to 69.50% (b300302) by ?.

    17 individual files with coverage change

    FilenameBase (c3b0dcc)Merge (b300302)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?85.53%?
    RemoteSettingsFetcher.kt?3.23%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.73%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?90.00%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/N9s0LoJ1uH.html

@firebase firebase deleted a comment from google-oss-bot May 5, 2023
@firebase firebase deleted a comment from google-oss-bot May 5, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2023

Size Report 1

Affected Products

  • base

    TypeBase (c3b0dcc)Merge (b300302)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-datatransport

    TypeBase (c3b0dcc)Merge (b300302)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)
  • firebase-sessions

    TypeBase (c3b0dcc)Merge (b300302)Diff
    aar?94.6 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TRWmZY7S6g.html

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@samedson samedson changed the title Add new fields to Sessions Add os_version, app_build_version, device_manufacturer for Sessions #11222 May 5, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (b300302) and the base commit (c3b0dcc) are not available.

No macrobenchmark data found for the base commit (c3b0dcc). Analysis for the CI merge commit (b300302) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PhntNeM1ge/index.html

@samedson samedson merged commit 6c066f3 into firebase-sessions May 8, 2023
@samedson samedson deleted the sessions-new-fields branch May 8, 2023 18:07
@firebase firebase locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants