Skip to content

Add App information for config fetching #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

Add App information for config fetching #4992

merged 1 commit into from
May 9, 2023

Conversation

visumickey
Copy link
Contributor

No description provided.

@visumickey visumickey requested review from samedson and mrober May 9, 2023 06:15
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (6c066f3) to 69.23% (5e809ec) by ?.

    17 individual files with coverage change

    FilenameBase (6c066f3)Merge (5e809ec)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?85.53%?
    RemoteSettingsFetcher.kt?3.03%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.73%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?90.00%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GB4WLiOHXx.html

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Unit Test Results

22 files  22 suites   37s ⏱️
35 tests 35 ✔️ 0 💤 0 ❌
70 runs  70 ✔️ 0 💤 0 ❌

Results for commit 7898db8.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (6c066f3)Merge (5e809ec)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (6c066f3)Merge (5e809ec)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (6c066f3)Merge (5e809ec)Diff
    aar?94.8 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZgdU7omXrR.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (5e809ec) and the base commit (6c066f3) are not available.

No macrobenchmark data found for the base commit (6c066f3). Analysis for the CI merge commit (5e809ec) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tC75Hy8wgC/index.html

@visumickey visumickey merged commit b9d413d into firebase-sessions May 9, 2023
@visumickey visumickey deleted the firebase-sessions-update-fetcher branch May 9, 2023 16:41
@firebase firebase locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visumickey @google-oss-bot @samedson @mrober