Skip to content

Update the header params for network request #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

Update the header params for network request #4995

merged 1 commit into from
May 11, 2023

Conversation

visumickey
Copy link
Contributor

@visumickey visumickey requested review from samedson and mrober May 9, 2023 23:47
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d9283e6.

@visumickey
Copy link
Contributor Author

/retest

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (b9d413d) to 69.47% (0d2de95) by ?.

    17 individual files with coverage change

    FilenameBase (b9d413d)Merge (0d2de95)Diff
    ApplicationInfo.kt?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsEarly.kt?0.00%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?86.25%?
    RemoteSettingsFetcher.kt?3.03%?
    SessionCoordinator.kt?76.47%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.73%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?90.00%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HLRPbse9wk.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (b9d413d)Merge (0d2de95)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (b9d413d)Merge (0d2de95)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (b9d413d)Merge (0d2de95)Diff
    aar?95.3 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vVcZQeYPkL.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (0d2de95) and the base commit (b9d413d) are not available.

No macrobenchmark data found for the base commit (b9d413d). Analysis for the CI merge commit (0d2de95) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GKUeWPPDY9/index.html

@visumickey visumickey merged commit e06b5ce into firebase-sessions May 11, 2023
@visumickey visumickey deleted the firebase-sessions-header-update branch May 11, 2023 18:14
@firebase firebase locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visumickey @google-oss-bot @mrober