update heartbeat to provide support for c++ sdks #5011

VinayGuthal · 2023-05-17T16:11:13Z

Only take all heartbeats until today.. Donot send heartbeats of today and don't delete them as well

github-actions · 2023-05-17T16:11:25Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-05-17T16:11:55Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatInfoStorage.java

google-oss-bot · 2023-05-17T16:15:57Z

Coverage Report ¹

Affected Products

firebase-common
Overall coverage changed from 53.60% (fce5c40) to 54.25% (a25b043) by +0.65%.
Filename Base (fce5c40) Merge (a25b043) Diff
FirebaseApp.java 56.36% 56.56% +0.20%
HeartBeatInfoStorage.java 92.37% 93.23% +0.86%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/Cj61tMBObl.html

github-actions · 2023-05-17T16:18:08Z

Unit Test Results

  34 files +28   34 suites +28 1m 10s ⏱️ +49s
  58 tests +47   58 ✔️ +47 0 💤 ±0 0 ❌ ±0
116 runs +94 116 ✔️ +94 0 💤 ±0 0 ❌ ±0

Results for commit 23be982. ± Comparison against base commit fce5c40.

This pull request removes 11 and adds 58 tests. Note that renamed tests count towards both.

com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.ktx.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.ktx.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.ktx.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.ktx.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
com.google.firebase.functions.ktx.FunctionsTests ‑ functions should delegate to FirebaseFunctions#getInstance()
…

com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-05-17T16:23:18Z

Size Report ¹

Affected Products

firebase-common
Type Base (fce5c40) Merge (a25b043) Diff
aar 75.3 kB 75.6 kB +267 B (+0.4%)
apk (aggressive) 112 kB 112 kB +16 B (+0.0%)
apk (release) 1.26 MB 1.26 MB +132 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/PB4NIrKKjd.html

google-oss-bot · 2023-05-17T17:24:17Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (fce5c40) and the CI merge commit (a25b043)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- fce5c40: https://storage.googleapis.com/firebase-sdk-metric-reports/iIKh5lj0HZ/index.html
- a25b043: https://storage.googleapis.com/firebase-sdk-metric-reports/F3TQqzTGz8/index.html

Startup Times

`ComponentDiscovery`

Device Statistics Distributions

oriole-32

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	432 ±12 μs	437 ±11 μs	+4.60 μs (+1.1%)	NO
p25	484 ±16 μs	477 ±19 μs	-6.63 μs (-1.4%)	NO
p50	571 ±16 μs	570 ±25 μs	-1.43 μs (-0.3%)	NO
p75	678 ±41 μs	663 ±29 μs	-14.3 μs (-2.1%)	NO
p90	847 ±36 μs	841 ±61 μs	-6.31 μs (-0.7%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

redfin-30

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	757 ±11 μs	760 ±12 μs	+3.19 μs (+0.4%)	NO
p25	792 ±12 μs	799 ±16 μs	+7.52 μs (+1.0%)	NO
p50	856 ±20 μs	871 ±25 μs	+15.0 μs (+1.7%)	NO
p75	1.11 ±0.06 ms	1.10 ±0.09 ms	-8.49 μs (-0.8%)	NO
p90	1.54 ±0.1 ms	1.56 ±0.3 ms	+18.9 μs (+1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

`Firebase`

Device Statistics Distributions

oriole-32

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	4.29 ±0.1 ms	4.34 ±0.1 ms	+51.6 μs (+1.2%)	NO
p25	4.50 ±0.2 ms	4.58 ±0.2 ms	+72.3 μs (+1.6%)	NO
p50	4.87 ±0.2 ms	4.90 ±0.2 ms	+33.0 μs (+0.7%)	NO
p75	5.38 ±0.3 ms	5.50 ±0.2 ms	+113 μs (+2.1%)	NO
p90	6.14 ±0.3 ms	6.24 ±0.3 ms	+105 μs (+1.7%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

redfin-30

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	6.55 ±0.2 ms	6.62 ±0.1 ms	+66.8 μs (+1.0%)	NO
p25	6.78 ±0.2 ms	6.84 ±0.2 ms	+57.6 μs (+0.8%)	NO
p50	7.12 ±0.2 ms	7.18 ±0.2 ms	+59.7 μs (+0.8%)	NO
p75	7.76 ±0.2 ms	7.92 ±0.2 ms	+155 μs (+2.0%)	NO
p90	9.02 ±0.6 ms	9.16 ±0.6 ms	+136 μs (+1.5%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

`Runtime`

Device Statistics Distributions

oriole-32

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	3.75 ±0.1 ms	3.81 ±0.1 ms	+57.4 μs (+1.5%)	NO
p25	3.92 ±0.2 ms	4.00 ±0.1 ms	+82.7 μs (+2.1%)	NO
p50	4.20 ±0.2 ms	4.28 ±0.2 ms	+75.5 μs (+1.8%)	NO
p75	4.65 ±0.3 ms	4.82 ±0.2 ms	+161 μs (+3.5%)	NO
p90	5.40 ±0.3 ms	5.49 ±0.3 ms	+95.1 μs (+1.8%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

redfin-30

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	5.64 ±0.1 ms	5.69 ±0.1 ms	+58.1 μs (+1.0%)	NO
p25	5.82 ±0.2 ms	5.88 ±0.1 ms	+54.1 μs (+0.9%)	NO
p50	6.07 ±0.2 ms	6.13 ±0.1 ms	+65.9 μs (+1.1%)	NO
p75	6.49 ±0.2 ms	6.58 ±0.1 ms	+83.1 μs (+1.3%)	NO
p90	7.31 ±0.4 ms	7.42 ±0.5 ms	+112 μs (+1.5%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	191 ±4 ms	198 ±4 ms	+6.85 ms (+3.6%)	NO
p25	197 ±3 ms	204 ±4 ms	+7.18 ms (+3.7%)	NO
p50	204 ±3 ms	212 ±5 ms	+7.82 ms (+3.8%)	NO
p75	212 ±5 ms	222 ±6 ms	+9.75 ms (+4.6%)	NO
p90	222 ±8 ms	233 ±6 ms	+11.2 ms (+5.1%)	NO

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

redfin-30

Percentile	`fce5c40`	`a25b043`	Diff	Significant (?)
p10	230 ±3 ms	255 ±5 ms	+25.1 ms (+10.9%)	YES
p25	236 ±3 ms	261 ±5 ms	+25.3 ms (+10.8%)	YES
p50	242 ±3 ms	269 ±5 ms	+26.4 ms (+10.9%)	YES
p75	250 ±5 ms	277 ±6 ms	+27.8 ms (+11.1%)	YES
p90	258 ±5 ms	289 ±7 ms	+31.1 ms (+12.0%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`fce5c40`	2023-05-16_19:54:53.798812_DfiQ 2023-05-16_19:54:53.801192_koIE 2023-05-16_19:54:53.801208_IChC 2023-05-16_19:54:53.801215_Dpvd 2023-05-16_19:54:53.801221_vaBM 2023-05-16_19:54:53.801228_UvMg 2023-05-16_19:54:53.801234_Nqwk 2023-05-16_19:54:53.801239_sCFL 2023-05-16_19:54:53.801245_AaSf 2023-05-16_19:54:53.801251_gPwe
`a25b043`	2023-05-17_17:00:15.422097_GWqx 2023-05-17_17:00:15.426355_gaOA 2023-05-17_17:00:15.426391_MvTK 2023-05-17_17:00:15.426402_tFri 2023-05-17_17:00:15.426409_IvRg 2023-05-17_17:00:15.426416_vUGJ 2023-05-17_17:00:15.426423_ybyV 2023-05-17_17:00:15.426429_CZeL 2023-05-17_17:00:15.426435_oDfb 2023-05-17_17:00:15.426442_llov

https://storage.googleapis.com/firebase-sdk-metric-reports/V6jhdBBZFP/index.html

update heartbeat to provide support for c++ sdks

18862c2

VinayGuthal requested review from rlazo and chkuang-g May 17, 2023 16:11

rlazo reviewed May 17, 2023

View reviewed changes

firebase-common/src/main/java/com/google/firebase/heartbeatinfo/HeartBeatInfoStorage.java Show resolved Hide resolved

rlazo approved these changes May 17, 2023

View reviewed changes

update

23be982

VinayGuthal merged commit 1c763f0 into master May 17, 2023

VinayGuthal deleted the update_heartbeat_for_c++ branch May 17, 2023 17:33

firebase locked and limited conversation to collaborators Jun 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update heartbeat to provide support for c++ sdks #5011

update heartbeat to provide support for c++ sdks #5011

Uh oh!

VinayGuthal commented May 17, 2023 •

edited

Loading

Uh oh!

github-actions bot commented May 17, 2023

Uh oh!

google-oss-bot commented May 17, 2023

Uh oh!

Uh oh!

google-oss-bot commented May 17, 2023 •

edited

Loading

`firebase-common`

Uh oh!

github-actions bot commented May 17, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented May 17, 2023 •

edited

Loading

`firebase-common`

Uh oh!

google-oss-bot commented May 17, 2023

`ComponentDiscovery`

`Firebase`

`Runtime`

`timeToInitialDisplay`

Uh oh!

Uh oh!

update heartbeat to provide support for c++ sdks #5011

update heartbeat to provide support for c++ sdks #5011

Uh oh!

Conversation

VinayGuthal commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 17, 2023

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented May 17, 2023

Uh oh!

Uh oh!

google-oss-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-common

Test Logs

Uh oh!

github-actions bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-common

Test Logs

Uh oh!

google-oss-bot commented May 17, 2023

Startup Time Report 1

Notes

Startup Times

ComponentDiscovery

Firebase

Runtime

timeToInitialDisplay

Uh oh!

Uh oh!

VinayGuthal commented May 17, 2023 •

edited

Loading

google-oss-bot commented May 17, 2023 •

edited

Loading

Coverage Report ¹

`firebase-common`

github-actions bot commented May 17, 2023 •

edited

Loading

google-oss-bot commented May 17, 2023 •

edited

Loading

Size Report ¹

`firebase-common`

Startup Time Report ¹

`ComponentDiscovery`

`Firebase`

`Runtime`

`timeToInitialDisplay`