Skip to content

Add support for json configuration in make_release_notes.py #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2023
Merged

Add support for json configuration in make_release_notes.py #5015

merged 2 commits into from
May 18, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 17, 2023

No description provided.

@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested review from davidmotson and daymxn May 17, 2023 23:03
@rlazo rlazo enabled auto-merge (squash) May 17, 2023 23:03
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

Unit Test Results

   780 files  +   752     780 suites  +752   33m 51s ⏱️ + 33m 7s
4 909 tests +4 798  4 887 ✔️ +4 776  21 💤 +21  1 ❌ +1 
9 615 runs  +9 393  9 572 ✔️ +9 350  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4172c44. ± Comparison against base commit 7ee2c64.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (7ee2c64) and merge commit (19a0b5e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vlNugPzUxz.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (7ee2c64) to 50.16% (19a0b5e) by -0.01%.

    FilenameBase (7ee2c64)Merge (19a0b5e)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    DefaultPersistenceManager.java74.76%75.73%+0.97%
    QueryParams.java89.76%90.36%+0.60%
    WriteTree.java76.67%77.22%+0.56%

  • firebase-firestore

    Overall coverage changed from 44.33% (7ee2c64) to 44.34% (19a0b5e) by +0.00%.

    FilenameBase (7ee2c64)Merge (19a0b5e)Diff
    SetMutation.java94.44%97.22%+2.78%

  • firebase-messaging

    Overall coverage changed from ? (7ee2c64) to 84.95% (19a0b5e) by ?.

    41 individual files with coverage change

    FilenameBase (7ee2c64)Merge (19a0b5e)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?74.89%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.60%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

  • firebase-storage

    Overall coverage changed from 85.77% (7ee2c64) to 85.94% (19a0b5e) by +0.17%.

    FilenameBase (7ee2c64)Merge (19a0b5e)Diff
    NetworkRequest.java87.11%86.60%-0.52%
    StorageTask.java83.38%83.69%+0.30%
    StreamDownloadTask.java88.41%88.89%+0.48%
    UploadTask.java81.52%82.51%+0.99%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yW1HMf8yrT.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,081 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DfPQenDRPI/index.html

@rlazo rlazo merged commit aa2a424 into master May 18, 2023
@rlazo rlazo deleted the rl.json.relnotes branch May 18, 2023 04:21
@firebase firebase locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmotson davidmotson davidmotson approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @davidmotson