Skip to content

Use firebase-encoders-processor instead of manually building encoder #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Use firebase-encoders-processor instead of manually building encoder #5030

merged 1 commit into from
May 25, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented May 24, 2023

No description provided.

@mrober mrober requested review from samedson and visumickey May 24, 2023 16:05
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (4303a9f) to 69.60% (ac90293) by ?.

    19 individual files with coverage change

    FilenameBase (4303a9f)Merge (ac90293)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    EventGDTLogger.kt?75.00%?
    FirebaseSessions.kt?0.00%?
    FirebaseSessionsDependencies.kt?91.30%?
    FirebaseSessionsRegistrar.kt?0.00%?
    LocalOverrideSettings.kt?88.46%?
    RemoteSettings.kt?86.25%?
    RemoteSettingsFetcher.kt?3.03%?
    SessionCoordinator.kt?75.00%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?96.97%?
    SessionGenerator.kt?20.00%?
    SessionInitiator.kt?66.67%?
    SessionsSettings.kt?90.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?94.12%?
    SettingsProvider.kt?0.00%?
    Time.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fgdr9oS2dF.html

@github-actions
Copy link
Contributor

Unit Test Results

  27 files    27 suites   46s ⏱️
  60 tests   60 ✔️ 0 💤 0 ❌
102 runs  102 ✔️ 0 💤 0 ❌

Results for commit 4fc5609.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (4303a9f)Merge (ac90293)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)

  • firebase-datatransport

    TypeBase (4303a9f)Merge (ac90293)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)

  • firebase-sessions

    TypeBase (4303a9f)Merge (ac90293)Diff
    aar?111 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/x2HIIMLwNH.html

visumickey
visumickey approved these changes May 24, 2023
View reviewed changes
firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt
}
}
}
.configureWith(AutoSessionEventEncoder.CONFIG)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the source of this EventEncoder.CONFIG? The proto file used in the firebase-sessions library is not updated with the recent changes and if required, we might need to update if the proto file is the source of truth for this config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated from the data class. We need to keep it in sync with the proto. I copy the fields from the proto from the iOS repo into it.

@mrober mrober merged commit f79e5c4 into firebase-sessions May 25, 2023
@mrober mrober deleted the sessions-dataclasses branch May 25, 2023 21:49
@firebase firebase locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@samedson samedson Awaiting requested review from samedson

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @visumickey