Skip to content

Fix equality and inequality on the same field #5034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2023
Merged

Fix equality and inequality on the same field #5034

merged 2 commits into from
May 26, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented May 25, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.34% (e189eed) to 44.33% (a13ff67) by -0.01%.

    FilenameBase (e189eed)Merge (a13ff67)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WZ3CIOMET5.html

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023 •
edited
Loading

Unit Test Results

   162 files  +   162     162 suites  +162   2m 22s ⏱️ + 2m 22s
1 160 tests +1 160  1 144 ✔️ +1 144  16 💤 +16  0 ❌ ±0 
2 320 runs  +2 320  2 288 ✔️ +2 288  32 💤 +32  0 ❌ ±0 

Results for commit 295fb40. ± Comparison against base commit e189eed.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (e189eed)Merge (a13ff67)Diff
    aar1.36 MB1.36 MB+149 B (+0.0%)
    apk (release)3.95 MB3.95 MB+88 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/U8qkitJ5wT.html

@wu-hui wu-hui requested a review from cherylEnkidu May 25, 2023 15:41
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 25, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilee189eeda13ff67DiffSignificant (?)
    p10333 ±19 μs320 ±13 μs-12.7 μs (-3.8%)NO
    p25352 ±25 μs329 ±16 μs-22.1 μs (-6.3%)NO
    p50396 ±71 μs360 ±48 μs-35.9 μs (-9.1%)NO
    p75456 ±113 μs424 ±105 μs-32.2 μs (-7.1%)NO
    p90566 ±203 μs487 ±151 μs-78.6 μs (-13.9%)NO

    20 test runs in comparison
    CommitTest Runs
    e189eed
    • 2023-05-24_18:15:06.486796_ETRV
    • 2023-05-24_18:15:06.491099_XXbx
    • 2023-05-24_18:15:06.491124_kBaA
    • 2023-05-24_18:15:06.491135_nvOS
    • 2023-05-24_18:15:06.491142_RUla
    • 2023-05-24_18:15:06.491149_Dcxe
    • 2023-05-24_18:15:06.491156_DuxD
    • 2023-05-24_18:15:06.491163_xJhN
    • 2023-05-24_18:15:06.491170_pTrY
    • 2023-05-24_18:15:06.491177_CSrR
    a13ff67
    • 2023-05-25_19:44:22.739693_cxYT
    • 2023-05-25_19:44:22.742105_dMYf
    • 2023-05-25_19:44:22.742114_ASvP
    • 2023-05-25_19:44:22.742121_phoo
    • 2023-05-25_19:44:22.742126_CJDu
    • 2023-05-25_19:44:22.742132_lfHD
    • 2023-05-25_19:44:22.742137_rGPT
    • 2023-05-25_19:44:22.742143_HGHn
    • 2023-05-25_19:44:22.742148_zvWu
    • 2023-05-25_19:44:22.742153_WcuZ
    redfin-30
    Percentilee189eeda13ff67DiffSignificant (?)
    p10630 ±38 μs626 ±19 μs-4.21 μs (-0.7%)NO
    p25651 ±40 μs642 ±16 μs-9.04 μs (-1.4%)NO
    p50682 ±43 μs665 ±23 μs-17.0 μs (-2.5%)NO
    p75721 ±46 μs697 ±32 μs-23.6 μs (-3.3%)NO
    p90797 ±79 μs747 ±65 μs-50.0 μs (-6.3%)NO

    20 test runs in comparison
    CommitTest Runs
    e189eed
    • 2023-05-24_18:15:06.486796_ETRV
    • 2023-05-24_18:15:06.491099_XXbx
    • 2023-05-24_18:15:06.491124_kBaA
    • 2023-05-24_18:15:06.491135_nvOS
    • 2023-05-24_18:15:06.491142_RUla
    • 2023-05-24_18:15:06.491149_Dcxe
    • 2023-05-24_18:15:06.491156_DuxD
    • 2023-05-24_18:15:06.491163_xJhN
    • 2023-05-24_18:15:06.491170_pTrY
    • 2023-05-24_18:15:06.491177_CSrR
    a13ff67
    • 2023-05-25_19:44:22.739693_cxYT
    • 2023-05-25_19:44:22.742105_dMYf
    • 2023-05-25_19:44:22.742114_ASvP
    • 2023-05-25_19:44:22.742121_phoo
    • 2023-05-25_19:44:22.742126_CJDu
    • 2023-05-25_19:44:22.742132_lfHD
    • 2023-05-25_19:44:22.742137_rGPT
    • 2023-05-25_19:44:22.742143_HGHn
    • 2023-05-25_19:44:22.742148_zvWu
    • 2023-05-25_19:44:22.742153_WcuZ

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilee189eeda13ff67DiffSignificant (?)
    p10192 ±4 ms196 ±2 ms+4.76 ms (+2.5%)NO
    p25197 ±5 ms202 ±3 ms+4.84 ms (+2.5%)NO
    p50204 ±5 ms210 ±2 ms+5.67 ms (+2.8%)NO
    p75213 ±5 ms219 ±4 ms+5.82 ms (+2.7%)NO
    p90222 ±5 ms233 ±9 ms+11.5 ms (+5.2%)NO

    20 test runs in comparison
    CommitTest Runs
    e189eed
    • 2023-05-24_18:15:06.486796_ETRV
    • 2023-05-24_18:15:06.491099_XXbx
    • 2023-05-24_18:15:06.491124_kBaA
    • 2023-05-24_18:15:06.491135_nvOS
    • 2023-05-24_18:15:06.491142_RUla
    • 2023-05-24_18:15:06.491149_Dcxe
    • 2023-05-24_18:15:06.491156_DuxD
    • 2023-05-24_18:15:06.491163_xJhN
    • 2023-05-24_18:15:06.491170_pTrY
    • 2023-05-24_18:15:06.491177_CSrR
    a13ff67
    • 2023-05-25_19:44:22.739693_cxYT
    • 2023-05-25_19:44:22.742105_dMYf
    • 2023-05-25_19:44:22.742114_ASvP
    • 2023-05-25_19:44:22.742121_phoo
    • 2023-05-25_19:44:22.742126_CJDu
    • 2023-05-25_19:44:22.742132_lfHD
    • 2023-05-25_19:44:22.742137_rGPT
    • 2023-05-25_19:44:22.742143_HGHn
    • 2023-05-25_19:44:22.742148_zvWu
    • 2023-05-25_19:44:22.742153_WcuZ
    redfin-30
    Percentilee189eeda13ff67DiffSignificant (?)
    p10231 ±5 ms254 ±4 ms+23.8 ms (+10.3%)YES
    p25236 ±4 ms261 ±5 ms+25.0 ms (+10.6%)YES
    p50243 ±4 ms269 ±5 ms+25.4 ms (+10.4%)YES
    p75251 ±5 ms277 ±6 ms+26.0 ms (+10.3%)MAYBE
    p90261 ±5 ms288 ±8 ms+26.6 ms (+10.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    e189eed
    • 2023-05-24_18:15:06.486796_ETRV
    • 2023-05-24_18:15:06.491099_XXbx
    • 2023-05-24_18:15:06.491124_kBaA
    • 2023-05-24_18:15:06.491135_nvOS
    • 2023-05-24_18:15:06.491142_RUla
    • 2023-05-24_18:15:06.491149_Dcxe
    • 2023-05-24_18:15:06.491156_DuxD
    • 2023-05-24_18:15:06.491163_xJhN
    • 2023-05-24_18:15:06.491170_pTrY
    • 2023-05-24_18:15:06.491177_CSrR
    a13ff67
    • 2023-05-25_19:44:22.739693_cxYT
    • 2023-05-25_19:44:22.742105_dMYf
    • 2023-05-25_19:44:22.742114_ASvP
    • 2023-05-25_19:44:22.742121_phoo
    • 2023-05-25_19:44:22.742126_CJDu
    • 2023-05-25_19:44:22.742132_lfHD
    • 2023-05-25_19:44:22.742137_rGPT
    • 2023-05-25_19:44:22.742143_HGHn
    • 2023-05-25_19:44:22.742148_zvWu
    • 2023-05-25_19:44:22.742153_WcuZ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6v0BWfRLZR/index.html

@wu-hui wu-hui merged commit 2d2e008 into master May 26, 2023
@wu-hui wu-hui deleted the wuandy/FiltersOnSameField branch May 26, 2023 18:11
@firebase firebase locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
main-merge-ack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @cherylEnkidu