Skip to content

NO_RELEASE_CHANGE fix for changelog #5047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from daymxn June 1, 2023 19:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@davidmotson davidmotson enabled auto-merge (squash) June 1, 2023 19:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Unit Test Results

   162 files   -    150     162 suites   - 150   2m 2s ⏱️ - 9m 38s
1 160 tests  -    656  1 144 ✔️  -    653  16 💤  - 2  0  - 1 
2 320 runs   - 1 312  2 288 ✔️  - 1 307  32 💤  - 4  0  - 1 

Results for commit 0e33fb5. ± Comparison against base commit 8d21a34.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.34% (8d21a34) to 44.33% (7e73800) by -0.02%.

    FilenameBase (8d21a34)Merge (7e73800)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8isrIF3zOh.html

@davidmotson davidmotson merged commit aac9ef8 into master Jun 1, 2023
@davidmotson davidmotson deleted the davidmotson.firestore_fix branch June 1, 2023 19:14
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile8d21a347e73800DiffSignificant (?)
    p10321 ±12 μs326 ±12 μs+5.58 μs (+1.7%)NO
    p25331 ±17 μs339 ±15 μs+8.26 μs (+2.5%)NO
    p50360 ±49 μs367 ±31 μs+7.61 μs (+2.1%)NO
    p75396 ±88 μs441 ±85 μs+44.5 μs (+11.2%)NO
    p90465 ±131 μs555 ±136 μs+90.0 μs (+19.4%)NO

    20 test runs in comparison
    CommitTest Runs
    8d21a34
    • 2023-06-01_17:26:16.536957_Qpxl
    • 2023-06-01_17:26:16.540057_NMYw
    • 2023-06-01_17:26:16.540074_bgBJ
    • 2023-06-01_17:26:16.540080_Hoou
    • 2023-06-01_17:26:16.540085_sdtl
    • 2023-06-01_17:26:16.540091_sZov
    • 2023-06-01_17:26:16.540097_hZQz
    • 2023-06-01_17:26:16.540103_ByGP
    • 2023-06-01_17:26:16.540112_KFjJ
    • 2023-06-01_17:26:16.540118_btbt
    7e73800
    • 2023-06-01_19:26:08.010189_cQCN
    • 2023-06-01_19:26:08.014447_wnTQ
    • 2023-06-01_19:26:08.014465_puUP
    • 2023-06-01_19:26:08.014474_aBrA
    • 2023-06-01_19:26:08.014480_wkiE
    • 2023-06-01_19:26:08.014487_ufsD
    • 2023-06-01_19:26:08.014493_NWwc
    • 2023-06-01_19:26:08.014511_BXlD
    • 2023-06-01_19:26:08.014518_ZfZl
    • 2023-06-01_19:26:08.014524_BRdB
    redfin-30
    Percentile8d21a347e73800DiffSignificant (?)
    p10618 ±22 μs650 ±28 μs+31.6 μs (+5.1%)NO
    p25638 ±21 μs670 ±32 μs+32.3 μs (+5.1%)NO
    p50669 ±24 μs700 ±44 μs+31.0 μs (+4.6%)NO
    p75703 ±27 μs741 ±58 μs+38.4 μs (+5.5%)NO
    p90745 ±35 μs816 ±118 μs+70.5 μs (+9.5%)NO

    20 test runs in comparison
    CommitTest Runs
    8d21a34
    • 2023-06-01_17:26:16.536957_Qpxl
    • 2023-06-01_17:26:16.540057_NMYw
    • 2023-06-01_17:26:16.540074_bgBJ
    • 2023-06-01_17:26:16.540080_Hoou
    • 2023-06-01_17:26:16.540085_sdtl
    • 2023-06-01_17:26:16.540091_sZov
    • 2023-06-01_17:26:16.540097_hZQz
    • 2023-06-01_17:26:16.540103_ByGP
    • 2023-06-01_17:26:16.540112_KFjJ
    • 2023-06-01_17:26:16.540118_btbt
    7e73800
    • 2023-06-01_19:26:08.010189_cQCN
    • 2023-06-01_19:26:08.014447_wnTQ
    • 2023-06-01_19:26:08.014465_puUP
    • 2023-06-01_19:26:08.014474_aBrA
    • 2023-06-01_19:26:08.014480_wkiE
    • 2023-06-01_19:26:08.014487_ufsD
    • 2023-06-01_19:26:08.014493_NWwc
    • 2023-06-01_19:26:08.014511_BXlD
    • 2023-06-01_19:26:08.014518_ZfZl
    • 2023-06-01_19:26:08.014524_BRdB
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile8d21a347e73800DiffSignificant (?)
    p10189 ±3 ms195 ±3 ms+5.76 ms (+3.0%)NO
    p25195 ±3 ms200 ±3 ms+5.56 ms (+2.9%)NO
    p50202 ±3 ms208 ±2 ms+6.70 ms (+3.3%)NO
    p75210 ±3 ms218 ±2 ms+8.20 ms (+3.9%)NO
    p90218 ±3 ms234 ±7 ms+15.8 ms (+7.3%)NO

    20 test runs in comparison
    CommitTest Runs
    8d21a34
    • 2023-06-01_17:26:16.536957_Qpxl
    • 2023-06-01_17:26:16.540057_NMYw
    • 2023-06-01_17:26:16.540074_bgBJ
    • 2023-06-01_17:26:16.540080_Hoou
    • 2023-06-01_17:26:16.540085_sdtl
    • 2023-06-01_17:26:16.540091_sZov
    • 2023-06-01_17:26:16.540097_hZQz
    • 2023-06-01_17:26:16.540103_ByGP
    • 2023-06-01_17:26:16.540112_KFjJ
    • 2023-06-01_17:26:16.540118_btbt
    7e73800
    • 2023-06-01_19:26:08.010189_cQCN
    • 2023-06-01_19:26:08.014447_wnTQ
    • 2023-06-01_19:26:08.014465_puUP
    • 2023-06-01_19:26:08.014474_aBrA
    • 2023-06-01_19:26:08.014480_wkiE
    • 2023-06-01_19:26:08.014487_ufsD
    • 2023-06-01_19:26:08.014493_NWwc
    • 2023-06-01_19:26:08.014511_BXlD
    • 2023-06-01_19:26:08.014518_ZfZl
    • 2023-06-01_19:26:08.014524_BRdB
    redfin-30
    Percentile8d21a347e73800DiffSignificant (?)
    p10232 ±4 ms255 ±4 ms+23.0 ms (+9.9%)YES
    p25239 ±5 ms260 ±4 ms+21.0 ms (+8.8%)MAYBE
    p50247 ±5 ms267 ±5 ms+20.5 ms (+8.3%)MAYBE
    p75255 ±6 ms276 ±6 ms+21.3 ms (+8.3%)MAYBE
    p90266 ±6 ms288 ±8 ms+22.8 ms (+8.6%)NO

    20 test runs in comparison
    CommitTest Runs
    8d21a34
    • 2023-06-01_17:26:16.536957_Qpxl
    • 2023-06-01_17:26:16.540057_NMYw
    • 2023-06-01_17:26:16.540074_bgBJ
    • 2023-06-01_17:26:16.540080_Hoou
    • 2023-06-01_17:26:16.540085_sdtl
    • 2023-06-01_17:26:16.540091_sZov
    • 2023-06-01_17:26:16.540097_hZQz
    • 2023-06-01_17:26:16.540103_ByGP
    • 2023-06-01_17:26:16.540112_KFjJ
    • 2023-06-01_17:26:16.540118_btbt
    7e73800
    • 2023-06-01_19:26:08.010189_cQCN
    • 2023-06-01_19:26:08.014447_wnTQ
    • 2023-06-01_19:26:08.014465_puUP
    • 2023-06-01_19:26:08.014474_aBrA
    • 2023-06-01_19:26:08.014480_wkiE
    • 2023-06-01_19:26:08.014487_ufsD
    • 2023-06-01_19:26:08.014493_NWwc
    • 2023-06-01_19:26:08.014511_BXlD
    • 2023-06-01_19:26:08.014518_ZfZl
    • 2023-06-01_19:26:08.014524_BRdB

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ytiucj4Jbt/index.html

@firebase firebase locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants