Skip to content

Opt storage into M133 #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from daymxn June 1, 2023 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@davidmotson davidmotson enabled auto-merge (squash) June 1, 2023 19:27
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-storage

    Overall coverage changed from ? (aac9ef8) to 86.16% (6fd3934) by ?.

    46 individual files with coverage change

    FilenameBase (aac9ef8)Merge (6fd3934)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.99%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?83.50%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YVSf9WmDPl.html

@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Unit Test Results

  36 files   -    126    36 suites   - 126   6m 26s ⏱️ + 3m 51s
126 tests  - 1 034  126 ✔️  - 1 018  0 💤  - 16  0 ±0 
252 runs   - 2 068  252 ✔️  - 2 036  0 💤  - 32  0 ±0 

Results for commit 704fa08. ± Comparison against base commit aac9ef8.

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (6fd3934) and the base commit (aac9ef8) are not available.

No macrobenchmark data found for the base commit (aac9ef8). Analysis for the CI merge commit (6fd3934) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0ZN5nJbv5K/index.html

@davidmotson davidmotson merged commit 8b99319 into master Jun 1, 2023
@davidmotson davidmotson deleted the davidmotson.opt_in_storage_m133 branch June 1, 2023 20:11
@firebase firebase locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants