NO_RELEASE_CHANGE update changelogs to include kotlin #5049

davidmotson · 2023-06-01T20:55:51Z

No description provided.

github-actions · 2023-06-01T20:56:04Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-06-01T21:02:18Z

Coverage Report ¹

Affected Products

firebase-database
Overall coverage changed from 50.19% (8b99319) to 50.14% (5da3b91) by -0.04%.
Filename Base (8b99319) Merge (5da3b91) Diff
ChildChangeAccumulator.java 96.67% 83.33% -13.33%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/HDGIKqZeZ7.html

github-actions · 2023-06-01T21:03:04Z

Unit Test Results

  62 files +  26   62 suites +26 1m 39s ⏱️ - 4m 45s
413 tests +287 411 ✔️ +287 2 💤 +2 0 ❌ - 2
826 runs +574 822 ✔️ +572 4 💤 +4 0 ❌ - 2

Results for commit d5a36eb. ± Comparison against base commit 8b99319.

This pull request removes 126 and adds 413 tests. Note that renamed tests count towards both.

com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderDefaultApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderNamedApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProvider_noPreviousProvider_installsDebugProvider
com.google.firebase.appcheck.debug.testing.FirebaseAppCheckDebugTestingRegistrarTest ‑ testGetComponents
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceCachedBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceStreamBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferReachedEnd
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferResize
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ readStream
com.google.firebase.storage.DeleteTest ‑ deleteBlob
…

com.google.firebase.database.DataSnapshotTest ‑ basicIterationWorks
com.google.firebase.database.DataSnapshotTest ‑ existsWorks
com.google.firebase.database.DatabaseRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.database.MapperTest ‑ XMLAndURLBean
com.google.firebase.database.MapperTest ‑ allowNullEverywhere
com.google.firebase.database.MapperTest ‑ argConstructorCantBeDeserialized
com.google.firebase.database.MapperTest ‑ beanMapsMustHaveStringKeys
com.google.firebase.database.MapperTest ‑ beanMapsMustHaveStringKeysForSerializing
com.google.firebase.database.MapperTest ‑ beansCanContainBeanLists
com.google.firebase.database.MapperTest ‑ beansCanContainBeanMaps
…

google-oss-bot · 2023-06-01T21:07:53Z

Size Report ¹

Affected Products

No changes between base commit (8b99319) and merge commit (5da3b91).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/slgGkC0CoG.html

google-oss-bot · 2023-06-01T21:39:32Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (8b99319) and the CI merge commit (5da3b91)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 8b99319: https://storage.googleapis.com/firebase-sdk-metric-reports/BFlA8OLiNV/index.html
- 5da3b91: https://storage.googleapis.com/firebase-sdk-metric-reports/jt6s6S4N2u/index.html

Startup Times

`fire-fn`

Device Statistics Distributions

oriole-32

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	69.2 ±6 μs	67.7 ±9 μs	-1.49 μs (-2.1%)	NO
p25	73.2 ±7 μs	71.4 ±12 μs	-1.85 μs (-2.5%)	NO
p50	81.1 ±12 μs	79.1 ±19 μs	-2.03 μs (-2.5%)	NO
p75	91.3 ±18 μs	89.2 ±28 μs	-2.03 μs (-2.2%)	NO
p90	116 ±36 μs	108 ±38 μs	-7.87 μs (-6.8%)	NO

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

redfin-30

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	143 ±17 μs	136 ±18 μs	-7.58 μs (-5.3%)	NO
p25	150 ±17 μs	142 ±18 μs	-7.93 μs (-5.3%)	NO
p50	159 ±16 μs	151 ±18 μs	-7.91 μs (-5.0%)	NO
p75	172 ±18 μs	165 ±18 μs	-7.12 μs (-4.1%)	NO
p90	193 ±26 μs	188 ±30 μs	-5.03 μs (-2.6%)	NO

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

`fire-rtdb`

Device Statistics Distributions

oriole-32

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	35.4 ±6 μs	33.1 ±5 μs	-2.38 μs (-6.7%)	NO
p25	37.7 ±7 μs	35.2 ±5 μs	-2.51 μs (-6.7%)	NO
p50	41.8 ±9 μs	40.0 ±8 μs	-1.79 μs (-4.3%)	NO
p75	47.2 ±12 μs	47.4 ±11 μs	+163 ns (+0.3%)	NO
p90	57.2 ±18 μs	60.9 ±25 μs	+3.69 μs (+6.5%)	NO

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

redfin-30

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	77.9 ±17 μs	76.7 ±9 μs	-1.19 μs (-1.5%)	NO
p25	81.1 ±17 μs	80.0 ±9.6 μs	-1.04 μs (-1.3%)	NO
p50	85.8 ±18 μs	86.0 ±10 μs	+203 ns (+0.2%)	NO
p75	92.6 ±19 μs	94.5 ±12 μs	+1.89 μs (+2.0%)	NO
p90	104 ±21 μs	114 ±21 μs	+10.5 μs (+10.1%)	NO

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	190 ±3 ms	198 ±2 ms	+7.46 ms (+3.9%)	NO
p25	196 ±3 ms	204 ±3 ms	+7.35 ms (+3.7%)	NO
p50	203 ±4 ms	211 ±3 ms	+8.04 ms (+4.0%)	NO
p75	212 ±4 ms	220 ±5 ms	+8.35 ms (+3.9%)	NO
p90	219 ±5 ms	230 ±7 ms	+11.0 ms (+5.0%)	NO

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

redfin-30

Percentile	`8b99319`	`5da3b91`	Diff	Significant (?)
p10	232 ±4 ms	256 ±4 ms	+24.3 ms (+10.5%)	YES
p25	237 ±4 ms	262 ±4 ms	+24.5 ms (+10.3%)	YES
p50	245 ±4 ms	269 ±4 ms	+24.0 ms (+9.8%)	YES
p75	252 ±5 ms	278 ±4 ms	+26.0 ms (+10.3%)	YES
p90	261 ±4 ms	291 ±8 ms	+29.9 ms (+11.4%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`8b99319`	2023-06-01_20:32:43.538022_YjaS 2023-06-01_20:32:43.542536_AHlP 2023-06-01_20:32:43.542574_hcUq 2023-06-01_20:32:43.542582_zxnI 2023-06-01_20:32:43.542589_duqr 2023-06-01_20:32:43.542595_PEJA 2023-06-01_20:32:43.542602_sFMk 2023-06-01_20:32:43.542608_Eppk 2023-06-01_20:32:43.542619_bWcS 2023-06-01_20:32:43.542625_PVTi
`5da3b91`	2023-06-01_21:13:01.282737_ZtaF 2023-06-01_21:13:01.285474_jhRF 2023-06-01_21:13:01.285486_sKiy 2023-06-01_21:13:01.285493_xzrA 2023-06-01_21:13:01.285499_VVEj 2023-06-01_21:13:01.285504_XXOd 2023-06-01_21:13:01.285510_qWAC 2023-06-01_21:13:01.285515_oGpR 2023-06-01_21:13:01.285520_VcwN 2023-06-01_21:13:01.285526_zhVb

https://storage.googleapis.com/firebase-sdk-metric-reports/6YAwh5bVwD/index.html

NO_RELEASE_CHANGE update changelogs to include kotlin

d5a36eb

davidmotson requested a review from daymxn June 1, 2023 20:55

davidmotson enabled auto-merge (squash) June 1, 2023 20:56

daymxn approved these changes Jun 1, 2023

View reviewed changes

davidmotson merged commit 9c2aa45 into master Jun 1, 2023

davidmotson deleted the davidmotson.kotlin_release_fix branch June 1, 2023 21:04

firebase locked and limited conversation to collaborators Jul 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

NO_RELEASE_CHANGE update changelogs to include kotlin #5049

NO_RELEASE_CHANGE update changelogs to include kotlin #5049

Uh oh!

davidmotson commented Jun 1, 2023

Uh oh!

github-actions bot commented Jun 1, 2023

Uh oh!

google-oss-bot commented Jun 1, 2023

`firebase-database`

Uh oh!

github-actions bot commented Jun 1, 2023

Uh oh!

google-oss-bot commented Jun 1, 2023

Uh oh!

google-oss-bot commented Jun 1, 2023

`fire-fn`

`fire-rtdb`

`timeToInitialDisplay`

Uh oh!

Uh oh!

NO_RELEASE_CHANGE update changelogs to include kotlin #5049

NO_RELEASE_CHANGE update changelogs to include kotlin #5049

Uh oh!

Conversation

davidmotson commented Jun 1, 2023

Uh oh!

github-actions bot commented Jun 1, 2023

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Jun 1, 2023

Coverage Report 1

Affected Products

firebase-database

Test Logs

Uh oh!

github-actions bot commented Jun 1, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Jun 1, 2023

Size Report 1

Affected Products

Test Logs

Uh oh!

google-oss-bot commented Jun 1, 2023

Startup Time Report 1

Notes

Startup Times

fire-fn

fire-rtdb

timeToInitialDisplay

Uh oh!

Uh oh!

Coverage Report ¹

`firebase-database`

Size Report ¹

Startup Time Report ¹

`fire-fn`

`fire-rtdb`

`timeToInitialDisplay`