Skip to content

NO_RELEASE_CHANGE pin protolite version for transitive dep #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2023
Merged

NO_RELEASE_CHANGE pin protolite version for transitive dep #5050

merged 3 commits into from
Jun 5, 2023

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from daymxn June 1, 2023 21:12
@davidmotson davidmotson enabled auto-merge (squash) June 1, 2023 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2023 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (7b940f8) and merge commit (f6fc36a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Fg2WOqGtyn.html

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023 •
edited
Loading

Unit Test Results

   194 files   -    575     194 suites   - 575   2m 47s ⏱️ - 29m 55s
1 417 tests  - 3 494  1 401 ✔️  - 3 488  16 💤  -   5  0 ❌  - 1 
2 834 runs   - 6 426  2 802 ✔️  - 6 415  32 💤  - 10  0 ❌  - 1 

Results for commit 320a6e6. ± Comparison against base commit 7b940f8.

♻️ This comment has been updated with latest results.

@daymxn daymxn added size/XXL and removed size/XXL labels Jun 1, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2023 •
edited
Loading

Size Report 1

Affected Products

  • protolite-well-known-types

    TypeBase (7b940f8)Merge (f6fc36a)Diff
    aar999 kB999 kB-1 B (-0.0%)
    apk (release)666 kB666 kB-4 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UFRZoUPej4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 1, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fiam

    DeviceStatisticsDistributions
    oriole-32
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p107.03 ±2 ms5.87 ±2 ms-1.16 ms (-16.5%)NO
    p257.46 ±2 ms6.32 ±3 ms-1.14 ms (-15.2%)NO
    p508.17 ±2 ms7.05 ±3 ms-1.11 ms (-13.6%)NO
    p759.14 ±2 ms8.08 ±3 ms-1.06 ms (-11.6%)NO
    p9010.5 ±2 ms9.76 ±3 ms-694 μs (-6.6%)NO

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc
    redfin-30
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p1015.7 ±7 ms11.0 ±6 ms-4.71 ms (-30.0%)NO
    p2516.9 ±7 ms12.2 ±6 ms-4.73 ms (-28.0%)NO
    p5018.9 ±8 ms13.7 ±7 ms-5.16 ms (-27.3%)NO
    p7521.7 ±9 ms15.9 ±8 ms-5.73 ms (-26.4%)NO
    p9025.0 ±10 ms19.4 ±9 ms-5.64 ms (-22.6%)NO

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p10320 ±9.9 μs323 ±19 μs+3.08 μs (+1.0%)NO
    p25333 ±18 μs334 ±26 μs+874 ns (+0.3%)NO
    p50356 ±43 μs362 ±60 μs+6.53 μs (+1.8%)NO
    p75403 ±94 μs406 ±107 μs+3.44 μs (+0.9%)NO
    p90443 ±131 μs488 ±161 μs+45.3 μs (+10.2%)NO

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc
    redfin-30
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p10618 ±31 μs616 ±17 μs-1.90 μs (-0.3%)NO
    p25640 ±45 μs637 ±25 μs-3.74 μs (-0.6%)NO
    p50667 ±59 μs665 ±33 μs-1.73 μs (-0.3%)NO
    p75705 ±75 μs699 ±43 μs-6.15 μs (-0.9%)NO
    p90752 ±107 μs743 ±62 μs-9.48 μs (-1.3%)NO

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p10191 ±3 ms197 ±2 ms+5.76 ms (+3.0%)NO
    p25196 ±3 ms202 ±3 ms+5.95 ms (+3.0%)NO
    p50205 ±4 ms210 ±3 ms+5.24 ms (+2.6%)NO
    p75213 ±5 ms220 ±4 ms+6.90 ms (+3.2%)NO
    p90222 ±6 ms233 ±6 ms+11.7 ms (+5.3%)NO

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc
    redfin-30
    Percentile7b940f8f6fc36aDiffSignificant (?)
    p10231 ±3 ms253 ±2 ms+22.4 ms (+9.7%)YES
    p25237 ±3 ms259 ±3 ms+21.7 ms (+9.2%)YES
    p50244 ±3 ms267 ±3 ms+23.0 ms (+9.5%)YES
    p75251 ±3 ms276 ±4 ms+24.6 ms (+9.8%)YES
    p90259 ±4 ms289 ±6 ms+29.3 ms (+11.3%)YES

    19 test runs in comparison
    CommitTest Runs
    7b940f8
    • 2023-06-02_18:01:08.200971_rEgi
    • 2023-06-02_18:01:08.205258_NkLc
    • 2023-06-02_18:01:08.205279_SJUL
    • 2023-06-02_18:01:08.205289_rPLv
    • 2023-06-02_18:01:08.205296_rQzW
    • 2023-06-02_18:01:08.205303_Jhiq
    • 2023-06-02_18:01:08.205310_LkXU
    • 2023-06-02_18:01:08.205317_pire
    • 2023-06-02_18:01:08.205329_kBbt
    • 2023-06-02_18:01:08.205336_qMsc
    f6fc36a
    • 2023-06-05_16:58:47.677010_jswX
    • 2023-06-05_16:58:47.681676_TitP
    • 2023-06-05_16:58:47.681687_IURX
    • 2023-06-05_16:58:47.681693_CtEL
    • 2023-06-05_16:58:47.681699_RFEN
    • 2023-06-05_16:58:47.681704_zBhU
    • 2023-06-05_16:58:47.681710_wjYG
    • 2023-06-05_16:58:47.681715_UBec
    • 2023-06-05_16:58:47.681729_yMDc

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qe1taj77oQ/index.html

rlazo
rlazo reviewed Jun 1, 2023
View reviewed changes
@davidmotson davidmotson merged commit ac4e802 into master Jun 5, 2023
@davidmotson davidmotson deleted the davidmotson.protolite_version_pin branch June 5, 2023 19:58
@firebase firebase locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo left review comments

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @rlazo @daymxn