Skip to content

Update CHANGELOG.md for storage #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Update CHANGELOG.md for storage #5054

merged 1 commit into from
Jun 5, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jun 5, 2023

Use the lib name instead of the a var.

Use the lib name instead of the a var.
@rlazo rlazo requested review from davidmotson and daymxn June 5, 2023 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-storage
### {{firebase_storage_full}} version 20.2.1 {: #storage_v20-2-1}

* {{changed}} Migrated `firebase-storage` SDK to use standard Firebase executors.
  (GitHub [#4830](//github.com/firebase/firebase-android-sdk/issues/4830){: .external})

#### {{firebase_storage_full}} Kotlin extensions version 20.2.1 {: #storage-ktx_v20-2-1}

The Kotlin extensions library transitively includes the updated
`firebase-storage` library. The Kotlin extensions library has no additional
updates.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Unit Test Results

  36 files  +  30    36 suites  +30   6m 9s ⏱️ + 5m 53s
126 tests +108  126 ✔️ +108  0 💤 ±0  0 ±0 
252 runs  +216  252 ✔️ +216  0 💤 ±0  0 ±0 

Results for commit c4aa865. ± Comparison against base commit 2ee4783.

This pull request removes 18 and adds 126 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderDefaultApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderNamedApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProvider_noPreviousProvider_installsDebugProvider
com.google.firebase.appcheck.debug.testing.FirebaseAppCheckDebugTestingRegistrarTest ‑ testGetComponents
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceCachedBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceStreamBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferReachedEnd
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferResize
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ readStream
com.google.firebase.storage.DeleteTest ‑ deleteBlob
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-storage

    FilenameBase (2ee4783)Merge (4a9a85c)Diff
    NetworkRequest.java87.11%86.60%-0.52%
    UploadTask.java81.52%81.85%+0.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tbL9lZ3bz6.html

@VinayGuthal VinayGuthal self-requested a review June 5, 2023 19:39
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-app-check

    DeviceStatisticsDistributions
    oriole-32
    Percentile2ee47834a9a85cDiffSignificant (?)
    p101.01 ±1 ms431 ±718 μs-578 μs (-57.3%)NO
    p251.05 ±1 ms452 ±737 μs-597 μs (-56.9%)NO
    p501.11 ±1 ms496 ±761 μs-618 μs (-55.5%)NO
    p751.29 ±1 ms567 ±833 μs-723 μs (-56.1%)NO
    p901.55 ±2 ms688 ±961 μs-862 μs (-55.6%)NO

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU
    redfin-30
    Percentile2ee47834a9a85cDiffSignificant (?)
    p10857 ±1326 μs457 ±133 μs-401 μs (-46.8%)NO
    p25946 ±1481 μs534 ±232 μs-412 μs (-43.6%)NO
    p501.09 ±2 ms653 ±345 μs-435 μs (-40.0%)NO
    p751.27 ±2 ms845 ±526 μs-429 μs (-33.7%)NO
    p901.59 ±2 ms1.19 ±0.9 ms-395 μs (-24.9%)NO

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU
  • fire-gcs

    DeviceStatisticsDistributions
    oriole-32
    Percentile2ee47834a9a85cDiffSignificant (?)
    p1041.6 ±5 μs36.1 ±5 μs-5.56 μs (-13.4%)NO
    p2545.1 ±6 μs38.7 ±6 μs-6.36 μs (-14.1%)NO
    p5050.7 ±9 μs43.9 ±9 μs-6.76 μs (-13.3%)NO
    p7559.7 ±14 μs55.0 ±15 μs-4.77 μs (-8.0%)NO
    p9075.8 ±27 μs72.0 ±26 μs-3.85 μs (-5.1%)NO

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU
    redfin-30
    Percentile2ee47834a9a85cDiffSignificant (?)
    p1081.8 ±12 μs85.0 ±14 μs+3.19 μs (+3.9%)NO
    p2585.8 ±12 μs89.5 ±14 μs+3.71 μs (+4.3%)NO
    p5092.9 ±13 μs96.6 ±14 μs+3.68 μs (+4.0%)NO
    p75104 ±20 μs108 ±19 μs+4.16 μs (+4.0%)NO
    p90121 ±21 μs128 ±33 μs+7.05 μs (+5.8%)NO

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile2ee47834a9a85cDiffSignificant (?)
    p10190 ±4 ms194 ±2 ms+3.41 ms (+1.8%)NO
    p25196 ±4 ms201 ±1 ms+4.33 ms (+2.2%)NO
    p50203 ±5 ms208 ±2 ms+5.11 ms (+2.5%)NO
    p75211 ±5 ms217 ±2 ms+6.06 ms (+2.9%)NO
    p90220 ±5 ms231 ±6 ms+10.4 ms (+4.7%)NO

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU
    redfin-30
    Percentile2ee47834a9a85cDiffSignificant (?)
    p10230 ±4 ms255 ±5 ms+25.0 ms (+10.9%)YES
    p25236 ±4 ms261 ±5 ms+24.7 ms (+10.5%)YES
    p50243 ±4 ms268 ±5 ms+24.7 ms (+10.2%)YES
    p75251 ±6 ms277 ±5 ms+26.4 ms (+10.5%)MAYBE
    p90259 ±6 ms288 ±5 ms+29.3 ms (+11.3%)YES

    20 test runs in comparison
    CommitTest Runs
    2ee4783
    • 2023-06-05_18:13:07.300027_JXcZ
    • 2023-06-05_18:13:07.307278_tywU
    • 2023-06-05_18:13:07.307316_JNtE
    • 2023-06-05_18:13:07.307325_jMPP
    • 2023-06-05_18:13:07.307331_UOwd
    • 2023-06-05_18:13:07.307337_JxHr
    • 2023-06-05_18:13:07.307344_sHgS
    • 2023-06-05_18:13:07.307366_tGkD
    • 2023-06-05_18:13:07.307372_URzH
    • 2023-06-05_18:13:07.307378_XUnu
    4a9a85c
    • 2023-06-05_19:45:32.807467_BeZA
    • 2023-06-05_19:45:32.810019_hcLA
    • 2023-06-05_19:45:32.810031_JLXa
    • 2023-06-05_19:45:32.810037_OjtH
    • 2023-06-05_19:45:32.810044_LCAT
    • 2023-06-05_19:45:32.810049_fJAv
    • 2023-06-05_19:45:32.810055_UGfw
    • 2023-06-05_19:45:32.810060_DlUw
    • 2023-06-05_19:45:32.810066_aDHT
    • 2023-06-05_19:45:32.810071_eELU

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JcF7dDfn1e/index.html

@rlazo rlazo merged commit da0c550 into master Jun 5, 2023
@rlazo rlazo deleted the rlazo-patch-2 branch June 5, 2023 22:10
@firebase firebase locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants