Pin perf dependency on firebase-datatransport #5056

rlazo · 2023-06-06T16:49:18Z

No description provided.

github-actions · 2023-06-06T16:49:33Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-06-06T16:50:02Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-06-06T16:59:24Z

Coverage Report ¹

Affected Products

No changes between base commit (da0c550) and merge commit (65102c0).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/3FOVLQh8Cw.html

github-actions · 2023-06-06T17:02:12Z

Unit Test Results

  102 files +    66   102 suites +66 2m 32s ⏱️ - 3m 56s
  975 tests +  849   975 ✔️ +  849 0 💤 ±0 0 ❌ ±0
1 950 runs +1 698 1 950 ✔️ +1 698 0 💤 ±0 0 ❌ ±0

Results for commit fe157ed. ± Comparison against base commit da0c550.

This pull request removes 126 and adds 975 tests. Note that renamed tests count towards both.

com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderDefaultApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderNamedApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProvider_noPreviousProvider_installsDebugProvider
com.google.firebase.appcheck.debug.testing.FirebaseAppCheckDebugTestingRegistrarTest ‑ testGetComponents
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceCachedBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ advanceStreamBytes
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferReachedEnd
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ bufferResize
com.google.firebase.storage.AdaptiveStreamBufferTest ‑ readStream
com.google.firebase.storage.DeleteTest ‑ deleteBlob
…

com.google.firebase.perf.FirebasePerfRegistrarTest ‑ testGetComponents
com.google.firebase.perf.FirebasePerformanceTest ‑ firebasePerformanceInitialization_providesRcProvider_remoteConfigManagerIsSet
com.google.firebase.perf.FirebasePerformanceTest ‑ initFirebasePerformance_injectsMetadataIntoConfigResolver
com.google.firebase.perf.FirebasePerformanceTest ‑ initializeFirebasePerformance_emptyMetadataAndCache_metadataAndContextInjected
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceDisabledThenCleared_respectsManifestTrue
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsGlobalFlag
com.google.firebase.perf.FirebasePerformanceTest ‑ setDataCollectionDefaultEnabled_whenForceEnabledThenCleared_respectsManifestFalse
com.google.firebase.perf.FirebasePerformanceTest ‑ testAddingMoreThanMaxLocalAttributes
com.google.firebase.perf.FirebasePerformanceTest ‑ testBothManifestsAgree
…

google-oss-bot · 2023-06-06T17:04:26Z

Size Report ¹

Affected Products

firebase-perf
Type Base (da0c550) Merge (65102c0) Diff
apk (aggressive) 1.06 MB 1.06 MB +1.15 kB (+0.1%)
apk (release) 3.05 MB 3.06 MB +996 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/w4CoytDJww.html

google-oss-bot · 2023-06-06T17:26:56Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (da0c550) and the CI merge commit (65102c0)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- da0c550: https://storage.googleapis.com/firebase-sdk-metric-reports/7JYiepha9w/index.html
- 65102c0: https://storage.googleapis.com/firebase-sdk-metric-reports/Cr1z4Y49GY/index.html

Startup Times

`fire-perf`

Device Statistics Distributions

oriole-32

Percentile	`da0c550`	`65102c0`	Diff	Significant (?)
p10	260 ±24 μs	254 ±19 μs	-5.67 μs (-2.2%)	NO
p25	271 ±23 μs	264 ±18 μs	-7.26 μs (-2.7%)	NO
p50	289 ±21 μs	282 ±18 μs	-7.45 μs (-2.6%)	NO
p75	323 ±21 μs	310 ±17 μs	-13.3 μs (-4.1%)	NO
p90	396 ±37 μs	368 ±27 μs	-27.2 μs (-6.9%)	NO

20 test runs in comparison

Commit	Test Runs
`da0c550`	2023-06-05_22:26:13.406821_BTdZ 2023-06-05_22:26:13.409284_hDSv 2023-06-05_22:26:13.409295_QHBw 2023-06-05_22:26:13.409301_Ihzc 2023-06-05_22:26:13.409307_hUtZ 2023-06-05_22:26:13.409313_yKWY 2023-06-05_22:26:13.409320_nSPu 2023-06-05_22:26:13.409325_DzPS 2023-06-05_22:26:13.409333_LWeH 2023-06-05_22:26:13.409339_rgHp
`65102c0`	2023-06-06_17:06:48.049062_HyOS 2023-06-06_17:06:48.055576_duXD 2023-06-06_17:06:48.055588_GqZi 2023-06-06_17:06:48.055594_acuX 2023-06-06_17:06:48.055600_psMa 2023-06-06_17:06:48.055605_GOJH 2023-06-06_17:06:48.055610_LcVP 2023-06-06_17:06:48.055616_hQPq 2023-06-06_17:06:48.055621_zjYp 2023-06-06_17:06:48.055627_ZqAV

redfin-30

Percentile	`da0c550`	`65102c0`	Diff	Significant (?)
p10	783 ±109 μs	820 ±80 μs	+37.2 μs (+4.8%)	NO
p25	820 ±94 μs	853 ±73 μs	+32.9 μs (+4.0%)	NO
p50	868 ±93 μs	902 ±74 μs	+33.7 μs (+3.9%)	NO
p75	953 ±99 μs	993 ±86 μs	+40.4 μs (+4.2%)	NO
p90	1.10 ±0.1 ms	1.14 ±0.1 ms	+44.8 μs (+4.1%)	NO

20 test runs in comparison

Commit	Test Runs
`da0c550`	2023-06-05_22:26:13.406821_BTdZ 2023-06-05_22:26:13.409284_hDSv 2023-06-05_22:26:13.409295_QHBw 2023-06-05_22:26:13.409301_Ihzc 2023-06-05_22:26:13.409307_hUtZ 2023-06-05_22:26:13.409313_yKWY 2023-06-05_22:26:13.409320_nSPu 2023-06-05_22:26:13.409325_DzPS 2023-06-05_22:26:13.409333_LWeH 2023-06-05_22:26:13.409339_rgHp
`65102c0`	2023-06-06_17:06:48.049062_HyOS 2023-06-06_17:06:48.055576_duXD 2023-06-06_17:06:48.055588_GqZi 2023-06-06_17:06:48.055594_acuX 2023-06-06_17:06:48.055600_psMa 2023-06-06_17:06:48.055605_GOJH 2023-06-06_17:06:48.055610_LcVP 2023-06-06_17:06:48.055616_hQPq 2023-06-06_17:06:48.055621_zjYp 2023-06-06_17:06:48.055627_ZqAV

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`da0c550`	`65102c0`	Diff	Significant (?)
p10	191 ±4 ms	195 ±2 ms	+4.04 ms (+2.1%)	NO
p25	197 ±4 ms	201 ±2 ms	+4.05 ms (+2.1%)	NO
p50	205 ±4 ms	209 ±2 ms	+3.66 ms (+1.8%)	NO
p75	213 ±5 ms	217 ±2 ms	+4.04 ms (+1.9%)	NO
p90	220 ±5 ms	231 ±5 ms	+10.7 ms (+4.9%)	NO

20 test runs in comparison

Commit	Test Runs
`da0c550`	2023-06-05_22:26:13.406821_BTdZ 2023-06-05_22:26:13.409284_hDSv 2023-06-05_22:26:13.409295_QHBw 2023-06-05_22:26:13.409301_Ihzc 2023-06-05_22:26:13.409307_hUtZ 2023-06-05_22:26:13.409313_yKWY 2023-06-05_22:26:13.409320_nSPu 2023-06-05_22:26:13.409325_DzPS 2023-06-05_22:26:13.409333_LWeH 2023-06-05_22:26:13.409339_rgHp
`65102c0`	2023-06-06_17:06:48.049062_HyOS 2023-06-06_17:06:48.055576_duXD 2023-06-06_17:06:48.055588_GqZi 2023-06-06_17:06:48.055594_acuX 2023-06-06_17:06:48.055600_psMa 2023-06-06_17:06:48.055605_GOJH 2023-06-06_17:06:48.055610_LcVP 2023-06-06_17:06:48.055616_hQPq 2023-06-06_17:06:48.055621_zjYp 2023-06-06_17:06:48.055627_ZqAV

redfin-30

Percentile	`da0c550`	`65102c0`	Diff	Significant (?)
p10	231 ±2 ms	253 ±4 ms	+22.0 ms (+9.5%)	YES
p25	237 ±3 ms	259 ±4 ms	+22.6 ms (+9.6%)	YES
p50	244 ±3 ms	266 ±5 ms	+21.8 ms (+9.0%)	YES
p75	251 ±3 ms	275 ±6 ms	+23.2 ms (+9.2%)	MAYBE
p90	261 ±6 ms	287 ±5 ms	+25.5 ms (+9.8%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`da0c550`	2023-06-05_22:26:13.406821_BTdZ 2023-06-05_22:26:13.409284_hDSv 2023-06-05_22:26:13.409295_QHBw 2023-06-05_22:26:13.409301_Ihzc 2023-06-05_22:26:13.409307_hUtZ 2023-06-05_22:26:13.409313_yKWY 2023-06-05_22:26:13.409320_nSPu 2023-06-05_22:26:13.409325_DzPS 2023-06-05_22:26:13.409333_LWeH 2023-06-05_22:26:13.409339_rgHp
`65102c0`	2023-06-06_17:06:48.049062_HyOS 2023-06-06_17:06:48.055576_duXD 2023-06-06_17:06:48.055588_GqZi 2023-06-06_17:06:48.055594_acuX 2023-06-06_17:06:48.055600_psMa 2023-06-06_17:06:48.055605_GOJH 2023-06-06_17:06:48.055610_LcVP 2023-06-06_17:06:48.055616_hQPq 2023-06-06_17:06:48.055621_zjYp 2023-06-06_17:06:48.055627_ZqAV

https://storage.googleapis.com/firebase-sdk-metric-reports/RDdeSixoMK/index.html

visumickey · 2023-06-06T19:21:49Z

The change looks good to me. Can you explain why this is necessary?

Pin perf dependency on firebase-datatransport

fe157ed

rlazo requested review from visumickey and davidmotson June 6, 2023 16:49

rlazo added the no-changelog label Jun 6, 2023

rlazo enabled auto-merge (squash) June 6, 2023 17:19

rlazo requested a review from daymxn June 6, 2023 18:35

visumickey requested a review from mrober June 6, 2023 19:21

visumickey approved these changes Jun 6, 2023

View reviewed changes

rlazo merged commit 174e7d8 into master Jun 6, 2023

rlazo deleted the rl.perf.pintransport019 branch June 6, 2023 19:22

firebase locked and limited conversation to collaborators Jul 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pin perf dependency on firebase-datatransport #5056

Pin perf dependency on firebase-datatransport #5056

Uh oh!

rlazo commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Jun 6, 2023

Uh oh!

google-oss-bot commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023

Uh oh!

google-oss-bot commented Jun 6, 2023

`firebase-perf`

Uh oh!

google-oss-bot commented Jun 6, 2023

`fire-perf`

`timeToInitialDisplay`

Uh oh!

visumickey commented Jun 6, 2023

Uh oh!

Uh oh!

Pin perf dependency on firebase-datatransport #5056

Pin perf dependency on firebase-datatransport #5056

Uh oh!

Conversation

rlazo commented Jun 6, 2023

Uh oh!

github-actions bot commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Jun 6, 2023

Uh oh!

google-oss-bot commented Jun 6, 2023

Coverage Report 1

Affected Products

Test Logs

Uh oh!

github-actions bot commented Jun 6, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Jun 6, 2023

Size Report 1

Affected Products

firebase-perf

Test Logs

Uh oh!

google-oss-bot commented Jun 6, 2023

Startup Time Report 1

Notes

Startup Times

fire-perf

timeToInitialDisplay

Uh oh!

visumickey commented Jun 6, 2023

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2023 •

edited

Loading

Coverage Report ¹

Size Report ¹

`firebase-perf`

Startup Time Report ¹

`fire-perf`

`timeToInitialDisplay`