Add different default sampling rates for when RC fetch failed #5059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-perf### {{perfmon}} version 20.3.3 {: #performance_v20-3-3}
* {{fixed}} Fixed app start trace creation where some measured time could be NULL GitHub [#4730](//github.com/firebase/firebase-android-sdk/issues/4730){: .external}.
* {{changed}} Adjusted default behavior when remote config fetch fails.
#### {{perfmon}} Kotlin extensions version 20.3.3 {: #performance-ktx_v20-3-3}
The Kotlin extensions library transitively includes the updated
`firebase-performance` library. The Kotlin extensions library has no additional
updates. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
visumickey
reviewed
Jun 7, 2023
firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigResolver.java
Show resolved
Hide resolved
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
visumickey
approved these changes
Jun 7, 2023
firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigurationConstants.java
Show resolved
Hide resolved
firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigurationConstantsTest.java
Show resolved
Hide resolved
davidmotson
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Add different defaults for when RC fetch failed * Add changelog entry * Format * Add throttled case to isLastFetchFailed check * Add rc fetch failed defaults for cpu and memory capturing frequency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.