Skip to content

feat: add docs for functions-ktx #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Jun 8, 2019

I do realize the functions-ktx library hasn't been released yet, so maybe this should only be merged after its release.

@googlebot googlebot added cla: yes Override cla labels Jun 8, 2019
@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samtstern
Copy link
Contributor

/ok-to-test

Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rosariopfernandes , thanks for the PR! You're right, we will be able to merge this once we've made at least one release of functions-ktx(should happen within a month or so). So let's hold on to this till then

@rlazo rlazo requested a review from rachelsaunders August 21, 2019 20:21
Copy link
Contributor

@rachelsaunders rachelsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlazo rlazo merged commit 5be7129 into firebase:master Aug 21, 2019
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants