Skip to content

Add comments and asserts that didn't merge with PR 5059 #5063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Add comments and asserts that didn't merge with PR 5059 #5063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
325e54c
Add different defaults for when RC fetch failed
mrober Jun 7, 2023
3cce074
Add changelog entry
mrober Jun 7, 2023
f88dd06
Format
mrober Jun 7, 2023
23f833a
Add throttled case to isLastFetchFailed check
mrober Jun 7, 2023
d081ae3
Add rc fetch failed defaults for cpu and memory capturing frequency
mrober Jun 7, 2023
d6dabb0
Address comments
mrober Jun 7, 2023
4c973a0
Merge branch 'master' into fireperf-sampling-norc
mrober Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigurationConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ protected Long getDefault() {

@Override
protected Long getDefaultOnRcFetchFail() {
// Increase the typical default by factor of 3.
return getDefault() * 3;
}

Expand Down Expand Up @@ -313,6 +314,7 @@ protected Long getDefault() {

@Override
protected Long getDefaultOnRcFetchFail() {
// Increase the typical default by factor of 3.
return getDefault() * 3;
}

Expand Down
3 changes: 3 additions & 0 deletions firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigurationConstantsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ public void getInstance_TraceSamplingRate_validateConstants() {
TraceSamplingRate configFlag = TraceSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(1.00);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.TraceSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_trace_sampling_rate");
Expand All @@ -166,6 +167,7 @@ public void getInstance_NetworkRequestSamplingRate_validateConstants() {
NetworkRequestSamplingRate configFlag = NetworkRequestSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(1.00);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.NetworkRequestSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_network_request_sampling_rate");
Expand All @@ -177,6 +179,7 @@ public void getInstance_SessionsSamplingRate_validateConstants() {
SessionsSamplingRate configFlag = SessionsSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(0.01);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.0001);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.SessionSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_session_sampling_rate");
Expand Down