Skip to content

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Make default sampling rates for when RC fetch failed 1/1000 typical #5071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06307db
Make default sampling rates for when RC fetch failed 1/1000 typical d…
mrober Jun 8, 2023
3778284
Fix tests
mrober Jun 8, 2023
4ec336a
Change log message to warn and link to support
mrober Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigurationConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ protected Double getDefault() {

@Override
protected Double getDefaultOnRcFetchFail() {
// Reduce the typical default by 2 orders of magnitude.
return getDefault() / 100;
// Reduce the typical default by 3 orders of magnitude.
return getDefault() / 1000;
}

@Override
Expand Down Expand Up @@ -193,8 +193,8 @@ protected Double getDefault() {

@Override
protected Double getDefaultOnRcFetchFail() {
// Reduce the typical default by 2 orders of magnitude.
return getDefault() / 100;
// Reduce the typical default by 3 orders of magnitude.
return getDefault() / 1000;
}

@Override
Expand Down Expand Up @@ -579,8 +579,8 @@ protected Double getDefault() {

@Override
protected Double getDefaultOnRcFetchFail() {
// Reduce the typical default by 2 orders of magnitude.
return getDefault() / 100;
// Reduce the typical default by 3 orders of magnitude.
return getDefault() / 1000;
}

@Override
Expand Down
4 changes: 3 additions & 1 deletion firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,9 @@ private void triggerFirebaseRemoteConfigFetchAndActivateOnSuccessfulFetch() {
.addOnFailureListener(
executor,
ex -> {
logger.debug("Remote config fetch failed: %s", ex);
logger.warn(
"Call to Remote Config failed: %s. This may cause a degraded experience with Firebase Performance. Please reach out to Firebase Support https://firebase.google.com/support/",
ex);
firebaseRemoteConfigLastFetchTimestampMs = FETCH_NEVER_HAPPENED_TIMESTAMP_MS;
});
}
Expand Down
6 changes: 3 additions & 3 deletions firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,7 +1685,7 @@ public void getTraceSamplingRate_remoteConfigFetchFailed_returnsRCFailureDefault
.thenReturn(Optional.absent());
when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);

assertThat(testConfigResolver.getTraceSamplingRate()).isEqualTo(1.00 / 100);
assertThat(testConfigResolver.getTraceSamplingRate()).isEqualTo(1.00 / 1000);
}

@Test
Expand Down Expand Up @@ -1757,7 +1757,7 @@ public void getNetworkRequestSamplingRate_remoteConfigFetchFailed_returnsRCFailu
.thenReturn(Optional.absent());
when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);

assertThat(testConfigResolver.getNetworkRequestSamplingRate()).isEqualTo(1.00 / 100);
assertThat(testConfigResolver.getNetworkRequestSamplingRate()).isEqualTo(1.00 / 1000);
}

@Test
Expand Down Expand Up @@ -1989,7 +1989,7 @@ public void getSessionsSamplingRate_remoteConfigFetchFailed_returnsRCFailureDefa
.thenReturn(Optional.absent());
when(mockRemoteConfigManager.isLastFetchFailed()).thenReturn(true);

assertThat(testConfigResolver.getSessionsSamplingRate()).isEqualTo(0.01 / 100);
assertThat(testConfigResolver.getSessionsSamplingRate()).isEqualTo(0.01 / 1000);
}

@Test
Expand Down
6 changes: 3 additions & 3 deletions firebase-perf/src/test/java/com/google/firebase/perf/config/ConfigurationConstantsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public void getInstance_TraceSamplingRate_validateConstants() {
TraceSamplingRate configFlag = TraceSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(1.00);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.001);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.TraceSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_trace_sampling_rate");
Expand All @@ -167,7 +167,7 @@ public void getInstance_NetworkRequestSamplingRate_validateConstants() {
NetworkRequestSamplingRate configFlag = NetworkRequestSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(1.00);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.01);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.001);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.NetworkRequestSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_network_request_sampling_rate");
Expand All @@ -179,7 +179,7 @@ public void getInstance_SessionsSamplingRate_validateConstants() {
SessionsSamplingRate configFlag = SessionsSamplingRate.getInstance();

assertThat(configFlag.getDefault()).isEqualTo(0.01);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.0001);
assertThat(configFlag.getDefaultOnRcFetchFail()).isEqualTo(0.00001);
assertThat(configFlag.getDeviceCacheFlag())
.isEqualTo("com.google.firebase.perf.SessionSamplingRate");
assertThat(configFlag.getRemoteConfigFlag()).isEqualTo("fpr_vc_session_sampling_rate");
Expand Down