Skip to content

Release generator improvements #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 22, 2023
Merged

Conversation

davidmotson
Copy link
Collaborator

add json release config
add PR link parsing
remove intentionally skipped commits from all searched

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Unit Test Results

   794 files  +   632     794 suites  +632   37m 25s ⏱️ + 34m 47s
4 915 tests +3 753  4 893 ✔️ +3 747  21 💤 +  5  1 +1 
9 739 runs  +7 415  9 696 ✔️ +7 404  42 💤 +10  1 +1 

For more details on these failures, see this check.

Results for commit 67fa2cb. ± Comparison against base commit dd710a7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (dd710a7) to 50.12% (0c0d857) by -0.09%.

    FilenameBase (dd710a7)Merge (0c0d857)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    DefaultPersistenceManager.java75.73%74.76%-0.97%
    ViewProcessor.java92.10%91.79%-0.30%
    WebsocketConnection.java33.90%32.77%-1.13%
  • firebase-perf

    Overall coverage changed from ? (dd710a7) to 71.25% (0c0d857) by ?.

    103 individual files with coverage change

    FilenameBase (dd710a7)Merge (0c0d857)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?86.71%?
    AppStateUpdateHandler.java?92.86%?
    Clock.java?100.00%?
    ConfigResolver.java?93.43%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?76.92%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?89.66%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?96.67%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from ? (dd710a7) to 86.20% (0c0d857) by ?.

    46 individual files with coverage change

    FilenameBase (dd710a7)Merge (0c0d857)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.99%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?83.50%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LTtZDbFLGw.html

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

buildSrc Test Results

28 tests   28 ✔️  2m 20s ⏱️
  6 suites    0 💤
  6 files      0

Results for commit 67fa2cb.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2023

Startup Time Report 1

The report is too large (117,052 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ORUg2p3Ewh/index.html

@davidmotson
Copy link
Collaborator Author

example of generated json file:

{
  "changes": {
    "firebase-common": [
      {
        "commitId": "ad22aebec96b744643a6f6011c6cb2657517bea6",
        "prId": "5066",
        "author": "Rodrigo Lazo",
        "message": "Update CHANGELOG.md (#5066)\n\n",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/ad22aebec96b744643a6f6011c6cb2657517bea6",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5066"
      },
      {
        "commitId": "1c763f0d347daf2f71690906ffd2086174105783",
        "prId": "5011",
        "author": "Vinay Guthal",
        "message": "update heartbeat to provide support for c++ sdks (#5011)\n\n* update heartbeat to provide support for c++ sdks\r\n\r\n* update",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/1c763f0d347daf2f71690906ffd2086174105783",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5011"
      }
    ],
    "firebase-common/ktx": [],
    "firebase-firestore": [
      {
        "commitId": "e9d0de9e2a54724d9d93528560fd269e4100b4cb",
        "prId": "4015",
        "author": "Tom Andersen",
        "message": "Expose Multi-DB, and add tests. (#4015)\n\n* Expose Multi-DB, and add tests.\r\n\r\n* Undo\r\n\r\n* Add documentation and fix test.\r\n\r\n* Make pretty\r\n\r\n* Prevent public access by making multi-db methods package-private\r\n\r\n* Revert \"Prevent public access by making multi-db methods package-private\"\r\n\r\nThis reverts commit 8fbc22f8de5cc996e4eb59adf585c9ca3f0e3962.\r\n\r\n* Format\r\n\r\n* API\r\n\r\n* Fix method description\r\n\r\n* Changelog\r\n\r\n* Format",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/e9d0de9e2a54724d9d93528560fd269e4100b4cb",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/4015"
      },
      {
        "commitId": "cf98ca7587ba9fea7106c310e9bf7a9c372a6d3c",
        "prId": "5032",
        "author": "cherylEnkidu",
        "message": "improve readability (#5032)\n\n",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/cf98ca7587ba9fea7106c310e9bf7a9c372a6d3c",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5032"
      },
      {
        "commitId": "b39de050a0f534409c2e524c9b7ddd54d10fcde5",
        "prId": "5041",
        "author": "wu-hui",
        "message": "Add more tests with filters on the same field (#5041)\n\n* Add more tests",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/b39de050a0f534409c2e524c9b7ddd54d10fcde5",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5041"
      },
      {
        "commitId": "2d2e0081c80143a03730ffd903322c6122ca9bb9",
        "prId": "5034",
        "author": "wu-hui",
        "message": "Fix equality and inequality on the same field (#5034)\n\n",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/2d2e0081c80143a03730ffd903322c6122ca9bb9",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5034"
      }
    ],
    "firebase-firestore/ktx": [
      {
        "commitId": "e9d0de9e2a54724d9d93528560fd269e4100b4cb",
        "prId": "4015",
        "author": "Tom Andersen",
        "message": "Expose Multi-DB, and add tests. (#4015)\n\n* Expose Multi-DB, and add tests.\r\n\r\n* Undo\r\n\r\n* Add documentation and fix test.\r\n\r\n* Make pretty\r\n\r\n* Prevent public access by making multi-db methods package-private\r\n\r\n* Revert \"Prevent public access by making multi-db methods package-private\"\r\n\r\nThis reverts commit 8fbc22f8de5cc996e4eb59adf585c9ca3f0e3962.\r\n\r\n* Format\r\n\r\n* API\r\n\r\n* Fix method description\r\n\r\n* Changelog\r\n\r\n* Format",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/e9d0de9e2a54724d9d93528560fd269e4100b4cb",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/4015"
      }
    ],
    "firebase-perf": [
      {
        "commitId": "c1be5f977031f713fc20881ac39274629a23041c",
        "prId": "5071",
        "author": "Matthew Robertson",
        "message": "Make default sampling rates for when RC fetch failed 1/1000 typical (#5071)\n\n* Make default sampling rates for when RC fetch failed 1/1000 typical default\r\n\r\n* Fix tests\r\n\r\n* Change log message to warn and link to support",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/c1be5f977031f713fc20881ac39274629a23041c",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5071"
      },
      {
        "commitId": "daba1fa582697c088075896983a9e581275ac239",
        "prId": "5063",
        "author": "Matthew Robertson",
        "message": "Add comments and asserts that didn't merge with PR 5059 (#5063)\n\n* Add different defaults for when RC fetch failed\r\n\r\n* Add changelog entry\r\n\r\n* Format\r\n\r\n* Add throttled case to isLastFetchFailed check\r\n\r\n* Add rc fetch failed defaults for cpu and memory capturing frequency\r\n\r\n* Address comments",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/daba1fa582697c088075896983a9e581275ac239",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5063"
      },
      {
        "commitId": "dd042448652f8f51249bbe5c285c7af074cda40b",
        "prId": "5059",
        "author": "Matthew Robertson",
        "message": "Add different default sampling rates for when RC fetch failed (#5059)\n\n* Add different defaults for when RC fetch failed\r\n\r\n* Add changelog entry\r\n\r\n* Format\r\n\r\n* Add throttled case to isLastFetchFailed check\r\n\r\n* Add rc fetch failed defaults for cpu and memory capturing frequency",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/dd042448652f8f51249bbe5c285c7af074cda40b",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5059"
      },
      {
        "commitId": "174e7d86b7671ba1ae5652d65a353cac7eff1f17",
        "prId": "5056",
        "author": "Rodrigo Lazo",
        "message": "Pin perf dependency on firebase-datatransport (#5056)\n\n",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/174e7d86b7671ba1ae5652d65a353cac7eff1f17",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5056"
      },
      {
        "commitId": "28e3a6821910a0ae452fbcc5b173fafe919ddbaf",
        "prId": "4762",
        "author": "Visu",
        "message": "Check if the trace times are not NULL before creating the AppStartTrace. (#4762)\n\n",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/28e3a6821910a0ae452fbcc5b173fafe919ddbaf",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/4762"
      }
    ],
    "firebase-perf/ktx": [],
    "firebase-storage/ktx": [],
    "firebase-storage": [
      {
        "commitId": "da0c55093bf498c03de4132e3d44d29fdc2a8432",
        "prId": "5054",
        "author": "Rodrigo Lazo",
        "message": "Update CHANGELOG.md for storage (#5054)\n\nUse the lib name instead of the a var.",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/da0c55093bf498c03de4132e3d44d29fdc2a8432",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5054"
      },
      {
        "commitId": "8b99319731886558d93a643851e21c9d865b79ff",
        "prId": "5048",
        "author": "David Motsonashvili",
        "message": "Opt storage into M133 (#5048)\n\nCo-authored-by: David Motsonashvili <[email protected]>",
        "commitLink": "https://github.com/firebase/firebase-android-sdk/commit/8b99319731886558d93a643851e21c9d865b79ff",
        "prLink": "https://github.com/firebase/firebase-android-sdk/pull/5048"
      }
    ]
  },
  "changedLibrariesWithNoChangelog": [
    ":firebase-crashlytics",
    ":firebase-crashlytics-ndk",
    ":firebase-crashlytics:ktx",
    ":firebase-functions",
    ":firebase-functions:ktx",
    ":firebase-messaging",
    ":firebase-messaging-directboot",
    ":firebase-messaging:ktx",
    ":appcheck:firebase-appcheck",
    ":appcheck:firebase-appcheck:ktx",
    ":appcheck:firebase-appcheck-debug",
    ":appcheck:firebase-appcheck-playintegrity",
    ":appcheck:firebase-appcheck-debug-testing",
    ":transport:transport-runtime"
  ]
}

@davidmotson davidmotson requested a review from daymxn June 15, 2023 17:31
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A parsable release report is huge for CI and tooling. Great job! I left a few comments- some of which are nits, but others are worth addressing before merging.

@davidmotson davidmotson requested a review from daymxn June 21, 2023 18:21
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run ktfmt to fix the formatting issues, and so long as the tests pass- LGTM:)

@davidmotson davidmotson merged commit d028b21 into master Jun 22, 2023
@davidmotson davidmotson deleted the davidmotson.release_fixes branch June 22, 2023 21:29
@firebase firebase locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants