-
Notifications
You must be signed in to change notification settings - Fork 625
Release generator improvements #5077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ipped commits from all searched
Release note changesNo release note changes were detected. If you made changes that should be |
Unit Test Results 794 files + 632 794 suites +632 37m 25s ⏱️ + 34m 47s For more details on these failures, see this check. Results for commit 67fa2cb. ± Comparison against base commit dd710a7. ♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsNo changes between base commit (dd710a7) and merge commit (0c0d857).Test Logs |
example of generated json file:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A parsable release report is huge for CI and tooling. Great job! I left a few comments- some of which are nits, but others are worth addressing before merging.
buildSrc/src/main/java/com/google/firebase/gradle/plugins/ReleaseGenerator.kt
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/ReleaseGenerator.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/ReleaseGenerator.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/ReleaseGenerator.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/PublishingPlugin.kt
Show resolved
Hide resolved
buildSrc/src/main/java/com/google/firebase/gradle/plugins/ReleaseGenerator.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run ktfmt to fix the formatting issues, and so long as the tests pass- LGTM:)
add json release config
add PR link parsing
remove intentionally skipped commits from all searched