Skip to content

Upgrade to agp 7.4.2 #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2023
Merged

Upgrade to agp 7.4.2 #5127

merged 5 commits into from
Jul 14, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 1, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023 •
edited
Loading

buildSrc Test Results

28 tests   28 ✔️  1m 33s ⏱️
  6 suites    0 💤
  6 files      0 ❌

Results for commit 380fa42.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023 •
edited
Loading

Unit Test Results

   818 files  ±0     818 suites  ±0   36m 32s ⏱️ -58s
4 956 tests ±0  4 935 ✔️ +1  21 💤 ±0  0 ❌  - 1 
9 821 runs  ±0  9 779 ✔️ +1  42 💤 ±0  0 ❌  - 1 

Results for commit 380fa42. ± Comparison against base commit 3dd80b1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar13.9 kB13.9 kB-7 B (-0.1%)

  • firebase-appcheck

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar36.9 kB36.9 kB-6 B (-0.0%)

  • firebase-appcheck-debug

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar11.3 kB11.3 kB-7 B (-0.1%)

  • firebase-appcheck-debug-testing

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar7.37 kB7.37 kB-6 B (-0.1%)

  • firebase-appcheck-interop

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.11 kB5.10 kB-7 B (-0.1%)

  • firebase-appcheck-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar6.08 kB6.08 kB-3 B (-0.0%)

  • firebase-appcheck-playintegrity

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar11.1 kB11.1 kB-6 B (-0.1%)

  • firebase-appcheck-safetynet

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar10.5 kB10.5 kB-5 B (-0.0%)

  • firebase-appdistribution

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar250 kB247 kB-3.16 kB (-1.3%)

  • firebase-appdistribution-api

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar16.1 kB16.0 kB-3 B (-0.0%)

  • firebase-appdistribution-api-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.95 kB5.94 kB-4 B (-0.1%)

  • firebase-common

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar75.8 kB75.7 kB-89 B (-0.1%)

  • firebase-common-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar13.4 kB13.3 kB-8 B (-0.1%)

  • firebase-components

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar45.1 kB45.1 kB-6 B (-0.0%)

  • firebase-config

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar89.7 kB89.7 kB-10 B (-0.0%)

  • firebase-config-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar10.0 kB10.0 kB-10 B (-0.1%)

  • firebase-crashlytics

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar357 kB357 kB-8 B (-0.0%)

  • firebase-crashlytics-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar7.41 kB7.40 kB-7 B (-0.1%)

  • firebase-crashlytics-ndk

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar1.66 MB1.66 MB-380 B (-0.0%)

  • firebase-database

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar488 kB488 kB-9 B (-0.0%)

  • firebase-database-collection

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar33.7 kB33.7 kB-6 B (-0.0%)

  • firebase-database-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar28.2 kB28.2 kB-8 B (-0.0%)

  • firebase-datatransport

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.01 kB5.00 kB-6 B (-0.1%)

  • firebase-decoders-json

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar7.76 kB7.76 kB-5 B (-0.1%)

  • firebase-dynamic-links

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar54.7 kB53.6 kB-1.14 kB (-2.1%)

  • firebase-dynamic-links-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar8.40 kB8.39 kB-6 B (-0.1%)

  • firebase-dynamic-module-support

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.73 kB5.73 kB-8 B (-0.1%)

  • firebase-encoders-json

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar11.4 kB11.4 kB-8 B (-0.1%)

  • firebase-encoders-reflective

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar7.89 kB7.88 kB-8 B (-0.1%)

  • firebase-firestore

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar1.36 MB1.36 MB-8 B (-0.0%)

  • firebase-firestore-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar25.4 kB25.4 kB-7 B (-0.0%)

  • firebase-functions

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar47.1 kB47.1 kB-11 B (-0.0%)

  • firebase-functions-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar6.34 kB6.33 kB-9 B (-0.1%)

  • firebase-inappmessaging

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar453 kB453 kB-6 B (-0.0%)

  • firebase-inappmessaging-display

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar180 kB179 kB-1.62 kB (-0.9%)

  • firebase-inappmessaging-display-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar17.7 kB17.7 kB-8 B (-0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.14 kB5.13 kB-11 B (-0.2%)

  • firebase-installations

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar55.4 kB55.4 kB-8 B (-0.0%)

  • firebase-installations-interop

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar8.16 kB8.16 kB-5 B (-0.1%)

  • firebase-installations-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.12 kB5.11 kB-2 B (-0.0%)

  • firebase-messaging

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar142 kB142 kB-96 B (-0.1%)

  • firebase-messaging-directboot

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar5.20 kB5.19 kB-6 B (-0.1%)

  • firebase-messaging-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar6.22 kB6.21 kB-4 B (-0.1%)

  • firebase-ml-modeldownloader

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar118 kB118 kB-4 B (-0.0%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar6.23 kB6.22 kB-3 B (-0.0%)

  • firebase-perf

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar318 kB318 kB-7 B (-0.0%)

  • firebase-perf-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar16.1 kB16.1 kB-10 B (-0.1%)

  • firebase-sessions

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar107 kB107 kB-6 B (-0.0%)

  • firebase-storage

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar115 kB115 kB-8 B (-0.0%)

  • firebase-storage-ktx

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar13.2 kB13.2 kB-9 B (-0.1%)

  • protolite-well-known-types

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar1.00e+03 kB1.00e+03 kB-7 B (-0.0%)

  • transport-api

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar6.81 kB6.81 kB-6 B (-0.1%)

  • transport-backend-cct

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar53.8 kB53.8 kB-8 B (-0.0%)

  • transport-runtime

    TypeBase (3dd80b1)Merge (425cf98)Diff
    aar180 kB180 kB-10 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2J4L4KVOQo.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (3dd80b1) to 50.13% (425cf98) by -0.04%.

    FilenameBase (3dd80b1)Merge (425cf98)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-firestore

    Overall coverage changed from 44.34% (3dd80b1) to 44.34% (425cf98) by -0.00%.

    FilenameBase (3dd80b1)Merge (425cf98)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-messaging

    Overall coverage changed from 84.21% (3dd80b1) to 84.14% (425cf98) by -0.08%.

    FilenameBase (3dd80b1)Merge (425cf98)Diff
    MessagingAnalytics.java81.78%81.38%-0.40%
    Metadata.java41.27%36.51%-4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DTtuBbcX06.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 1, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (122,586 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NceIhkJAn5/index.html

@rlazo rlazo marked this pull request as ready for review July 13, 2023 20:13
@rlazo rlazo requested review from daymxn and davidmotson July 13, 2023 20:13
daymxn
daymxn approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but they can be addressed whenever we get around to migrating the build file to ktx.

@rlazo rlazo merged commit bb0ac26 into master Jul 14, 2023
@rlazo rlazo deleted the rl.agp.742 branch July 14, 2023 15:47
@firebase firebase locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
no-changelog size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn