Skip to content

Multiple inequality support #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Sep 12, 2023
Merged

Multiple inequality support #5194

merged 41 commits into from
Sep 12, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Jul 25, 2023 •
edited
Loading

port from Web SDK: firebase/firebase-js-sdk#7453

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 25, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.63% (dfa22c7) to 44.62% (0af9a26) by -0.01%.

    FilenameBase (dfa22c7)Merge (0af9a26)Diff
    CompositeFilter.java98.57%90.91%-7.66%
    FieldFilter.java93.06%94.20%+1.15%
    Query.java3.96%4.27%+0.31%
    SetMutation.java97.22%94.44%-2.78%
    SQLiteIndexManager.java99.51%99.51%+0.00%
    TargetIndexMatcher.java97.78%96.81%-0.97%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mEiIQ7wWnD.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

Unit Test Results

   164 files  ±0     164 suites  ±0   2m 19s ⏱️ +3s
1 208 tests +3  1 192 ✔️ +3  16 💤 ±0  0 ❌ ±0 
2 416 runs  +6  2 384 ✔️ +6  32 💤 ±0  0 ❌ ±0 

Results for commit 94d28a6. ± Comparison against base commit dfa22c7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 25, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (dfa22c7)Merge (0af9a26)Diff
    aar1.36 MB1.36 MB-783 B (-0.1%)
    apk (release)3.95 MB3.95 MB-932 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/59pgHAPSbG.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 25, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (57209c1) and the base commit (dff55b6) are not available.

No macrobenchmark data found for the base commit (dff55b6). Analysis for the CI merge commit (57209c1) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/53vK79l3iG/index.html

@milaGGL milaGGL changed the title Mila/multiple inequality support Multiple inequality support Jul 25, 2023
@milaGGL milaGGL marked this pull request as ready for review July 25, 2023 20:39
@milaGGL milaGGL requested a review from ehsannas July 25, 2023 20:40
ehsannas
ehsannas approved these changes Jul 27, 2023
View reviewed changes
@cherylEnkidu cherylEnkidu self-assigned this Aug 24, 2023
dconeybe
dconeybe requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cherylEnkidu Just one minor comment about using a SortedSet. Other than that, the indexing-related changes LGTM. I did not review any other parts of this PR (I only reviewed the changes made by @cherylEnkidu)

@milaGGL milaGGL requested a review from dconeybe September 1, 2023 22:36
ehsannas
ehsannas reviewed Sep 1, 2023
View reviewed changes
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@milaGGL milaGGL requested review from dconeybe and removed request for dconeybe September 12, 2023 19:56
@milaGGL milaGGL merged commit c5a894c into master Sep 12, 2023
@milaGGL milaGGL deleted the mila/multiple-inequality-support branch September 12, 2023 20:21
@firebase firebase locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@xwkuang5 xwkuang5 xwkuang5 left review comments

@wu-hui wu-hui wu-hui approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees
No one assigned
Labels
no-changelog size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@milaGGL @google-oss-bot @ehsannas @xwkuang5 @wu-hui @dconeybe @cherylEnkidu