Skip to content

add new check in validateProjectsToPublishTask #5204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2023
Merged

add new check in validateProjectsToPublishTask #5204

merged 3 commits into from
Jul 27, 2023

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from rlazo July 26, 2023 21:53
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

Unit Test Results

   818 files  +  49     818 suites  +49   38m 27s ⏱️ + 2m 20s
4 956 tests ±    0  4 934 ✔️ +    1  21 💤 ±0  1 ❌  - 1 
9 821 runs  +960  9 778 ✔️ +961  42 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 4ca1f3e. ± Comparison against base commit 24d1983.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-perf

    Overall coverage changed from 71.20% (3d3eeaf) to 71.17% (c1d735e) by -0.03%.

    FilenameBase (3d3eeaf)Merge (c1d735e)Diff
    MemoryGaugeCollector.java91.38%89.66%-1.72%
    RateLimiter.java91.54%90.77%-0.77%

  • firebase-storage

    Overall coverage changed from ? (3d3eeaf) to 85.90% (c1d735e) by ?.

    46 individual files with coverage change

    FilenameBase (3d3eeaf)Merge (c1d735e)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?82.51%?
    Util.java?73.24%?

  • firebase-firestore

    FilenameBase (3d3eeaf)Merge (c1d735e)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/euj3t5g7u8.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

buildSrc Test Results

33 tests   33 ✔️  1m 18s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 9e2f1c4.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (3d3eeaf) and merge commit (c1d735e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XWkIat6b5k.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (122,609 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0XZmnGDCCN/index.html

@davidmotson davidmotson enabled auto-merge (squash) July 27, 2023 13:18
@davidmotson davidmotson merged commit 771003d into master Jul 27, 2023
@davidmotson davidmotson deleted the davidmotson.add_lg_publication_check branch July 27, 2023 13:32
@firebase firebase locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmotson @google-oss-bot @rlazo