Skip to content

Populate DataCollectionStatus for Crashlytics and Perf in Sessions #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jul 26, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-sessions

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from 75.99% (824195e) to 76.44% (3936254) by +0.45%.

    FilenameBase (824195e)Merge (3936254)Diff
    SessionEvents.kt97.06%97.78%+0.72%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GNKRpKR05C.html

@github-actions
Copy link
Contributor

Unit Test Results

     79 files       79 suites   2m 11s ⏱️
1 028 tests 1 027 ✔️ 0 💤 1
1 096 runs  1 095 ✔️ 0 💤 1

For more details on these failures, see this check.

Results for commit b25d103.

@mrober mrober enabled auto-merge (squash) July 26, 2023 22:08
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Size Report 1

Affected Products

  • firebase-sessions

    TypeBase (824195e)Merge (3936254)Diff
    aar107 kB107 kB+723 B (+0.7%)
    apk (aggressive)364 kB364 kB+204 B (+0.1%)
    apk (release)2.06 MB2.06 MB+400 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8XNrYUtRJM.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 26, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195e3936254DiffSignificant (?)
    p1012.7 ±5 ms13.2 ±5 ms+458 μs (+3.6%)NO
    p2513.4 ±6 ms14.1 ±5 ms+678 μs (+5.1%)NO
    p5014.5 ±6 ms15.3 ±6 ms+791 μs (+5.5%)NO
    p7516.0 ±6 ms16.9 ±6 ms+940 μs (+5.9%)NO
    p9018.1 ±7 ms19.2 ±6 ms+1.14 ms (+6.3%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
    redfin-30
    Percentile824195e3936254DiffSignificant (?)
    p1023.8 ±12 ms22.1 ±11 ms-1.75 ms (-7.4%)NO
    p2525.0 ±13 ms23.3 ±12 ms-1.66 ms (-6.6%)NO
    p5027.0 ±15 ms25.3 ±13 ms-1.63 ms (-6.1%)NO
    p7529.7 ±16 ms28.6 ±15 ms-1.05 ms (-3.5%)NO
    p9032.9 ±17 ms32.5 ±15 ms-423 μs (-1.3%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
  • fire-perf

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195e3936254DiffSignificant (?)
    p10254 ±19 μs252 ±23 μs-1.82 μs (-0.7%)NO
    p25269 ±18 μs262 ±22 μs-6.31 μs (-2.3%)NO
    p50289 ±21 μs280 ±21 μs-9.10 μs (-3.1%)NO
    p75326 ±31 μs311 ±18 μs-15.6 μs (-4.8%)NO
    p90395 ±39 μs363 ±35 μs-32.1 μs (-8.1%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
    redfin-30
    Percentile824195e3936254DiffSignificant (?)
    p10755 ±78 μs740 ±71 μs-15.0 μs (-2.0%)NO
    p25785 ±76 μs772 ±73 μs-12.9 μs (-1.6%)NO
    p50840 ±78 μs871 ±190 μs+30.7 μs (+3.7%)NO
    p75933 ±110 μs976 ±223 μs+42.5 μs (+4.6%)NO
    p901.05 ±0.1 ms1.20 ±0.4 ms+144 μs (+13.7%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195e3936254DiffSignificant (?)
    p107.51 ±0.8 ms6.94 ±0.5 ms-576 μs (-7.7%)NO
    p257.85 ±0.8 ms7.31 ±0.5 ms-540 μs (-6.9%)NO
    p508.31 ±0.9 ms8.00 ±0.5 ms-313 μs (-3.8%)NO
    p758.99 ±1 ms8.94 ±0.6 ms-45.7 μs (-0.5%)NO
    p9010.1 ±0.9 ms10.1 ±0.6 ms-41.4 μs (-0.4%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
    redfin-30
    Percentile824195e3936254DiffSignificant (?)
    p1014.4 ±3 ms14.3 ±4 ms-123 μs (-0.9%)NO
    p2515.8 ±4 ms15.7 ±5 ms-61.1 μs (-0.4%)NO
    p5018.1 ±6 ms18.1 ±6 ms+57.1 μs (+0.3%)NO
    p7521.6 ±6 ms21.7 ±7 ms+99.8 μs (+0.5%)NO
    p9025.2 ±6 ms25.6 ±7 ms+345 μs (+1.4%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile824195e3936254DiffSignificant (?)
    p10199 ±4 ms203 ±2 ms+4.36 ms (+2.2%)NO
    p25205 ±6 ms210 ±2 ms+4.57 ms (+2.2%)NO
    p50212 ±5 ms218 ±2 ms+5.19 ms (+2.4%)NO
    p75221 ±5 ms225 ±2 ms+4.33 ms (+2.0%)NO
    p90229 ±6 ms235 ±3 ms+5.91 ms (+2.6%)NO

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf
    redfin-30
    Percentile824195e3936254DiffSignificant (?)
    p10244 ±3 ms264 ±4 ms+20.4 ms (+8.4%)YES
    p25251 ±4 ms271 ±5 ms+20.2 ms (+8.1%)MAYBE
    p50258 ±4 ms279 ±5 ms+20.9 ms (+8.1%)MAYBE
    p75267 ±5 ms288 ±6 ms+21.2 ms (+7.9%)MAYBE
    p90278 ±6 ms301 ±8 ms+23.5 ms (+8.5%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    824195e
    • 2023-07-28_03:35:35.982214_AWxO
    • 2023-07-28_03:35:35.985616_luuq
    • 2023-07-28_03:35:35.985627_ngKl
    • 2023-07-28_03:35:35.985634_KfiG
    • 2023-07-28_03:35:35.985639_OTOo
    • 2023-07-28_03:35:35.985645_fqMS
    • 2023-07-28_03:35:35.985650_CtJY
    • 2023-07-28_03:35:35.985655_toOT
    • 2023-07-28_03:35:35.985660_OEas
    • 2023-07-28_03:35:35.985666_dAGt
    3936254
    • 2023-07-28_19:57:26.047381_QitK
    • 2023-07-28_19:57:26.048452_uDff
    • 2023-07-28_19:57:26.048462_lnsm
    • 2023-07-28_19:57:26.048469_HZFX
    • 2023-07-28_19:57:26.048475_KCfz
    • 2023-07-28_19:57:26.048480_nEnG
    • 2023-07-28_19:57:26.048486_woUn
    • 2023-07-28_19:57:26.048492_yzZI
    • 2023-07-28_19:57:26.048497_qugF
    • 2023-07-28_19:57:26.048504_SHrf

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FrG3uQWR1b/index.html

@mrober mrober merged commit afe23b6 into master Jul 28, 2023
@mrober mrober deleted the sessions-datacolstate branch July 28, 2023 19:50
@firebase firebase locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants