Setup CI for named db tests #5206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
wu-hui
force-pushed
the
wuandy/TestNamedDb
branch
from
7443794 to
9704f53
Compare
wu-hui
force-pushed
the
wuandy/TestNamedDb
branch
from
85bd6ba to
776d97c
Compare
Size Report 1Affected Products
Test Logs |
rlazo
approved these changes
Jul 31, 2023
| @@ -70,6 +70,12 @@ android { | |||
| def targetBackend = findProperty("targetBackend") ?: "emulator" | |||
| buildConfigField("String", "TARGET_BACKEND", "\"$targetBackend\"") | |||
|
|
|||
| if (findProperty('targetDatabaseId')) { | |||
There was a problem hiding this comment.
Alternatively
def targetDatabaseId = findProperty('targetDatabaseId') ?: "(default)"
buildConfigField("String", "TARGET_DATABASE_ID", "\"$targetDatabaseId\"")
davidmotson
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Initial setup * fix gradle file * separate job * Control * Address Feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example run of the new job: https://github.com/firebase/firebase-android-sdk/actions/runs/5684374125/job/15407013872?pr=5206
This PR has two parts:
test-dbas opposed to the default one.test-dbtests due to asserts that are too restrictive.