Skip to content

Rename variable to keep naming convention #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2023
Merged

Rename variable to keep naming convention #5209

merged 3 commits into from
Jul 28, 2023

Conversation

cherylEnkidu
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@cherylEnkidu cherylEnkidu assigned dconeybe and unassigned wu-hui Jul 27, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.49% (c5cd536) to 44.48% (c6dfe65) by -0.01%.

    FilenameBase (c5cd536)Merge (c6dfe65)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/w3JphCqiNl.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023 •
edited
Loading

Unit Test Results

   162 files  ±0     162 suites  ±0   2m 53s ⏱️ +48s
1 190 tests ±0  1 174 ✔️ ±0  16 💤 ±0  0 ❌ ±0 
2 380 runs  ±0  2 348 ✔️ ±0  32 💤 ±0  0 ❌ ±0 

Results for commit 2f320ba. ± Comparison against base commit c5cd536.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (c5cd536)Merge (c6dfe65)Diff
    aar1.36 MB1.36 MB-10 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QQ8TFJut4n.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilec5cd536c6dfe65DiffSignificant (?)
    p10322 ±9.6 μs315 ±11 μs-6.25 μs (-1.9%)NO
    p25334 ±13 μs327 ±14 μs-7.10 μs (-2.1%)NO
    p50352 ±19 μs354 ±24 μs+1.66 μs (+0.5%)NO
    p75389 ±47 μs447 ±92 μs+58.0 μs (+14.9%)NO
    p90455 ±93 μs556 ±162 μs+100 μs (+22.0%)NO

    20 test runs in comparison
    CommitTest Runs
    c5cd536
    • 2023-07-27_20:47:40.565338_ReOg
    • 2023-07-27_20:47:40.567728_KSHx
    • 2023-07-27_20:47:40.567741_FjFB
    • 2023-07-27_20:47:40.567747_vnIM
    • 2023-07-27_20:47:40.567753_vvhX
    • 2023-07-27_20:47:40.567758_RxXY
    • 2023-07-27_20:47:40.567913_wrFP
    • 2023-07-27_20:47:40.567921_mnxv
    • 2023-07-27_20:47:40.567926_pVjC
    • 2023-07-27_20:47:40.567931_MRRT
    c6dfe65
    • 2023-07-27_23:41:36.070560_xwdZ
    • 2023-07-27_23:41:36.071366_doiH
    • 2023-07-27_23:41:36.071375_WBRw
    • 2023-07-27_23:41:36.071382_voZU
    • 2023-07-27_23:41:36.071388_LhZB
    • 2023-07-27_23:41:36.071394_ETWo
    • 2023-07-27_23:41:36.071400_jCOO
    • 2023-07-27_23:41:36.071406_PFcP
    • 2023-07-27_23:41:36.071412_AFXc
    • 2023-07-27_23:41:36.071417_iwXb
    redfin-30
    Percentilec5cd536c6dfe65DiffSignificant (?)
    p10586 ±16 μs607 ±33 μs+20.6 μs (+3.5%)NO
    p25599 ±19 μs622 ±37 μs+22.7 μs (+3.8%)NO
    p50619 ±22 μs646 ±42 μs+26.8 μs (+4.3%)NO
    p75651 ±31 μs681 ±48 μs+30.5 μs (+4.7%)NO
    p90704 ±77 μs730 ±76 μs+25.7 μs (+3.6%)NO

    20 test runs in comparison
    CommitTest Runs
    c5cd536
    • 2023-07-27_20:47:40.565338_ReOg
    • 2023-07-27_20:47:40.567728_KSHx
    • 2023-07-27_20:47:40.567741_FjFB
    • 2023-07-27_20:47:40.567747_vnIM
    • 2023-07-27_20:47:40.567753_vvhX
    • 2023-07-27_20:47:40.567758_RxXY
    • 2023-07-27_20:47:40.567913_wrFP
    • 2023-07-27_20:47:40.567921_mnxv
    • 2023-07-27_20:47:40.567926_pVjC
    • 2023-07-27_20:47:40.567931_MRRT
    c6dfe65
    • 2023-07-27_23:41:36.070560_xwdZ
    • 2023-07-27_23:41:36.071366_doiH
    • 2023-07-27_23:41:36.071375_WBRw
    • 2023-07-27_23:41:36.071382_voZU
    • 2023-07-27_23:41:36.071388_LhZB
    • 2023-07-27_23:41:36.071394_ETWo
    • 2023-07-27_23:41:36.071400_jCOO
    • 2023-07-27_23:41:36.071406_PFcP
    • 2023-07-27_23:41:36.071412_AFXc
    • 2023-07-27_23:41:36.071417_iwXb

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilec5cd536c6dfe65DiffSignificant (?)
    p10200 ±4 ms204 ±2 ms+4.17 ms (+2.1%)NO
    p25206 ±4 ms210 ±2 ms+3.84 ms (+1.9%)NO
    p50214 ±3 ms219 ±2 ms+5.12 ms (+2.4%)NO
    p75221 ±3 ms229 ±3 ms+7.89 ms (+3.6%)NO
    p90230 ±5 ms241 ±4 ms+11.4 ms (+5.0%)NO

    20 test runs in comparison
    CommitTest Runs
    c5cd536
    • 2023-07-27_20:47:40.565338_ReOg
    • 2023-07-27_20:47:40.567728_KSHx
    • 2023-07-27_20:47:40.567741_FjFB
    • 2023-07-27_20:47:40.567747_vnIM
    • 2023-07-27_20:47:40.567753_vvhX
    • 2023-07-27_20:47:40.567758_RxXY
    • 2023-07-27_20:47:40.567913_wrFP
    • 2023-07-27_20:47:40.567921_mnxv
    • 2023-07-27_20:47:40.567926_pVjC
    • 2023-07-27_20:47:40.567931_MRRT
    c6dfe65
    • 2023-07-27_23:41:36.070560_xwdZ
    • 2023-07-27_23:41:36.071366_doiH
    • 2023-07-27_23:41:36.071375_WBRw
    • 2023-07-27_23:41:36.071382_voZU
    • 2023-07-27_23:41:36.071388_LhZB
    • 2023-07-27_23:41:36.071394_ETWo
    • 2023-07-27_23:41:36.071400_jCOO
    • 2023-07-27_23:41:36.071406_PFcP
    • 2023-07-27_23:41:36.071412_AFXc
    • 2023-07-27_23:41:36.071417_iwXb
    redfin-30
    Percentilec5cd536c6dfe65DiffSignificant (?)
    p10241 ±3 ms266 ±4 ms+24.5 ms (+10.1%)YES
    p25248 ±3 ms272 ±4 ms+24.1 ms (+9.7%)YES
    p50256 ±3 ms279 ±4 ms+23.4 ms (+9.2%)YES
    p75264 ±3 ms288 ±6 ms+24.0 ms (+9.1%)MAYBE
    p90275 ±6 ms302 ±7 ms+26.5 ms (+9.6%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    c5cd536
    • 2023-07-27_20:47:40.565338_ReOg
    • 2023-07-27_20:47:40.567728_KSHx
    • 2023-07-27_20:47:40.567741_FjFB
    • 2023-07-27_20:47:40.567747_vnIM
    • 2023-07-27_20:47:40.567753_vvhX
    • 2023-07-27_20:47:40.567758_RxXY
    • 2023-07-27_20:47:40.567913_wrFP
    • 2023-07-27_20:47:40.567921_mnxv
    • 2023-07-27_20:47:40.567926_pVjC
    • 2023-07-27_20:47:40.567931_MRRT
    c6dfe65
    • 2023-07-27_23:41:36.070560_xwdZ
    • 2023-07-27_23:41:36.071366_doiH
    • 2023-07-27_23:41:36.071375_WBRw
    • 2023-07-27_23:41:36.071382_voZU
    • 2023-07-27_23:41:36.071388_LhZB
    • 2023-07-27_23:41:36.071394_ETWo
    • 2023-07-27_23:41:36.071400_jCOO
    • 2023-07-27_23:41:36.071406_PFcP
    • 2023-07-27_23:41:36.071412_AFXc
    • 2023-07-27_23:41:36.071417_iwXb

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GNdHdV9GR6/index.html

@dconeybe dconeybe changed the title Rename valuable to keep naming convention Rename variable to keep naming convention Jul 28, 2023
@cherylEnkidu cherylEnkidu merged commit 824195e into master Jul 28, 2023
@cherylEnkidu cherylEnkidu deleted the cheryllin/renameFunctionPara branch July 28, 2023 03:17
davidmotson pushed a commit that referenced this pull request Aug 3, 2023
@cherylEnkidu
Rename variable to keep naming convention (#5209)
d93e899 
* Rename valuable to keep naming convention

* improve comment's readability

* change naming
@firebase firebase locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
main-merge-ack no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cherylEnkidu @google-oss-bot @dconeybe @wu-hui