Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive #5219

dconeybe · 2023-08-02T16:22:42Z

No description provided.

github-actions · 2023-08-02T16:22:54Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-08-02T16:31:18Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.63% (6b2a90f) to 44.61% (e2fe3b9) by -0.02%.
Filename Base (6b2a90f) Merge (e2fe3b9) Diff
DeleteMutation.java 90.48% 95.24% +4.76%
LruGarbageCollector.java 97.27% 93.64% -3.64%
PatchMutation.java 100.00% 98.39% -1.61%
SetMutation.java 97.22% 94.44% -2.78%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/KHG6QCWpsW.html

github-actions · 2023-08-02T16:31:51Z

Unit Test Results

  164 files +  110   164 suites +110 2m 15s ⏱️ - 5m 4s
1 202 tests +  732 1 186 ✔️ +  716 16 💤 +16 0 ❌ ±0
2 404 runs +1 464 2 372 ✔️ +1 432 32 💤 +32 0 ❌ ±0

Results for commit a09a614. ± Comparison against base commit 6b2a90f.

This pull request removes 470 and adds 1202 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-08-02T16:39:57Z

Size Report ¹

Affected Products

No changes between base commit (6b2a90f) and merge commit (e2fe3b9).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/vWgjpK7AWw.html

google-oss-bot · 2023-08-02T17:00:55Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (6b2a90f) and the CI merge commit (e2fe3b9)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 6b2a90f: https://storage.googleapis.com/firebase-sdk-metric-reports/QDzMY2Io6q/index.html
- e2fe3b9: https://storage.googleapis.com/firebase-sdk-metric-reports/z1s2XQLnm1/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`6b2a90f`	`e2fe3b9`	Diff	Significant (?)
p10	331 ±14 μs	325 ±20 μs	-5.43 μs (-1.6%)	NO
p25	347 ±15 μs	340 ±29 μs	-6.18 μs (-1.8%)	NO
p50	367 ±16 μs	378 ±68 μs	+10.8 μs (+2.9%)	NO
p75	411 ±47 μs	426 ±118 μs	+15.7 μs (+3.8%)	NO
p90	514 ±117 μs	508 ±193 μs	-5.89 μs (-1.1%)	NO

20 test runs in comparison

Commit	Test Runs
`6b2a90f`	2023-08-01_21:51:53.738172_ruRv 2023-08-01_21:51:53.793592_PeNZ 2023-08-01_21:51:53.793624_txwO 2023-08-01_21:51:53.793638_PhmZ 2023-08-01_21:51:53.793650_dCYi 2023-08-01_21:51:53.793663_vXXJ 2023-08-01_21:51:53.794886_RoDU 2023-08-01_21:51:53.794921_Obxo 2023-08-01_21:51:53.794931_ttEI 2023-08-01_21:51:53.794939_LMYS
`e2fe3b9`	2023-08-03_13:17:07.594329_ohrb 2023-08-03_13:17:07.601086_GuoU 2023-08-03_13:17:07.601105_RaAU 2023-08-03_13:17:07.601117_LQII 2023-08-03_13:17:07.601124_bFAa 2023-08-03_13:17:07.601130_exeN 2023-08-03_13:17:07.601135_CRBe 2023-08-03_13:17:07.601140_ISwR 2023-08-03_13:17:07.601145_mVAO 2023-08-03_13:17:07.601150_QnLJ

redfin-30

Percentile	`6b2a90f`	`e2fe3b9`	Diff	Significant (?)
p10	593 ±27 μs	605 ±39 μs	+12.4 μs (+2.1%)	NO
p25	605 ±30 μs	623 ±47 μs	+18.2 μs (+3.0%)	NO
p50	623 ±35 μs	650 ±59 μs	+27.2 μs (+4.4%)	NO
p75	651 ±39 μs	691 ±82 μs	+39.7 μs (+6.1%)	NO
p90	686 ±51 μs	747 ±120 μs	+60.2 μs (+8.8%)	NO

20 test runs in comparison

Commit	Test Runs
`6b2a90f`	2023-08-01_21:51:53.738172_ruRv 2023-08-01_21:51:53.793592_PeNZ 2023-08-01_21:51:53.793624_txwO 2023-08-01_21:51:53.793638_PhmZ 2023-08-01_21:51:53.793650_dCYi 2023-08-01_21:51:53.793663_vXXJ 2023-08-01_21:51:53.794886_RoDU 2023-08-01_21:51:53.794921_Obxo 2023-08-01_21:51:53.794931_ttEI 2023-08-01_21:51:53.794939_LMYS
`e2fe3b9`	2023-08-03_13:17:07.594329_ohrb 2023-08-03_13:17:07.601086_GuoU 2023-08-03_13:17:07.601105_RaAU 2023-08-03_13:17:07.601117_LQII 2023-08-03_13:17:07.601124_bFAa 2023-08-03_13:17:07.601130_exeN 2023-08-03_13:17:07.601135_CRBe 2023-08-03_13:17:07.601140_ISwR 2023-08-03_13:17:07.601145_mVAO 2023-08-03_13:17:07.601150_QnLJ

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`6b2a90f`	`e2fe3b9`	Diff	Significant (?)
p10	203 ±5 ms	207 ±4 ms	+3.45 ms (+1.7%)	NO
p25	210 ±5 ms	213 ±5 ms	+3.11 ms (+1.5%)	NO
p50	217 ±5 ms	221 ±5 ms	+4.01 ms (+1.9%)	NO
p75	225 ±7 ms	230 ±5 ms	+4.92 ms (+2.2%)	NO
p90	235 ±7 ms	242 ±9 ms	+7.62 ms (+3.2%)	NO

20 test runs in comparison

Commit	Test Runs
`6b2a90f`	2023-08-01_21:51:53.738172_ruRv 2023-08-01_21:51:53.793592_PeNZ 2023-08-01_21:51:53.793624_txwO 2023-08-01_21:51:53.793638_PhmZ 2023-08-01_21:51:53.793650_dCYi 2023-08-01_21:51:53.793663_vXXJ 2023-08-01_21:51:53.794886_RoDU 2023-08-01_21:51:53.794921_Obxo 2023-08-01_21:51:53.794931_ttEI 2023-08-01_21:51:53.794939_LMYS
`e2fe3b9`	2023-08-03_13:17:07.594329_ohrb 2023-08-03_13:17:07.601086_GuoU 2023-08-03_13:17:07.601105_RaAU 2023-08-03_13:17:07.601117_LQII 2023-08-03_13:17:07.601124_bFAa 2023-08-03_13:17:07.601130_exeN 2023-08-03_13:17:07.601135_CRBe 2023-08-03_13:17:07.601140_ISwR 2023-08-03_13:17:07.601145_mVAO 2023-08-03_13:17:07.601150_QnLJ

redfin-30

Percentile	`6b2a90f`	`e2fe3b9`	Diff	Significant (?)
p10	242 ±5 ms	267 ±6 ms	+25.2 ms (+10.4%)	MAYBE
p25	248 ±4 ms	274 ±7 ms	+26.1 ms (+10.5%)	MAYBE
p50	255 ±4 ms	282 ±7 ms	+27.0 ms (+10.6%)	MAYBE
p75	263 ±3 ms	291 ±8 ms	+27.4 ms (+10.4%)	MAYBE
p90	275 ±4 ms	305 ±9.8 ms	+30.3 ms (+11.0%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`6b2a90f`	2023-08-01_21:51:53.738172_ruRv 2023-08-01_21:51:53.793592_PeNZ 2023-08-01_21:51:53.793624_txwO 2023-08-01_21:51:53.793638_PhmZ 2023-08-01_21:51:53.793650_dCYi 2023-08-01_21:51:53.793663_vXXJ 2023-08-01_21:51:53.794886_RoDU 2023-08-01_21:51:53.794921_Obxo 2023-08-01_21:51:53.794931_ttEI 2023-08-01_21:51:53.794939_LMYS
`e2fe3b9`	2023-08-03_13:17:07.594329_ohrb 2023-08-03_13:17:07.601086_GuoU 2023-08-03_13:17:07.601105_RaAU 2023-08-03_13:17:07.601117_LQII 2023-08-03_13:17:07.601124_bFAa 2023-08-03_13:17:07.601130_exeN 2023-08-03_13:17:07.601135_CRBe 2023-08-03_13:17:07.601140_ISwR 2023-08-03_13:17:07.601145_mVAO 2023-08-03_13:17:07.601150_QnLJ

https://storage.googleapis.com/firebase-sdk-metric-reports/0GNZgDgm4E/index.html

… a matches the result

cherylEnkidu

Thank you for your fix!

…IsExpensive (#5219)

Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive

6121e9e

dconeybe added api: firestore no-changelog main-merge-ack labels Aug 2, 2023

dconeybe self-assigned this Aug 2, 2023

google-oss-bot added the do-not-merge/work-in-progress label Aug 2, 2023

google-oss-bot added the size/XS label Aug 2, 2023

SQLiteLocalStoreTest.java: remove an incorrect comment: Only document…

a09a614

… a matches the result

dconeybe marked this pull request as ready for review August 3, 2023 14:14

google-oss-bot removed the do-not-merge/work-in-progress label Aug 3, 2023

dconeybe requested a review from cherylEnkidu August 3, 2023 14:14

cherylEnkidu approved these changes Aug 3, 2023

View reviewed changes

dconeybe merged commit d5b05f2 into master Aug 3, 2023

dconeybe deleted the dconeybe/SQLiteLocalStoreTestCommentFixes branch August 3, 2023 15:32

dconeybe changed the title ~~Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive~~ Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive Aug 3, 2023

davidmotson pushed a commit that referenced this pull request Aug 3, 2023

Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUp…

cb59734

…IsExpensive (#5219)

firebase locked and limited conversation to collaborators Sep 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive #5219

Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive #5219

Uh oh!

dconeybe commented Aug 2, 2023

Uh oh!

github-actions bot commented Aug 2, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Aug 2, 2023 •

edited

Loading

`firebase-firestore`

Uh oh!

github-actions bot commented Aug 2, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Aug 2, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Aug 2, 2023 •

edited

Loading

`fire-fst`

`timeToInitialDisplay`

Uh oh!

cherylEnkidu left a comment

Uh oh!

Uh oh!

Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive #5219

Firestore: Fix comment in testDoesNotAutoCreateIndexesWhenIndexLookUpIsExpensive #5219

Uh oh!

Conversation

dconeybe commented Aug 2, 2023

Uh oh!

github-actions bot commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

Test Logs

Uh oh!

google-oss-bot commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

cherylEnkidu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 2, 2023 •

edited

Loading

google-oss-bot commented Aug 2, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented Aug 2, 2023 •

edited

Loading

google-oss-bot commented Aug 2, 2023 •

edited

Loading

Size Report ¹

google-oss-bot commented Aug 2, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`