Skip to content

refactor the LG check into its own task, minor rewrite for kotlin con… #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2023
Merged

refactor the LG check into its own task, minor rewrite for kotlin con… #5223

merged 5 commits into from
Aug 3, 2023

Conversation

davidmotson
Copy link
Collaborator

…vention

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

buildSrc Test Results

33 tests   33 ✔️  1m 27s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 913e666.

♻️ This comment has been updated with latest results.

@davidmotson davidmotson requested a review from rlazo August 3, 2023 19:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited
Loading

Unit Test Results

   820 files  +   656     820 suites  +656   38m 51s ⏱️ + 36m 37s
4 995 tests +3 793  4 974 ✔️ +3 788  21 💤 +  5  0 ❌ ±0 
9 899 runs  +7 495  9 857 ✔️ +7 485  42 💤 +10  0 ❌ ±0 

Results for commit 913e666. ± Comparison against base commit d5b05f2.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 3, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (d5b05f2) to 50.18% (c20424e) by -0.04%.

    FilenameBase (d5b05f2)Merge (c20424e)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-messaging

    Overall coverage changed from 84.14% (d5b05f2) to 84.33% (c20424e) by +0.19%.

    FilenameBase (d5b05f2)Merge (c20424e)Diff
    Metadata.java36.51%41.27%+4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-firestore

    FilenameBase (d5b05f2)Merge (c20424e)Diff
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6X0TCnZ5wy.html

daymxn
daymxn approved these changes Aug 3, 2023
View reviewed changes
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (d5b05f2) and merge commit (c20424e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/edzxJ1pvuV.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,606 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7vAVew72KH/index.html

@davidmotson davidmotson merged commit 177c51f into master Aug 3, 2023
@davidmotson davidmotson deleted the davidmotson.lg_publish_check branch August 3, 2023 21:50
@firebase firebase locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @rlazo @daymxn