Skip to content

Expose the transport factory as a Qualified dependency #5237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2023
Merged

Expose the transport factory as a Qualified dependency #5237

merged 4 commits into from
Aug 14, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 14, 2023 •
edited
Loading

The datatransport factory was exposed as a single, unqualified component.

Now it's exposed as both the unqualified component, to maintain backwards compatibility, and two qualified components with matching endpoints.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited
Loading

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-datatransport

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 14, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-datatransport

    Overall coverage changed from 100.00% (56d5bb6) to 81.82% (b88ce12) by -18.18%.

    FilenameBase (56d5bb6)Merge (b88ce12)Diff
    LegacyTransportBackend.java?0.00%?
    TransportBackend.java?0.00%?
    TransportRegistrar.java100.00%81.82%-18.18%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yA08ctRTt1.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited
Loading

Unit Test Results

2 files   -    263  2 suites   - 263   14s ⏱️ - 17m 35s
1 tests  - 2 206  1 ✔️  - 2 203  0 💤  - 2  0 ❌  - 1 
2 runs   - 3 452  2 ✔️  - 3 447  0 💤  - 4  0 ❌  - 1 

Results for commit d27fc0c. ± Comparison against base commit 56d5bb6.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (56d5bb6)Merge (b88ce12)Diff
    aar5.00 kB5.83 kB+822 B (+16.4%)
    apk (aggressive)161 kB162 kB+224 B (+0.1%)
    apk (release)1.35 MB1.35 MB+176 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uWgkFeysJR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 14, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-transport

    DeviceStatisticsDistributions
    oriole-32
    Percentile56d5bb6b88ce12DiffSignificant (?)
    p101.16 ±0.6 ms1.04 ±0.4 ms-124 μs (-10.6%)NO
    p251.20 ±0.6 ms1.07 ±0.5 ms-130 μs (-10.8%)NO
    p501.27 ±0.7 ms1.18 ±0.5 ms-87.8 μs (-6.9%)NO
    p751.45 ±0.8 ms1.46 ±0.6 ms+10.1 μs (+0.7%)NO
    p901.80 ±0.9 ms1.70 ±0.7 ms-96.4 μs (-5.4%)NO

    20 test runs in comparison
    CommitTest Runs
    56d5bb6
    • 2023-08-11_13:27:21.673193_UhzX
    • 2023-08-11_13:27:21.676977_gHkn
    • 2023-08-11_13:27:21.676996_qghJ
    • 2023-08-11_13:27:21.677009_GQlN
    • 2023-08-11_13:27:21.677016_EPvK
    • 2023-08-11_13:27:21.677024_mICt
    • 2023-08-11_13:27:21.677030_giuj
    • 2023-08-11_13:27:21.677036_eBAy
    • 2023-08-11_13:27:21.677042_aaek
    • 2023-08-11_13:27:21.677048_uiXQ
    b88ce12
    • 2023-08-14_18:09:45.706309_VwEa
    • 2023-08-14_18:09:45.711369_pfZF
    • 2023-08-14_18:09:45.711393_XqmE
    • 2023-08-14_18:09:45.711403_fDpC
    • 2023-08-14_18:09:45.711411_ccww
    • 2023-08-14_18:09:45.711751_xdzA
    • 2023-08-14_18:09:45.711776_kEFU
    • 2023-08-14_18:09:45.711785_PkXI
    • 2023-08-14_18:09:45.711793_IrXW
    • 2023-08-14_18:09:45.711802_XSSh
    redfin-30
    Percentile56d5bb6b88ce12DiffSignificant (?)
    p102.54 ±2 ms4.05 ±2 ms+1.52 ms (+59.7%)NO
    p252.83 ±2 ms4.42 ±2 ms+1.60 ms (+56.5%)NO
    p503.15 ±3 ms4.97 ±2 ms+1.82 ms (+57.9%)NO
    p753.66 ±3 ms5.78 ±3 ms+2.12 ms (+57.8%)NO
    p904.65 ±4 ms7.39 ±3 ms+2.74 ms (+58.9%)NO

    20 test runs in comparison
    CommitTest Runs
    56d5bb6
    • 2023-08-11_13:27:21.673193_UhzX
    • 2023-08-11_13:27:21.676977_gHkn
    • 2023-08-11_13:27:21.676996_qghJ
    • 2023-08-11_13:27:21.677009_GQlN
    • 2023-08-11_13:27:21.677016_EPvK
    • 2023-08-11_13:27:21.677024_mICt
    • 2023-08-11_13:27:21.677030_giuj
    • 2023-08-11_13:27:21.677036_eBAy
    • 2023-08-11_13:27:21.677042_aaek
    • 2023-08-11_13:27:21.677048_uiXQ
    b88ce12
    • 2023-08-14_18:09:45.706309_VwEa
    • 2023-08-14_18:09:45.711369_pfZF
    • 2023-08-14_18:09:45.711393_XqmE
    • 2023-08-14_18:09:45.711403_fDpC
    • 2023-08-14_18:09:45.711411_ccww
    • 2023-08-14_18:09:45.711751_xdzA
    • 2023-08-14_18:09:45.711776_kEFU
    • 2023-08-14_18:09:45.711785_PkXI
    • 2023-08-14_18:09:45.711793_IrXW
    • 2023-08-14_18:09:45.711802_XSSh

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile56d5bb6b88ce12DiffSignificant (?)
    p10201 ±4 ms204 ±4 ms+2.96 ms (+1.5%)NO
    p25207 ±4 ms210 ±5 ms+2.70 ms (+1.3%)NO
    p50214 ±5 ms218 ±5 ms+3.85 ms (+1.8%)NO
    p75221 ±6 ms226 ±5 ms+4.97 ms (+2.2%)NO
    p90230 ±6 ms240 ±8 ms+10.6 ms (+4.6%)NO

    20 test runs in comparison
    CommitTest Runs
    56d5bb6
    • 2023-08-11_13:27:21.673193_UhzX
    • 2023-08-11_13:27:21.676977_gHkn
    • 2023-08-11_13:27:21.676996_qghJ
    • 2023-08-11_13:27:21.677009_GQlN
    • 2023-08-11_13:27:21.677016_EPvK
    • 2023-08-11_13:27:21.677024_mICt
    • 2023-08-11_13:27:21.677030_giuj
    • 2023-08-11_13:27:21.677036_eBAy
    • 2023-08-11_13:27:21.677042_aaek
    • 2023-08-11_13:27:21.677048_uiXQ
    b88ce12
    • 2023-08-14_18:09:45.706309_VwEa
    • 2023-08-14_18:09:45.711369_pfZF
    • 2023-08-14_18:09:45.711393_XqmE
    • 2023-08-14_18:09:45.711403_fDpC
    • 2023-08-14_18:09:45.711411_ccww
    • 2023-08-14_18:09:45.711751_xdzA
    • 2023-08-14_18:09:45.711776_kEFU
    • 2023-08-14_18:09:45.711785_PkXI
    • 2023-08-14_18:09:45.711793_IrXW
    • 2023-08-14_18:09:45.711802_XSSh
    redfin-30
    Percentile56d5bb6b88ce12DiffSignificant (?)
    p10243 ±5 ms264 ±3 ms+20.5 ms (+8.5%)MAYBE
    p25249 ±5 ms269 ±2 ms+19.8 ms (+7.9%)MAYBE
    p50258 ±5 ms277 ±3 ms+19.6 ms (+7.6%)MAYBE
    p75265 ±5 ms287 ±3 ms+22.0 ms (+8.3%)MAYBE
    p90276 ±7 ms301 ±6 ms+24.7 ms (+8.9%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    56d5bb6
    • 2023-08-11_13:27:21.673193_UhzX
    • 2023-08-11_13:27:21.676977_gHkn
    • 2023-08-11_13:27:21.676996_qghJ
    • 2023-08-11_13:27:21.677009_GQlN
    • 2023-08-11_13:27:21.677016_EPvK
    • 2023-08-11_13:27:21.677024_mICt
    • 2023-08-11_13:27:21.677030_giuj
    • 2023-08-11_13:27:21.677036_eBAy
    • 2023-08-11_13:27:21.677042_aaek
    • 2023-08-11_13:27:21.677048_uiXQ
    b88ce12
    • 2023-08-14_18:09:45.706309_VwEa
    • 2023-08-14_18:09:45.711369_pfZF
    • 2023-08-14_18:09:45.711393_XqmE
    • 2023-08-14_18:09:45.711403_fDpC
    • 2023-08-14_18:09:45.711411_ccww
    • 2023-08-14_18:09:45.711751_xdzA
    • 2023-08-14_18:09:45.711776_kEFU
    • 2023-08-14_18:09:45.711785_PkXI
    • 2023-08-14_18:09:45.711793_IrXW
    • 2023-08-14_18:09:45.711802_XSSh

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/W8f2oSQ1xY/index.html

emilypgoogle
emilypgoogle reviewed Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@emilypgoogle emilypgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, curious about the versioning situation

@rlazo rlazo merged commit da631d2 into master Aug 14, 2023
@rlazo rlazo deleted the rl.transport.qualified branch August 14, 2023 18:04
limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
@rlazo @limsaehyun
Expose the transport factory as a Qualified component (firebase#5237)
b0a4563 
* Expose the transport factory as a Qualified dependency.

* Add CHANGELOG entry

* Fix version bump.
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle