Skip to content

Minor version bump firebase-datatransport since new classes are added #5246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

Minor version bump firebase-datatransport since new classes are added #5246

merged 1 commit into from
Aug 15, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 15, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo enabled auto-merge (squash) August 15, 2023 18:16
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-datatransport

    Overall coverage changed from ? (8671998) to 81.82% (344746e) by ?.

    FilenameBase (8671998)Merge (344746e)Diff
    LegacyTransportBackend.java?0.00%?
    TransportBackend.java?0.00%?
    TransportRegistrar.java?81.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PdyRDHndHm.html

@github-actions
Copy link
Contributor

Unit Test Results

2 files   -    100  2 suites   - 100   15s ⏱️ - 2m 47s
1 tests  -    970  1 ✔️  -    969  0 💤 ±0  0 ❌  - 1 
2 runs   - 1 940  2 ✔️  - 1 939  0 💤 ±0  0 ❌  - 1 

Results for commit 47c813c. ± Comparison against base commit 8671998.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (8671998)Merge (344746e)Diff
    apk (aggressive)163 kB163 kB+4 B (+0.0%)
    apk (release)1.35 MB1.35 MB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EoNEDVueCz.html

@rlazo rlazo disabled auto-merge August 15, 2023 18:39
@rlazo rlazo merged commit 339cb42 into master Aug 15, 2023
@rlazo rlazo deleted the rl.datatransport.ver branch August 15, 2023 18:39
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (344746e) and the base commit (8671998) are not available.

No macrobenchmark data found for the base commit (8671998). Analysis for the CI merge commit (344746e) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qwcBwVYNP5/index.html

limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
@rlazo @limsaehyun
Minor version bump firebase-datatransport since new classes are added (…
2c7d8b1 
…firebase#5246)
@firebase firebase locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle