Persist the aqs session id on new aqs session #5274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-crashlytics### {{crashlytics}} version 18.4.2 {: #crashlytics_v18-4-2}
* {{feature}} Include Firebase sessions with NDK crashes and ANRs.
#### {{crashlytics}} Kotlin extensions version 18.4.2 {: #crashlytics-ktx_v18-4-2}
The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
themiswang
reviewed
Aug 24, 2023
...shlytics/src/main/java/com/google/firebase/crashlytics/internal/model/CrashlyticsReport.java
Show resolved
Hide resolved
themiswang
reviewed
Aug 24, 2023
...java/com/google/firebase/crashlytics/internal/common/CrashlyticsAppQualitySessionsStore.java
Outdated
Show resolved
Hide resolved
themiswang
reviewed
Aug 24, 2023
firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/FirebaseCrashlytics.java
Outdated
Show resolved
Hide resolved
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (dd14f14) and the base commit (dff55b6) are not available. No macrobenchmark data found for the base commit (dff55b6). Analysis for the CI merge commit (dd14f14) can be found at: |
themiswang
approved these changes
Aug 25, 2023
kmandrika
approved these changes
Aug 28, 2023
# Conflicts: # firebase-crashlytics/CHANGELOG.md
limsaehyun
pushed a commit
to limsaehyun/firebase-android-sdk
that referenced
this pull request
Sep 5, 2023
Persist the aqs session id on new aqs session, instead of on event. This is needed for ANRs and native crashes that can't persist on event. This also populates the aqs session id and fid in the Report. The new `CrashlyticsAppQualitySessionsStore` class is based on the existing `MetaDataStore` class but with the current session id not being final.
daymxn
added a commit
that referenced
this pull request
Sep 7, 2023
Per [b/299509129](https://b.corp.google.com/issues/299509129), This adds a changelog entry to `firebase-crashlytics-ndk` that should've been added with #5274, as `firebase-crashlytics` is in the same library group.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the aqs session id on new aqs session, instead of on event. This is needed for ANRs and native crashes that can't persist on event.
This also populates the aqs session id and fid in the Report.
The new
CrashlyticsAppQualitySessionsStoreclass is based on the existingMetaDataStoreclass but with the current session id not being final.