Skip to content

Fix Changelog Error #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix Changelog Error #5293

merged 1 commit into from
Sep 4, 2023

Conversation

cherylEnkidu
Copy link
Contributor

During auto rebase, the change log entry of auto creation cache index was put inside the previous release cycle by mistake.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-firestore
### {{firestore}} version 24.7.2 {: #firestore_v24-7-2}

* {{feature}} Add option to allow SDK create cache indexes automatically to improve query execution locally. [`db.getPersistentCacheIndexManager().enableIndexAutoCreation()`](//github.com/firebase/firebase-android-sdk/pull/4987)

#### {{firestore}} Kotlin extensions version 24.7.2 {: #firestore-ktx_v24-7-2}

The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    FilenameBase (f5e39ce)Merge (6d0bb9c)Diff
    DeleteMutation.java95.24%90.48%-4.76%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ijxsFGsW4M.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Unit Test Results

   164 files   -    639     164 suites   - 639   2m 35s ⏱️ - 35m 7s
1 205 tests  - 3 800  1 189 ✔️  - 3 794  16 💤  -   5  0  - 1 
2 410 runs   - 7 321  2 378 ✔️  - 7 310  32 💤  - 10  0  - 1 

Results for commit 9633b0d. ± Comparison against base commit f5e39ce.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has happened to me on more than one occasion too!

@cherylEnkidu cherylEnkidu merged commit 66041ec into master Sep 4, 2023
@cherylEnkidu cherylEnkidu deleted the cheryllin/fixchangelog branch September 4, 2023 01:55
limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
During auto rebase, the change log entry of auto creation cache index
was put inside the previous release cycle by mistake.
@firebase firebase locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants