Skip to content

Don't use recursion in TrimmedThrowableData to avoid stack overflow #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Sep 8, 2023

Don't use recursion in TrimmedThrowableData. This fixes an issue when exceptions with long caused by chains cause a stack overflow.

Pair with PolinaGo

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@mrober
Copy link
Contributor Author

mrober commented Sep 8, 2023

#5102

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 9.71% (c3b8210) to 9.69% (ed9e578) by -0.02%.

    FilenameBase (c3b8210)Merge (ed9e578)Diff
    CrashlyticsReportDataCapture.java3.46%3.45%-0.01%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Isz2mtof8P.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Unit Test Results

  6 files  +  6    6 suites  +6   17s ⏱️ +17s
18 tests +18  18 ✔️ +18  0 💤 ±0  0 ±0 
36 runs  +36  36 ✔️ +36  0 💤 ±0  0 ±0 

Results for commit 25e9e15. ± Comparison against base commit c3b8210.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (c3b8210)Merge (ed9e578)Diff
    aar359 kB359 kB+381 B (+0.1%)
    apk (aggressive)433 kB433 kB+84 B (+0.0%)
    apk (release)2.17 MB2.17 MB-220 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AS29gyBZNM.html

@mrober mrober merged commit 785f669 into master Sep 11, 2023
@mrober mrober deleted the crashlytics-stackoverflow branch September 11, 2023 13:56
@aloysiusralph
Copy link

@mrober Thanks for addressing this. Any idea when this will be released?

@firebase firebase locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants