firebase-perf: Add custom method to set final static method for test #5312
Conversation
Robolectric's ReflectionHelpers removes supporting of setting fnial static method becasuse it not the reposibility of Robolectric, and it will not be allowed by the latest JDK. This CL just adds custom method to do the same things as a workaround. When the project updates the JDK someday, the maintainer needs to rewrite the test or provides some test helper method to avoid set final static method for test. Signed-off-by: utzcoz <[email protected]>
|
Prepare for #5149. |
|
@rlazo This is another preparation PR for Robolectric 4.10.3 as it removes the supporting of set final static field from Also I found |
Yes, I double check locally using your branch and it's passing. When ready, feel free to assign me as reviewer of this PR. Thanks! |
|
@rlazo Thanks for testing. I think this PR is ready for reviewing now. Unfortunately, I don't have permission to assign a reviewer, and the GitHub doesn't show any recommendation people to us in the PR page. It might need your help to assign. Thanks. |
|
@visumickey could you take a look at this change? Thanks! |
|
Thanks a lot for your contribution @utzcoz ! |
utzcoz
deleted the
migrate-Robolectric-ReflectoinHelpers-setStaticField
branch
|
@rlazo Thanks for your reviewing. |
|
Sorry for being late here. The changes look good to me. |
Robolectric's ReflectionHelpers removes supporting of setting fnial static method becasuse it not the reposibility of Robolectric, and it will not be allowed by the latest JDK. This CL just adds custom method to do the same things as a workaround. When the project updates the JDK someday, the maintainer needs to rewrite the test or provides some test helper method to avoid set final static method for test.