Skip to content

Use constants for library group task name #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Use constants for library group task name #5329

merged 4 commits into from
Sep 18, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 14, 2023

Addressess pending comments from PR #5297

Addressess pending comments from PR #5297
@rlazo rlazo requested a review from daymxn September 14, 2023 12:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Unit Test Results

   820 files  +   718     820 suites  +718   39m 58s ⏱️ + 37m 1s
5 008 tests +4 037  4 987 ✔️ +4 016  21 💤 +21  0 ±0 
9 925 runs  +7 983  9 883 ✔️ +7 941  42 💤 +42  0 ±0 

Results for commit c112de6. ± Comparison against base commit f00c02f.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.13% (f00c02f) to 50.20% (3aeda50) by +0.07%.

    FilenameBase (f00c02f)Merge (3aeda50)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java100.00%88.24%-11.76%
    WebsocketConnection.java32.77%35.03%+2.26%
  • firebase-firestore

    Overall coverage changed from 44.62% (f00c02f) to 44.62% (3aeda50) by +0.00%.

    FilenameBase (f00c02f)Merge (3aeda50)Diff
    PatchMutation.java98.39%100.00%+1.61%
  • firebase-installations

    Overall coverage changed from ? (f00c02f) to 58.61% (3aeda50) by ?.

    22 individual files with coverage change

    FilenameBase (f00c02f)Merge (3aeda50)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.18% (f00c02f) to 84.33% (3aeda50) by +0.15%.

    FilenameBase (f00c02f)Merge (3aeda50)Diff
    FirebaseMessaging.java73.13%73.57%+0.44%
    MessagingAnalytics.java81.38%81.78%+0.40%
    RequestDeduplicator.java80.00%90.00%+10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nXnahk53zW.html

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also need to update it at the call site, but I can't comment on that in this PR since it wasn't changed.

@github-actions
Copy link
Contributor

buildSrc Test Results

36 tests   36 ✔️  1m 35s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit c112de6.

@rlazo rlazo requested a review from daymxn September 18, 2023 16:30
@rlazo rlazo merged commit e4c2368 into master Sep 18, 2023
@rlazo rlazo deleted the rl.address.5297 branch September 18, 2023 16:56
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,605 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/632ZTjFtci/index.html

@firebase firebase locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants