Skip to content

Add deep transitive projects to release #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 19, 2023
Merged

Add deep transitive projects to release #5331

merged 8 commits into from
Sep 19, 2023

Conversation

davidmotson
Copy link
Collaborator

@davidmotson davidmotson commented Sep 14, 2023 •
edited
Loading

No description provided.

Added the ability to get all project level deps for a FirebaseLibrary…
3b27141 
…Extension and a deep transitive release finder
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (d4a56bb) to 50.18% (94c63e7) by -0.04%.

    FilenameBase (d4a56bb)Merge (94c63e7)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%

  • firebase-messaging

    Overall coverage changed from 84.21% (d4a56bb) to 84.18% (94c63e7) by -0.04%.

    FilenameBase (d4a56bb)Merge (94c63e7)Diff
    FirebaseMessaging.java73.57%73.13%-0.44%
    MessagingAnalytics.java81.38%81.78%+0.40%
    Metadata.java41.27%36.51%-4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-perf

    Overall coverage changed from ? (d4a56bb) to 71.18% (94c63e7) by ?.

    103 individual files with coverage change

    FilenameBase (d4a56bb)Merge (94c63e7)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?93.49%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?86.36%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?28.57%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from 85.73% (d4a56bb) to 85.81% (94c63e7) by +0.09%.

    FilenameBase (d4a56bb)Merge (94c63e7)Diff
    StorageTask.java83.38%83.69%+0.30%
    UploadTask.java81.52%81.85%+0.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AHnodU9af6.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

Unit Test Results

   820 files  +   570     820 suites  +570   38m 29s ⏱️ + 32m 18s
5 008 tests +3 351  4 987 ✔️ +3 347  21 💤 +4  0 ❌ ±0 
9 925 runs  +6 611  9 883 ✔️ +6 603  42 💤 +8  0 ❌ ±0 

Results for commit 9a15c5f. ± Comparison against base commit d4a56bb.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 14, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (d4a56bb) and merge commit (94c63e7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4nyMSpdVuf.html

daymxn
daymxn reviewed Sep 14, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited
Loading

buildSrc Test Results

37 tests   37 ✔️  1m 35s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit 9a15c5f.

♻️ This comment has been updated with latest results.

@davidmotson davidmotson requested a review from rlazo September 14, 2023 21:17
@davidmotson davidmotson changed the title Added the ability to get all project level deps for a FirebaseLibrary… Add deep transitive projects to release Sep 14, 2023
daymxn
daymxn approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could we add a test for it?

@davidmotson
Copy link
Collaborator Author

The test that's edited captures the case this is meant to fix, if a library is pulled in without its project dependencies, those get added to the release anyway.

I could add a test case with LGs and project deps if you think that'd be valuable

@daymxn
Copy link
Member

daymxn commented Sep 18, 2023

The test that's edited captures the case this is meant to fix, if a library is pulled in without its project dependencies, those get added to the release anyway.

I could add a test case with LGs and project deps if you think that'd be valuable

I think it would be actually. We could always use more tests for our publishing pipeline.

@davidmotson
Copy link
Collaborator Author

Done!

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,608 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MPu98dYxMy/index.html

@davidmotson davidmotson enabled auto-merge (squash) September 19, 2023 17:25
@davidmotson davidmotson merged commit d08e208 into master Sep 19, 2023
@davidmotson davidmotson deleted the davidmotson.project_dep_release branch September 19, 2023 17:55
@firebase firebase locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @daymxn @rlazo