Skip to content

m137_1 mergeback #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

m137_1 mergeback #5342

merged 2 commits into from
Sep 18, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Sep 15, 2023

Per b/300682723,

This does all the post release clean up tasks for m137_1 (the hotfix that just went out).

NO_RELEASE_CHANGE

@daymxn daymxn requested review from rlazo and davidmotson September 15, 2023 21:04
@daymxn daymxn self-assigned this Sep 15, 2023
@daymxn daymxn enabled auto-merge (squash) September 15, 2023 21:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-components
firebase-crashlytics-ndk
firebase-crashlytics
firebase-firestore
firebase-inappmessaging-display
firebase-inappmessaging

@github-actions
Copy link
Contributor

Unit Test Results

   250 files   -    556     250 suites   - 556   5m 14s ⏱️ - 30m 48s
1 657 tests  - 3 351  1 640 ✔️  - 3 345  17 💤  - 4  0  - 2 
3 314 runs   - 6 499  3 280 ✔️  - 6 489  34 💤  - 8  0  - 2 

Results for commit 67b120d. ± Comparison against base commit 43eec0e.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

Coverage Report 1

This report is too large (76,822 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YSNVBWOd3u.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

Size Report 1

Affected Products

  • base

    TypeBase (e4c2368)Merge (13fed1b)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)
  • firebase-components

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?45.5 kB? (?)
    apk (aggressive)?23.3 kB? (?)
    apk (release)?596 kB? (?)
  • firebase-crashlytics

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?359 kB? (?)
    apk (aggressive)?433 kB? (?)
    apk (release)?2.17 MB? (?)
  • firebase-crashlytics-ndk

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?1.66 MB? (?)
    apk (aggressive / arm64-v8a)?1.60 MB? (?)
    apk (aggressive / armeabi-v7a)?1.08 MB? (?)
    apk (aggressive / x86)?1.58 MB? (?)
    apk (aggressive / x86_64)?1.64 MB? (?)
    apk (release / arm64-v8a)?3.34 MB? (?)
    apk (release / armeabi-v7a)?2.81 MB? (?)
    apk (release / x86)?3.32 MB? (?)
    apk (release / x86_64)?3.38 MB? (?)
  • firebase-firestore

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?1.36 MB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?3.95 MB? (?)
  • firebase-inappmessaging

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?458 kB? (?)
    apk (aggressive)?701 kB? (?)
    apk (release)?3.96 MB? (?)
  • firebase-inappmessaging-display

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?182 kB? (?)
    apk (aggressive)?1.53 MB? (?)
    apk (release)?5.22 MB? (?)
  • protolite-well-known-types

    TypeBase (e4c2368)Merge (13fed1b)Diff
    aar?1.00e+03 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?666 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LSwhefYeXz.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (13fed1b) and the base commit (e4c2368) are not available.

No macrobenchmark data found for the base commit (e4c2368). Analysis for the CI merge commit (13fed1b) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CQWsxptQA5/index.html

@davidmotson
Copy link
Collaborator

NO_RELEASE_CHANGE needs to go in the body of the resulting commit to master, the best way to guarantee that (so you don't have to remember to do it when you merge) is to put it in the title of this PR, or one of the pushes that are part of this PR

@daymxn
Copy link
Member Author

daymxn commented Sep 18, 2023

NO_RELEASE_CHANGE

It's in the description, and our current squash merge is commit title + description.

@rlazo
Copy link
Collaborator

rlazo commented Sep 18, 2023

QQ, why aren't latestReleasedVersions fields being updated?

@daymxn daymxn merged commit d4a56bb into master Sep 18, 2023
@daymxn daymxn deleted the releases/m137_1.mergeback branch September 18, 2023 17:10
@daymxn daymxn restored the releases/m137_1.mergeback branch September 19, 2023 18:58
@firebase firebase locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants