Skip to content

MIEQ: add negative test cases #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 12, 2023
Merged

MIEQ: add negative test cases #5383

merged 5 commits into from
Oct 12, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 6, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.75% (a135c51) to 44.74% (04a4016) by -0.01%.

    FilenameBase (a135c51)Merge (04a4016)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java97.27%93.64%-3.64%
    PatchMutation.java98.39%100.00%+1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ef7TasMN43.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Unit Test Results

   180 files   -    739     180 suites   - 739   2m 19s ⏱️ - 37m 5s
1 220 tests  - 3 876  1 204 ✔️  - 3 869  16 💤  -   5  0  - 2 
2 464 runs   - 7 625  2 432 ✔️  - 7 613  32 💤  - 10  0  - 2 

Results for commit 36e971c. ± Comparison against base commit a135c51.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 6, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 6, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilea135c5104a4016DiffSignificant (?)
    p10328 ±29 μs318 ±13 μs-10.4 μs (-3.2%)NO
    p25337 ±33 μs332 ±20 μs-5.35 μs (-1.6%)NO
    p50361 ±60 μs359 ±34 μs-1.91 μs (-0.5%)NO
    p75402 ±98 μs423 ±87 μs+21.0 μs (+5.2%)NO
    p90473 ±173 μs526 ±165 μs+52.3 μs (+11.1%)NO

    20 test runs in comparison
    CommitTest Runs
    a135c51
    • 2023-10-10_23:19:25.263837_iAuc
    • 2023-10-10_23:19:25.266234_uFUV
    • 2023-10-10_23:19:25.266258_sDFC
    • 2023-10-10_23:19:25.266265_DNJP
    • 2023-10-10_23:19:25.266271_JuUV
    • 2023-10-10_23:19:25.266276_YCnN
    • 2023-10-10_23:19:25.266282_ySZN
    • 2023-10-10_23:19:25.266288_pylL
    • 2023-10-10_23:19:25.266297_BEKz
    • 2023-10-10_23:19:25.266303_xawA
    04a4016
    • 2023-10-11_13:56:20.355643_reFT
    • 2023-10-11_13:56:20.358861_tYMu
    • 2023-10-11_13:56:20.358874_ERoN
    • 2023-10-11_13:56:20.358880_XKDe
    • 2023-10-11_13:56:20.358886_SNdZ
    • 2023-10-11_13:56:20.358892_kGcJ
    • 2023-10-11_13:56:20.358898_EoGB
    • 2023-10-11_13:56:20.358903_IJhT
    • 2023-10-11_13:56:20.358909_AubS
    • 2023-10-11_13:56:20.358914_ZLXA
    redfin-30
    Percentilea135c5104a4016DiffSignificant (?)
    p10585 ±26 μs602 ±29 μs+16.3 μs (+2.8%)NO
    p25598 ±29 μs619 ±37 μs+20.7 μs (+3.5%)NO
    p50621 ±35 μs648 ±45 μs+27.7 μs (+4.5%)NO
    p75654 ±48 μs686 ±53 μs+32.1 μs (+4.9%)NO
    p90698 ±72 μs748 ±86 μs+49.8 μs (+7.1%)NO

    20 test runs in comparison
    CommitTest Runs
    a135c51
    • 2023-10-10_23:19:25.263837_iAuc
    • 2023-10-10_23:19:25.266234_uFUV
    • 2023-10-10_23:19:25.266258_sDFC
    • 2023-10-10_23:19:25.266265_DNJP
    • 2023-10-10_23:19:25.266271_JuUV
    • 2023-10-10_23:19:25.266276_YCnN
    • 2023-10-10_23:19:25.266282_ySZN
    • 2023-10-10_23:19:25.266288_pylL
    • 2023-10-10_23:19:25.266297_BEKz
    • 2023-10-10_23:19:25.266303_xawA
    04a4016
    • 2023-10-11_13:56:20.355643_reFT
    • 2023-10-11_13:56:20.358861_tYMu
    • 2023-10-11_13:56:20.358874_ERoN
    • 2023-10-11_13:56:20.358880_XKDe
    • 2023-10-11_13:56:20.358886_SNdZ
    • 2023-10-11_13:56:20.358892_kGcJ
    • 2023-10-11_13:56:20.358898_EoGB
    • 2023-10-11_13:56:20.358903_IJhT
    • 2023-10-11_13:56:20.358909_AubS
    • 2023-10-11_13:56:20.358914_ZLXA
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilea135c5104a4016DiffSignificant (?)
    p10201 ±7 ms205 ±2 ms+4.28 ms (+2.1%)NO
    p25207 ±6 ms211 ±2 ms+4.43 ms (+2.1%)NO
    p50214 ±6 ms219 ±2 ms+4.53 ms (+2.1%)NO
    p75222 ±6 ms228 ±3 ms+5.71 ms (+2.6%)NO
    p90230 ±6 ms242 ±8 ms+12.1 ms (+5.3%)NO

    20 test runs in comparison
    CommitTest Runs
    a135c51
    • 2023-10-10_23:19:25.263837_iAuc
    • 2023-10-10_23:19:25.266234_uFUV
    • 2023-10-10_23:19:25.266258_sDFC
    • 2023-10-10_23:19:25.266265_DNJP
    • 2023-10-10_23:19:25.266271_JuUV
    • 2023-10-10_23:19:25.266276_YCnN
    • 2023-10-10_23:19:25.266282_ySZN
    • 2023-10-10_23:19:25.266288_pylL
    • 2023-10-10_23:19:25.266297_BEKz
    • 2023-10-10_23:19:25.266303_xawA
    04a4016
    • 2023-10-11_13:56:20.355643_reFT
    • 2023-10-11_13:56:20.358861_tYMu
    • 2023-10-11_13:56:20.358874_ERoN
    • 2023-10-11_13:56:20.358880_XKDe
    • 2023-10-11_13:56:20.358886_SNdZ
    • 2023-10-11_13:56:20.358892_kGcJ
    • 2023-10-11_13:56:20.358898_EoGB
    • 2023-10-11_13:56:20.358903_IJhT
    • 2023-10-11_13:56:20.358909_AubS
    • 2023-10-11_13:56:20.358914_ZLXA
    redfin-30
    Percentilea135c5104a4016DiffSignificant (?)
    p10244 ±5 ms268 ±3 ms+23.8 ms (+9.7%)YES
    p25250 ±5 ms275 ±4 ms+24.9 ms (+9.9%)YES
    p50257 ±5 ms283 ±5 ms+26.2 ms (+10.2%)MAYBE
    p75267 ±8 ms296 ±5 ms+28.7 ms (+10.7%)MAYBE
    p90279 ±12 ms317 ±13 ms+38.5 ms (+13.8%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    a135c51
    • 2023-10-10_23:19:25.263837_iAuc
    • 2023-10-10_23:19:25.266234_uFUV
    • 2023-10-10_23:19:25.266258_sDFC
    • 2023-10-10_23:19:25.266265_DNJP
    • 2023-10-10_23:19:25.266271_JuUV
    • 2023-10-10_23:19:25.266276_YCnN
    • 2023-10-10_23:19:25.266282_ySZN
    • 2023-10-10_23:19:25.266288_pylL
    • 2023-10-10_23:19:25.266297_BEKz
    • 2023-10-10_23:19:25.266303_xawA
    04a4016
    • 2023-10-11_13:56:20.355643_reFT
    • 2023-10-11_13:56:20.358861_tYMu
    • 2023-10-11_13:56:20.358874_ERoN
    • 2023-10-11_13:56:20.358880_XKDe
    • 2023-10-11_13:56:20.358886_SNdZ
    • 2023-10-11_13:56:20.358892_kGcJ
    • 2023-10-11_13:56:20.358898_EoGB
    • 2023-10-11_13:56:20.358903_IJhT
    • 2023-10-11_13:56:20.358909_AubS
    • 2023-10-11_13:56:20.358914_ZLXA

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pVRJCsaJrV/index.html

@milaGGL milaGGL requested a review from ehsannas October 6, 2023 17:33
@milaGGL milaGGL self-assigned this Oct 10, 2023
@milaGGL milaGGL merged commit 5241ce7 into master Oct 12, 2023
@milaGGL milaGGL deleted the mila/MIEQ-negative-test-cases branch October 12, 2023 15:09
@firebase firebase locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants