Skip to content

Update common version #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Update common version #5390

merged 6 commits into from
Oct 10, 2023

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-common:
error: Added method com.google.firebase.ktx.FirebaseKt.getX() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Unit Test Results

   883 files  +   747     883 suites  +747   39m 13s ⏱️ + 35m 20s
5 096 tests +4 052  5 074 ✔️ +4 030  21 💤 +21  1 +1 
9 302 runs  +7 214  9 259 ✔️ +7 171  42 💤 +42  1 +1 

For more details on these failures, see this check.

Results for commit 9cfd9c0. ± Comparison against base commit a53ab64.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 10, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (a53ab64) to 50.13% (43e6e00) by -0.04%.

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.74% (a53ab64) to 44.75% (43e6e00) by +0.01%.

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
    PatchMutation.java100.00%98.39%-1.61%
  • firebase-installations

    Overall coverage changed from ? (a53ab64) to 58.68% (43e6e00) by ?.

    23 individual files with coverage change

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 83.84% (a53ab64) to 83.91% (43e6e00) by +0.08%.

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    MessagingAnalytics.java81.78%81.38%-0.40%
    Metadata.java36.51%41.27%+4.76%
  • firebase-perf

    Overall coverage changed from ? (a53ab64) to 70.95% (43e6e00) by ?.

    104 individual files with coverage change

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?93.49%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?86.36%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?28.57%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    Performance.kt?7.14%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from 84.21% (a53ab64) to 84.29% (43e6e00) by +0.08%.

    FilenameBase (a53ab64)Merge (43e6e00)Diff
    NetworkRequest.java87.85%87.29%-0.55%
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    StreamDownloadTask.java88.89%88.41%-0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b5bZgYTs6l.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.94 MB1.94 MB-48 B (-0.0%)
  • firebase-appcheck-debug

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)372 kB372 kB+4 B (+0.0%)
    apk (release)1.95 MB1.95 MB-28 B (-0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)390 kB390 kB+4 B (+0.0%)
    apk (release)2.02 MB2.02 MB+108 B (+0.0%)
  • firebase-appcheck-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.94 MB1.94 MB-48 B (-0.0%)
  • firebase-appcheck-playintegrity

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)374 kB374 kB+4 B (+0.0%)
    apk (release)1.96 MB1.96 MB-104 B (-0.0%)
  • firebase-appcheck-safetynet

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)373 kB373 kB-8 B (-0.0%)
    apk (release)1.96 MB1.96 MB+60 B (+0.0%)
  • firebase-appdistribution

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.66 MB2.66 MB-4 B (-0.0%)
  • firebase-appdistribution-api

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)125 kB125 kB-4 B (-0.0%)
    apk (release)1.65 MB1.65 MB-24 B (-0.0%)
  • firebase-appdistribution-api-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.66 MB1.66 MB-108 B (-0.0%)
  • firebase-common

    TypeBase (a53ab64)Merge (43e6e00)Diff
    aar96.1 kB96.1 kB-1 B (-0.0%)
  • firebase-common-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    aar4.73 kB4.72 kB-2 B (-0.0%)
    apk (release)1.64 MB1.64 MB+4 B (+0.0%)
  • firebase-components

    TypeBase (a53ab64)Merge (43e6e00)Diff
    aar45.5 kB45.5 kB+2 B (+0.0%)
  • firebase-config

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)161 kB162 kB+4 B (+0.0%)
    apk (release)1.71 MB1.71 MB-96 B (-0.0%)
  • firebase-config-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.71 MB1.71 MB-28 B (-0.0%)
  • firebase-crashlytics

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.18 MB2.18 MB-72 B (-0.0%)
  • firebase-crashlytics-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)435 kB435 kB+4 B (+0.0%)
    apk (release)2.18 MB2.18 MB-24 B (-0.0%)
  • firebase-database

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)367 kB367 kB+4 B (+0.0%)
    apk (release)2.11 MB2.11 MB-28 B (-0.0%)
  • firebase-database-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.12 MB2.12 MB+84 B (+0.0%)
  • firebase-dynamic-links

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.95 MB1.95 MB-112 B (-0.0%)
  • firebase-dynamic-links-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.95 MB1.95 MB-132 B (-0.0%)
  • firebase-firestore

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)4.35 MB4.35 MB-96 B (-0.0%)
  • firebase-firestore-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)529 kB529 kB+4 B (+0.0%)
    apk (release)4.35 MB4.35 MB+36 B (+0.0%)
  • firebase-functions

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)409 kB409 kB+12 B (+0.0%)
    apk (release)2.20 MB2.20 MB-172 B (-0.0%)
  • firebase-functions-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)409 kB409 kB+12 B (+0.0%)
    apk (release)2.20 MB2.20 MB-104 B (-0.0%)
  • firebase-inappmessaging

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)710 kB710 kB+108 B (+0.0%)
    apk (release)4.34 MB4.34 MB+28 B (+0.0%)
  • firebase-inappmessaging-display

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)1.54 MB1.54 MB+12 B (+0.0%)
    apk (release)5.60 MB5.60 MB-96 B (-0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)1.55 MB1.55 MB-76 B (-0.0%)
    apk (release)5.60 MB5.60 MB-124 B (-0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)710 kB711 kB+76 B (+0.0%)
    apk (release)4.34 MB4.34 MB+120 B (+0.0%)
  • firebase-installations

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.67 MB1.67 MB+4 B (+0.0%)
  • firebase-installations-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)127 kB127 kB+4 B (+0.0%)
    apk (release)1.67 MB1.67 MB-100 B (-0.0%)
  • firebase-messaging

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.11 MB2.11 MB-72 B (-0.0%)
  • firebase-messaging-directboot

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.11 MB2.11 MB-140 B (-0.0%)
  • firebase-messaging-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)474 kB474 kB+4 B (+0.0%)
    apk (release)2.11 MB2.11 MB+52 B (+0.0%)
  • firebase-ml-modeldownloader

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.80 MB1.80 MB-172 B (-0.0%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)1.80 MB1.80 MB-124 B (-0.0%)
  • firebase-perf

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)1.25 MB1.25 MB+4 B (+0.0%)
    apk (release)3.76 MB3.76 MB+12 B (+0.0%)
  • firebase-perf-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)3.77 MB3.77 MB-172 B (-0.0%)
  • firebase-sessions

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (release)2.07 MB2.07 MB-72 B (-0.0%)
  • firebase-storage

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)373 kB373 kB+4 B (+0.0%)
    apk (release)1.99 MB1.99 MB+12 B (+0.0%)
  • firebase-storage-ktx

    TypeBase (a53ab64)Merge (43e6e00)Diff
    apk (aggressive)374 kB374 kB+4 B (+0.0%)
    apk (release)1.99 MB1.99 MB+56 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kErpqo1uOO.html

@VinayGuthal VinayGuthal merged commit a135c51 into master Oct 10, 2023
@VinayGuthal VinayGuthal deleted the update_common_version branch October 10, 2023 22:59
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,590 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dPnFYTZ1PF/index.html

@firebase firebase locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants