Skip to content

Fix the copyright format for Kotlin files #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix the copyright format for Kotlin files #5556

merged 2 commits into from
Nov 16, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Nov 16, 2023 •
edited
Loading

Fix the copyright format for Kotlin files. Kotlin files specifically should use the /* comment style not // see style-guide. The wrong format makes the copyright not display properly in IntelliJ.

I wrote and ran this simple script to fix all the files: https://paste.googleplex.com/6512718119436288

The copyright presubmit check should be updated to enforce the correct format for Kotlin files.

NO_RELEASE_CHANGE

@mrober mrober requested a review from davidmotson November 16, 2023 18:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

buildSrc Test Results

37 tests   37 ✔️  58s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit fdd331a.

♻️ This comment has been updated with latest results.

@mrober mrober enabled auto-merge (squash) November 16, 2023 19:05
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appcheck-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.49 kB5.49 kB+2 B (+0.0%)
    apk (release)5.13 MB5.13 MB+4 B (+0.0%)

  • firebase-appdistribution-api

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar20.3 kB20.3 kB-11 B (-0.1%)
    apk (release)4.64 MB4.64 MB-4 B (-0.0%)

  • firebase-appdistribution-api-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.12 kB5.12 kB-1 B (-0.0%)

  • firebase-common

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar107 kB107 kB-88 B (-0.1%)
    apk (release)4.63 MB4.63 MB+4 B (+0.0%)

  • firebase-common-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar4.72 kB4.73 kB+2 B (+0.0%)

  • firebase-config

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar108 kB108 kB-5 B (-0.0%)
    apk (release)4.81 MB4.81 MB+20 B (+0.0%)

  • firebase-config-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar4.79 kB4.80 kB+6 B (+0.1%)
    apk (release)4.82 MB4.82 MB+24 B (+0.0%)

  • firebase-crashlytics

    TypeBase (ea0f077)Merge (fd5682d)Diff
    apk (release)6.09 MB6.09 MB-20 B (-0.0%)

  • firebase-crashlytics-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.09 kB5.08 kB-3 B (-0.1%)
    apk (release)6.10 MB6.10 MB-16 B (-0.0%)

  • firebase-database

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar537 kB537 kB-382 B (-0.1%)
    apk (release)5.54 MB5.54 MB+40 B (+0.0%)

  • firebase-database-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.21 kB5.21 kB+1 B (+0.0%)
    apk (release)5.54 MB5.54 MB+44 B (+0.0%)

  • firebase-dynamic-links

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar61.8 kB61.8 kB+9 B (+0.0%)
    apk (release)5.13 MB5.13 MB+4 B (+0.0%)

  • firebase-dynamic-links-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    apk (release)5.13 MB5.13 MB+8 B (+0.0%)

  • firebase-firestore

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar1.41 MB1.41 MB-104 B (-0.0%)
    apk (release)11.2 MB11.2 MB-12 B (-0.0%)

  • firebase-firestore-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.20 kB5.20 kB-1 B (-0.0%)
    apk (release)11.2 MB11.2 MB-8 B (-0.0%)

  • firebase-functions

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar52.0 kB52.0 kB+1 B (+0.0%)

  • firebase-functions-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.20 kB5.21 kB+5 B (+0.1%)
    apk (release)5.65 MB5.65 MB+4 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar461 kB461 kB+16 B (+0.0%)

  • firebase-inappmessaging-display

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar185 kB185 kB-5 B (-0.0%)

  • firebase-inappmessaging-display-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar17.4 kB17.4 kB+1 B (+0.0%)
    apk (release)13.9 MB13.9 MB+4 B (+0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar4.81 kB4.82 kB+8 B (+0.2%)
    apk (release)11.5 MB11.5 MB+4 B (+0.0%)

  • firebase-installations

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar58.5 kB58.5 kB+20 B (+0.0%)
    apk (release)4.68 MB4.68 MB-4 B (-0.0%)

  • firebase-messaging

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar146 kB146 kB+4 B (+0.0%)

  • firebase-messaging-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    apk (release)5.53 MB5.53 MB+4 B (+0.0%)

  • firebase-ml-modeldownloader

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar127 kB127 kB+1 B (+0.0%)
    apk (release)5.01 MB5.01 MB-8 B (-0.0%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.15 kB5.14 kB-5 B (-0.1%)
    apk (release)5.02 MB5.02 MB-4 B (-0.0%)

  • firebase-perf

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar322 kB322 kB-3 B (-0.0%)

  • firebase-perf-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar14.8 kB14.8 kB+2 B (+0.0%)
    apk (release)9.27 MB9.27 MB+4 B (+0.0%)

  • firebase-storage

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar134 kB134 kB-15 B (-0.0%)

  • firebase-storage-ktx

    TypeBase (ea0f077)Merge (fd5682d)Diff
    aar5.21 kB5.21 kB+3 B (+0.1%)
    apk (release)5.24 MB5.24 MB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZfSM8ANUw4.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.74% (ea0f077) to 44.75% (fd5682d) by +0.01%.

    FilenameBase (ea0f077)Merge (fd5682d)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%

  • firebase-messaging

    Overall coverage changed from 83.85% (ea0f077) to 83.97% (fd5682d) by +0.11%.

    FilenameBase (ea0f077)Merge (fd5682d)Diff
    Metadata.java36.51%41.27%+4.76%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.43% (ea0f077) to 83.36% (fd5682d) by -0.06%.

    FilenameBase (ea0f077)Merge (fd5682d)Diff
    FirebaseModelDownloader.java84.66%84.05%-0.61%

  • firebase-storage

    Overall coverage changed from 83.96% (ea0f077) to 84.04% (fd5682d) by +0.08%.

    FilenameBase (ea0f077)Merge (fd5682d)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.69%+0.30%
    StreamDownloadTask.java88.89%88.41%-0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VIo5ejIRcS.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,692 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j7McZrC9XE/index.html

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

     946 files  +   906       946 suites  +906   31m 40s ⏱️ + 30m 39s
  5 163 tests +4 855    5 142 ✔️ +4 834  21 💤 +21  0 ❌ ±0 
10 411 runs  +9 783  10 369 ✔️ +9 741  42 💤 +42  0 ❌ ±0 

Results for commit fdd331a. ± Comparison against base commit ea0f077.

@mrober mrober merged commit 7f53ce4 into master Nov 16, 2023
@mrober mrober deleted the fixKotlinCopyright branch November 16, 2023 20:17
@firebase firebase locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmotson davidmotson davidmotson approved these changes

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrober @google-oss-bot @davidmotson