Skip to content

Fix crashlytics copybara #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Fix crashlytics copybara #5558

merged 3 commits into from
Nov 17, 2023

Conversation

VinayGuthal
Copy link
Contributor

Some of the methods donot have the right nullable annotations. This pr updates all of them

Copy link

google-cla bot commented Nov 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 16, 2023

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Unit Test Results

0 files   -      948  0 suites   - 948   0s ⏱️ - 31m 20s
0 tests  -   5 173  0 ✔️  -   5 152  0 💤  - 21  0 ±0 
0 runs   - 10 431  0 ✔️  - 10 389  0 💤  - 42  0 ±0 

Results for commit 2805bd9. ± Comparison against base commit 1f531b9.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 16, 2023

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (1f531b9)Merge (feec674)Diff
    aar403 kB403 kB+101 B (+0.0%)
    apk (release)6.09 MB6.09 MB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ou0muWDngI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 16, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile1f531b9feec674DiffSignificant (?)
    p109.43 ±2 ms10.4 ±3 ms+946 μs (+10.0%)NO
    p2510.1 ±2 ms10.9 ±3 ms+820 μs (+8.1%)NO
    p5011.1 ±2 ms11.9 ±3 ms+827 μs (+7.5%)NO
    p7512.4 ±2 ms13.3 ±3 ms+932 μs (+7.5%)NO
    p9014.1 ±2 ms15.1 ±3 ms+1.06 ms (+7.5%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
    redfin-30
    Percentile1f531b9feec674DiffSignificant (?)
    p1015.7 ±6 ms14.5 ±5 ms-1.20 ms (-7.6%)NO
    p2516.6 ±7 ms15.4 ±5 ms-1.23 ms (-7.4%)NO
    p5017.9 ±7 ms16.4 ±6 ms-1.46 ms (-8.2%)NO
    p7519.5 ±9 ms18.1 ±7 ms-1.39 ms (-7.1%)NO
    p9021.7 ±9.6 ms20.2 ±8 ms-1.52 ms (-7.0%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile1f531b9feec674DiffSignificant (?)
    p10441 ±472 μs114 ±98 μs-327 μs (-74.2%)NO
    p25456 ±485 μs119 ±102 μs-338 μs (-74.0%)NO
    p50484 ±513 μs128 ±109 μs-356 μs (-73.6%)NO
    p75547 ±586 μs155 ±119 μs-392 μs (-71.7%)NO
    p90675 ±699 μs190 ±159 μs-486 μs (-71.9%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
    redfin-30
    Percentile1f531b9feec674DiffSignificant (?)
    p10275 ±260 μs333 ±436 μs+58.2 μs (+21.2%)NO
    p25294 ±286 μs385 ±561 μs+90.5 μs (+30.7%)NO
    p50349 ±396 μs456 ±677 μs+107 μs (+30.7%)NO
    p75438 ±578 μs558 ±813 μs+120 μs (+27.4%)NO
    p90576 ±759 μs733 ±1096 μs+157 μs (+27.2%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile1f531b9feec674DiffSignificant (?)
    p107.36 ±1 ms6.74 ±1 ms-621 μs (-8.4%)NO
    p257.85 ±1 ms7.09 ±1 ms-761 μs (-9.7%)NO
    p508.60 ±1 ms7.68 ±1 ms-916 μs (-10.7%)NO
    p759.64 ±1 ms8.51 ±2 ms-1.13 ms (-11.7%)NO
    p9011.0 ±2 ms9.85 ±2 ms-1.17 ms (-10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
    redfin-30
    Percentile1f531b9feec674DiffSignificant (?)
    p1011.9 ±2 ms13.6 ±3 ms+1.76 ms (+14.8%)NO
    p2512.5 ±2 ms14.7 ±4 ms+2.28 ms (+18.3%)NO
    p5013.7 ±3 ms16.9 ±6 ms+3.19 ms (+23.3%)NO
    p7517.9 ±3 ms21.0 ±6 ms+3.13 ms (+17.5%)NO
    p9020.6 ±4 ms24.4 ±7 ms+3.76 ms (+18.2%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile1f531b9feec674DiffSignificant (?)
    p10203 ±4 ms206 ±3 ms+3.37 ms (+1.7%)NO
    p25209 ±3 ms213 ±3 ms+3.13 ms (+1.5%)NO
    p50217 ±3 ms220 ±3 ms+2.97 ms (+1.4%)NO
    p75225 ±4 ms230 ±4 ms+4.22 ms (+1.9%)NO
    p90234 ±4 ms241 ±4 ms+6.79 ms (+2.9%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC
    redfin-30
    Percentile1f531b9feec674DiffSignificant (?)
    p10249 ±6 ms271 ±5 ms+21.5 ms (+8.6%)MAYBE
    p25256 ±8 ms277 ±5 ms+21.0 ms (+8.2%)NO
    p50264 ±9 ms285 ±6 ms+21.3 ms (+8.1%)NO
    p75273 ±10 ms295 ±6 ms+22.4 ms (+8.2%)NO
    p90283 ±11 ms308 ±7 ms+24.2 ms (+8.5%)NO

    20 test runs in comparison
    CommitTest Runs
    1f531b9
    • 2023-11-16_21:00:56.347388_rytL
    • 2023-11-16_21:00:56.347435_nYXB
    • 2023-11-16_21:00:56.347445_SZdu
    • 2023-11-16_21:00:56.347454_UtOG
    • 2023-11-16_21:00:56.347462_aCcK
    • 2023-11-16_21:00:56.347471_RPQe
    • 2023-11-16_21:00:56.347477_kWbZ
    • 2023-11-16_21:00:56.347481_ZDhK
    • 2023-11-16_21:00:56.347488_WiLz
    • 2023-11-16_21:00:56.347496_OCTQ
    feec674
    • 2023-11-16_22:10:16.114908_saGT
    • 2023-11-16_22:10:16.114950_QpRd
    • 2023-11-16_22:10:16.114958_mzzD
    • 2023-11-16_22:10:16.114966_FOwe
    • 2023-11-16_22:10:16.114975_AWXh
    • 2023-11-16_22:10:16.114983_kBFG
    • 2023-11-16_22:10:16.114990_EzSX
    • 2023-11-16_22:10:16.114997_VfjO
    • 2023-11-16_22:10:16.115004_kpVN
    • 2023-11-16_22:10:16.115011_rpjC

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tST6QSfXTe/index.html

@VinayGuthal VinayGuthal added the cla: yes Override cla label Nov 16, 2023
@VinayGuthal VinayGuthal merged commit 8a7621b into master Nov 17, 2023
@VinayGuthal VinayGuthal deleted the fix_crashlytics_copybara branch November 17, 2023 03:46
@firebase firebase locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants