Skip to content

Call messageHandled after a message has been handled. #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

gsakakihara
Copy link
Contributor

  • Called messageHandled() after a message has been handled to indicate that the message has been handled successfully.

* Called messageHandled() after a message has been handled to indicate that the message has been handled successfully.
Copy link
Contributor

github-actions bot commented Nov 22, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-messaging
### {{messaging_longer}} version 23.3.2 {: #messaging_v23-3-2}

* {{changed}} Called messageHandled() after a message has been handled to indicate
  that the message has been handled successfully.

* {{changed}} Added an internal identifier to Firelog logging for compliance.

#### {{messaging_longer}} Kotlin extensions version 23.3.2 {: #messaging-ktx_v23-3-2}

The Kotlin extensions library transitively includes the updated
`firebase-messaging` library. The Kotlin extensions library has no additional
updates.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (a014114)Merge (e3d2bfc)Diff
    aar146 kB147 kB+300 B (+0.2%)
    apk (aggressive)777 kB778 kB+388 B (+0.0%)
    apk (release)5.52 MB5.52 MB+212 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0zYP9Ad3nR.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 83.85% (a014114) to 83.93% (e3d2bfc) by +0.07%.

    FilenameBase (a014114)Merge (e3d2bfc)Diff
    FirebaseMessaging.java73.57%73.13%-0.44%
    FirebaseMessagingService.java94.03%94.52%+0.49%
    RequestDeduplicator.java80.00%90.00%+10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Bn3KHaTkv3.html

Copy link
Contributor

Unit Test Results

  62 files   -    118    62 suites   - 118   5m 52s ⏱️ + 1m 59s
475 tests  -    747  475 ✔️  -    731  0 💤  - 16  0 ±0 
956 runs   - 1 512  956 ✔️  - 1 480  0 💤  - 32  0 ±0 

Results for commit 7416af5. ± Comparison against base commit a014114.

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fcm

    DeviceStatisticsDistributions
    oriole-32
    Percentilea014114e3d2bfcDiffSignificant (?)
    p101.24 ±2 ms2.99 ±2 ms+1.75 ms (+141.1%)NO
    p251.31 ±2 ms3.17 ±2 ms+1.86 ms (+142.3%)NO
    p501.41 ±2 ms3.46 ±2 ms+2.05 ms (+145.3%)NO
    p751.62 ±2 ms3.95 ±2 ms+2.33 ms (+144.2%)NO
    p901.88 ±2 ms4.53 ±2 ms+2.66 ms (+141.7%)NO

    20 test runs in comparison
    CommitTest Runs
    a014114
    • 2023-11-21_18:26:52.693692_Xotd
    • 2023-11-21_18:26:52.693719_UCgP
    • 2023-11-21_18:26:52.693730_urex
    • 2023-11-21_18:26:52.693740_ChcC
    • 2023-11-21_18:26:52.693749_rsrl
    • 2023-11-21_18:26:52.693758_syyJ
    • 2023-11-21_18:26:52.693767_njAK
    • 2023-11-21_18:26:52.693775_fZJz
    • 2023-11-21_18:26:52.693782_ZuPn
    • 2023-11-21_18:26:52.693789_dLzH
    e3d2bfc
    • 2023-11-22_21:01:04.739094_uIrA
    • 2023-11-22_21:01:04.739125_pfoe
    • 2023-11-22_21:01:04.739137_ZjJp
    • 2023-11-22_21:01:04.739146_asXY
    • 2023-11-22_21:01:04.739154_wzIZ
    • 2023-11-22_21:01:04.739161_HFTX
    • 2023-11-22_21:01:04.739173_NIZb
    • 2023-11-22_21:01:04.739180_IKCc
    • 2023-11-22_21:01:04.739187_ZHCB
    • 2023-11-22_21:01:04.739194_bUVH
    redfin-30
    Percentilea014114e3d2bfcDiffSignificant (?)
    p103.71 ±4 ms3.25 ±3 ms-461 μs (-12.4%)NO
    p254.09 ±4 ms3.57 ±3 ms-522 μs (-12.8%)NO
    p504.66 ±4 ms4.01 ±4 ms-648 μs (-13.9%)NO
    p755.53 ±5 ms4.68 ±4 ms-850 μs (-15.4%)NO
    p906.75 ±6 ms6.00 ±5 ms-752 μs (-11.1%)NO

    20 test runs in comparison
    CommitTest Runs
    a014114
    • 2023-11-21_18:26:52.693692_Xotd
    • 2023-11-21_18:26:52.693719_UCgP
    • 2023-11-21_18:26:52.693730_urex
    • 2023-11-21_18:26:52.693740_ChcC
    • 2023-11-21_18:26:52.693749_rsrl
    • 2023-11-21_18:26:52.693758_syyJ
    • 2023-11-21_18:26:52.693767_njAK
    • 2023-11-21_18:26:52.693775_fZJz
    • 2023-11-21_18:26:52.693782_ZuPn
    • 2023-11-21_18:26:52.693789_dLzH
    e3d2bfc
    • 2023-11-22_21:01:04.739094_uIrA
    • 2023-11-22_21:01:04.739125_pfoe
    • 2023-11-22_21:01:04.739137_ZjJp
    • 2023-11-22_21:01:04.739146_asXY
    • 2023-11-22_21:01:04.739154_wzIZ
    • 2023-11-22_21:01:04.739161_HFTX
    • 2023-11-22_21:01:04.739173_NIZb
    • 2023-11-22_21:01:04.739180_IKCc
    • 2023-11-22_21:01:04.739187_ZHCB
    • 2023-11-22_21:01:04.739194_bUVH
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilea014114e3d2bfcDiffSignificant (?)
    p10204 ±3 ms207 ±3 ms+3.41 ms (+1.7%)NO
    p25210 ±4 ms213 ±3 ms+2.98 ms (+1.4%)NO
    p50218 ±4 ms221 ±4 ms+3.39 ms (+1.6%)NO
    p75226 ±4 ms231 ±5 ms+4.91 ms (+2.2%)NO
    p90236 ±4 ms245 ±9.6 ms+9.44 ms (+4.0%)NO

    20 test runs in comparison
    CommitTest Runs
    a014114
    • 2023-11-21_18:26:52.693692_Xotd
    • 2023-11-21_18:26:52.693719_UCgP
    • 2023-11-21_18:26:52.693730_urex
    • 2023-11-21_18:26:52.693740_ChcC
    • 2023-11-21_18:26:52.693749_rsrl
    • 2023-11-21_18:26:52.693758_syyJ
    • 2023-11-21_18:26:52.693767_njAK
    • 2023-11-21_18:26:52.693775_fZJz
    • 2023-11-21_18:26:52.693782_ZuPn
    • 2023-11-21_18:26:52.693789_dLzH
    e3d2bfc
    • 2023-11-22_21:01:04.739094_uIrA
    • 2023-11-22_21:01:04.739125_pfoe
    • 2023-11-22_21:01:04.739137_ZjJp
    • 2023-11-22_21:01:04.739146_asXY
    • 2023-11-22_21:01:04.739154_wzIZ
    • 2023-11-22_21:01:04.739161_HFTX
    • 2023-11-22_21:01:04.739173_NIZb
    • 2023-11-22_21:01:04.739180_IKCc
    • 2023-11-22_21:01:04.739187_ZHCB
    • 2023-11-22_21:01:04.739194_bUVH
    redfin-30
    Percentilea014114e3d2bfcDiffSignificant (?)
    p10250 ±7 ms271 ±5 ms+20.7 ms (+8.3%)MAYBE
    p25256 ±7 ms277 ±5 ms+21.1 ms (+8.3%)MAYBE
    p50264 ±8 ms285 ±7 ms+20.7 ms (+7.8%)NO
    p75275 ±9 ms295 ±8 ms+20.1 ms (+7.3%)NO
    p90283 ±9 ms308 ±11 ms+24.8 ms (+8.7%)NO

    20 test runs in comparison
    CommitTest Runs
    a014114
    • 2023-11-21_18:26:52.693692_Xotd
    • 2023-11-21_18:26:52.693719_UCgP
    • 2023-11-21_18:26:52.693730_urex
    • 2023-11-21_18:26:52.693740_ChcC
    • 2023-11-21_18:26:52.693749_rsrl
    • 2023-11-21_18:26:52.693758_syyJ
    • 2023-11-21_18:26:52.693767_njAK
    • 2023-11-21_18:26:52.693775_fZJz
    • 2023-11-21_18:26:52.693782_ZuPn
    • 2023-11-21_18:26:52.693789_dLzH
    e3d2bfc
    • 2023-11-22_21:01:04.739094_uIrA
    • 2023-11-22_21:01:04.739125_pfoe
    • 2023-11-22_21:01:04.739137_ZjJp
    • 2023-11-22_21:01:04.739146_asXY
    • 2023-11-22_21:01:04.739154_wzIZ
    • 2023-11-22_21:01:04.739161_HFTX
    • 2023-11-22_21:01:04.739173_NIZb
    • 2023-11-22_21:01:04.739180_IKCc
    • 2023-11-22_21:01:04.739187_ZHCB
    • 2023-11-22_21:01:04.739194_bUVH

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lFGIpAJn71/index.html

@gsakakihara gsakakihara merged commit 879c84b into master Nov 22, 2023
@gsakakihara gsakakihara deleted the gsakakihara/message_handled branch November 22, 2023 21:47
@firebase firebase locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants