Skip to content

Upgrade io.grpc to 1.57.2 #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Upgrade io.grpc to 1.57.2 #5609

merged 2 commits into from
Dec 20, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Dec 19, 2023

We cannot upgrade io.grpc further than 1.57.2 until we increase min SDK to level 21 or higher.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@tom-andersen tom-andersen self-assigned this Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Unit Test Results

     948 files  +   768       948 suites  +768   31m 44s ⏱️ + 27m 38s
  5 178 tests +3 952    5 157 ✔️ +3 947  21 💤 +  5  0 ±0 
10 441 runs  +7 965  10 399 ✔️ +7 955  42 💤 +10  0 ±0 

Results for commit 8e9a9fb. ± Comparison against base commit 16a90fa.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (16a90fa)Merge (6b7958e)Diff
    aar1.41 MB1.41 MB+413 B (+0.0%)
    apk (aggressive)704 kB704 kB-203 B (-0.0%)
    apk (release)11.2 MB11.4 MB+200 kB (+1.8%)
  • firebase-firestore-ktx

    TypeBase (16a90fa)Merge (6b7958e)Diff
    apk (aggressive)704 kB704 kB-207 B (-0.0%)
    apk (release)11.2 MB11.4 MB+200 kB (+1.8%)
  • firebase-inappmessaging

    TypeBase (16a90fa)Merge (6b7958e)Diff
    aar461 kB461 kB+394 B (+0.1%)
    apk (aggressive)1.33 MB1.34 MB+7.73 kB (+0.6%)
    apk (release)11.5 MB11.7 MB+188 kB (+1.6%)
  • firebase-inappmessaging-display

    TypeBase (16a90fa)Merge (6b7958e)Diff
    apk (aggressive)2.56 MB2.57 MB+7.90 kB (+0.3%)
    apk (release)13.9 MB14.1 MB+190 kB (+1.4%)
  • firebase-inappmessaging-display-ktx

    TypeBase (16a90fa)Merge (6b7958e)Diff
    apk (aggressive)2.56 MB2.57 MB+7.90 kB (+0.3%)
    apk (release)13.9 MB14.1 MB+190 kB (+1.4%)
  • firebase-inappmessaging-ktx

    TypeBase (16a90fa)Merge (6b7958e)Diff
    apk (aggressive)1.33 MB1.34 MB+7.73 kB (+0.6%)
    apk (release)11.5 MB11.7 MB+188 kB (+1.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bCYvsXPxzI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.77% (16a90fa) to 44.84% (6b7958e) by +0.07%.

    FilenameBase (16a90fa)Merge (6b7958e)Diff
    FirestoreGrpc.java2.46%3.13%+0.66%
  • firebase-inappmessaging

    Overall coverage changed from 39.28% (16a90fa) to 39.24% (6b7958e) by -0.04%.

    FilenameBase (16a90fa)Merge (6b7958e)Diff
    InAppMessagingSdkServingGrpc.java51.22%45.95%-5.27%
  • firebase-messaging

    Overall coverage changed from 83.93% (16a90fa) to 84.00% (6b7958e) by +0.08%.

    FilenameBase (16a90fa)Merge (6b7958e)Diff
    FirebaseMessaging.java73.13%74.01%+0.88%
  • firebase-storage

    Overall coverage changed from 83.96% (16a90fa) to 83.92% (6b7958e) by -0.04%.

    FilenameBase (16a90fa)Merge (6b7958e)Diff
    StreamDownloadTask.java88.89%88.41%-0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/J9b3XS9B4M.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2023

Startup Time Report 1

The report is too large (122,657 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hDgvatst1L/index.html

@tom-andersen tom-andersen changed the title Upgrade io.grpc to 1.60.0 Upgrade io.grpc to 1.57.2 Dec 19, 2023
@tom-andersen tom-andersen marked this pull request as ready for review December 20, 2023 14:24
@tom-andersen tom-andersen requested a review from rlazo December 20, 2023 14:24
@tom-andersen tom-andersen merged commit 36cc041 into master Dec 20, 2023
@tom-andersen tom-andersen deleted the tomandersen/upgradeGrpc branch December 20, 2023 14:47
@firebase firebase locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants