User action refactor #6120

themiswang · 2024-07-24T18:15:38Z

Creating common and disk worker based on Firebase background common executor
Move all user action directly to background thread and remove some unnecessary task submit
Add unit tests dependency for firebase common executor
Decouple crashlytics backend handler from user metadata and use disk writing working for persistence write.

github-actions · 2024-07-24T18:15:53Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2024-07-24T18:16:20Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2024-07-24T18:21:31Z

Coverage Report ¹

Affected Products

firebase-crashlytics
Overall coverage changed from 11.14% (96b702f) to 11.16% (2a0650b) by +0.02%.
Filename Base (96b702f) Merge (2a0650b) Diff
CrashlyticsController.java 16.06% 16.58% +0.52%
CrashlyticsCore.java 0.63% 0.62% -0.01%
UserMetadata.java 22.12% 22.33% +0.21%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/bHmVwqtMzf.html

google-oss-bot · 2024-07-24T18:27:04Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (96b702f) Merge (2a0650b) Diff
aar 416 kB 415 kB -1.21 kB (-0.3%)
apk (aggressive) 697 kB 697 kB +368 B (+0.1%)
apk (release) 5.85 MB 5.85 MB +2.58 kB (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/uzPfPpkoIQ.html

github-actions · 2024-07-24T18:27:36Z

Unit Test Results

  8 files ±0   8 suites ±0 26s ⏱️ ±0s
22 tests ±0 22 ✔️ ±0 0 💤 ±0 0 ❌ ±0
44 runs ±0 44 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit d4580f4. ± Comparison against base commit 96b702f.

♻️ This comment has been updated with latest results.

google-oss-bot · 2024-07-24T18:47:23Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (96b702f) and the CI merge commit (2a0650b)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 96b702f: https://storage.googleapis.com/firebase-sdk-metric-reports/jAfa1DDTMW/index.html
- 2a0650b: https://storage.googleapis.com/firebase-sdk-metric-reports/BOve6JjQbk/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	12.3 ±3 ms	10.9 ±2 ms	-1.43 ms (-11.6%)	NO
p25	13.1 ±3 ms	11.6 ±3 ms	-1.50 ms (-11.5%)	NO
p50	14.2 ±3 ms	12.5 ±3 ms	-1.70 ms (-12.0%)	NO
p75	15.5 ±3 ms	13.7 ±3 ms	-1.80 ms (-11.6%)	NO
p90	17.3 ±4 ms	15.4 ±3 ms	-1.89 ms (-10.9%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

redfin-30

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	17.2 ±6 ms	17.7 ±7 ms	+588 μs (+3.4%)	NO
p25	18.3 ±7 ms	19.0 ±8 ms	+725 μs (+4.0%)	NO
p50	19.9 ±8 ms	20.5 ±9.5 ms	+609 μs (+3.1%)	NO
p75	21.8 ±9 ms	22.2 ±10 ms	+319 μs (+1.5%)	NO
p90	24.1 ±9 ms	25.2 ±11 ms	+1.14 ms (+4.8%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	456 ±640 μs	89.8 ±12 μs	-367 μs (-80.3%)	NO
p25	481 ±667 μs	94.6 ±13 μs	-387 μs (-80.4%)	NO
p50	523 ±715 μs	107 ±19 μs	-416 μs (-79.5%)	NO
p75	620 ±843 μs	132 ±29 μs	-488 μs (-78.7%)	NO
p90	749 ±1004 μs	185 ±73 μs	-563 μs (-75.2%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

redfin-30

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	309 ±309 μs	430 ±504 μs	+120 μs (+38.9%)	NO
p25	366 ±402 μs	507 ±610 μs	+141 μs (+38.5%)	NO
p50	457 ±556 μs	635 ±742 μs	+178 μs (+38.9%)	NO
p75	586 ±780 μs	838 ±886 μs	+252 μs (+43.0%)	NO
p90	773 ±1092 μs	1.09 ±1 ms	+318 μs (+41.2%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	3.01 ±0.8 ms	2.72 ±0.6 ms	-293 μs (-9.7%)	NO
p25	3.21 ±0.9 ms	2.91 ±0.6 ms	-301 μs (-9.4%)	NO
p50	3.53 ±1 ms	3.36 ±0.7 ms	-178 μs (-5.0%)	NO
p75	4.08 ±1 ms	3.97 ±0.9 ms	-112 μs (-2.7%)	NO
p90	4.89 ±1 ms	4.95 ±1 ms	+59.6 μs (+1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

redfin-30

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	5.93 ±1 ms	5.86 ±1 ms	-70.2 μs (-1.2%)	NO
p25	6.37 ±2 ms	6.23 ±1 ms	-146 μs (-2.3%)	NO
p50	7.08 ±2 ms	6.66 ±2 ms	-414 μs (-5.8%)	NO
p75	7.90 ±3 ms	7.33 ±2 ms	-578 μs (-7.3%)	NO
p90	8.78 ±4 ms	8.39 ±3 ms	-392 μs (-4.5%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	203 ±3 ms	205 ±3 ms	+1.98 ms (+1.0%)	NO
p25	208 ±3 ms	211 ±3 ms	+2.66 ms (+1.3%)	NO
p50	216 ±3 ms	218 ±3 ms	+2.28 ms (+1.1%)	NO
p75	223 ±5 ms	226 ±3 ms	+2.57 ms (+1.2%)	NO
p90	231 ±7 ms	235 ±3 ms	+3.93 ms (+1.7%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

redfin-30

Percentile	`96b702f`	`2a0650b`	Diff	Significant (?)
p10	246 ±11 ms	270 ±6 ms	+23.4 ms (+9.5%)	NO
p25	251 ±11 ms	275 ±7 ms	+23.3 ms (+9.2%)	NO
p50	258 ±13 ms	282 ±9 ms	+24.1 ms (+9.3%)	NO
p75	268 ±19 ms	292 ±11 ms	+24.2 ms (+9.0%)	NO
p90	280 ±25 ms	308 ±25 ms	+28.9 ms (+10.3%)	NO

20 test runs in comparison

Commit	Test Runs
`96b702f`	2024-07-29_16:44:12.664388_cfAs 2024-07-29_16:44:12.664436_SRPs 2024-07-29_16:44:12.664449_Xupy 2024-07-29_16:44:12.664459_Ufiw 2024-07-29_16:44:12.664468_MbtB 2024-07-29_16:44:12.664478_AClO 2024-07-29_16:44:12.664486_TdVM 2024-07-29_16:44:12.664495_pFBW 2024-07-29_16:44:12.664504_etSg 2024-07-29_16:44:12.664513_FCtm
`2a0650b`	2024-07-29_17:40:39.471274_syVN 2024-07-29_17:40:39.471870_BBzg 2024-07-29_17:40:39.471883_eSvc 2024-07-29_17:40:39.471891_KJYR 2024-07-29_17:40:39.471899_HutJ 2024-07-29_17:40:39.471906_KqDQ 2024-07-29_17:40:39.471914_oCIw 2024-07-29_17:40:39.471921_gymr 2024-07-29_17:40:39.471928_hkeZ 2024-07-29_17:40:39.471935_isNT

https://storage.googleapis.com/firebase-sdk-metric-reports/VGDycMKzzG/index.html

...rc/androidTest/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCoreTest.java

...rashlytics/src/main/java/com/google/firebase/crashlytics/internal/metadata/UserMetadata.java

Other metadata persistence is already on the right work from the previous pr #6120 - Move log and non-fatal persistence to disk write worker - Refine unit tests - Remove unused functions and interface

This reverts commit 3a4ec18.

themiswang requested a review from mrober July 24, 2024 18:15

google-oss-bot added the do-not-merge/work-in-progress label Jul 24, 2024

google-oss-bot added the size/L label Jul 24, 2024

themiswang commented Jul 24, 2024

View reviewed changes

...rc/androidTest/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCoreTest.java Outdated Show resolved Hide resolved

themiswang commented Jul 25, 2024

View reviewed changes

...rashlytics/src/main/java/com/google/firebase/crashlytics/internal/metadata/UserMetadata.java Outdated Show resolved Hide resolved

themiswang force-pushed the userAction branch 2 times, most recently from f828f55 to ec8c005 Compare July 26, 2024 18:27

themiswang marked this pull request as ready for review July 26, 2024 18:30

google-oss-bot removed the do-not-merge/work-in-progress label Jul 26, 2024

mrober added a commit that referenced this pull request Jul 29, 2024

Copy test from @themiswang ##6120 to make merging easier

f0f05a8

themiswang added 2 commits July 29, 2024 13:28

user action refactor

bad1a13

fix test

d4580f4

themiswang force-pushed the userAction branch from 7f2cbc4 to d4580f4 Compare July 29, 2024 17:29

mrober approved these changes Jul 29, 2024

View reviewed changes

themiswang merged commit 3a4ec18 into main Jul 29, 2024
41 of 42 checks passed

themiswang deleted the userAction branch July 29, 2024 17:58

themiswang mentioned this pull request Jul 29, 2024

Move log and non-fatal persistence to disk write worker #6133

Merged

mrober added a commit that referenced this pull request Aug 19, 2024

Revert "User action refactor (#6120)"

656882e

This reverts commit 3a4ec18.

firebase locked and limited conversation to collaborators Aug 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

User action refactor #6120

User action refactor #6120

Uh oh!

themiswang commented Jul 24, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 24, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 24, 2024

Uh oh!

google-oss-bot commented Jul 24, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

google-oss-bot commented Jul 24, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

github-actions bot commented Jul 24, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 24, 2024 •

edited

Loading

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

User action refactor #6120

User action refactor #6120

Uh oh!

Conversation

themiswang commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

google-oss-bot commented Jul 24, 2024

Uh oh!

google-oss-bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

google-oss-bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

github-actions bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

themiswang commented Jul 24, 2024 •

edited

Loading

github-actions bot commented Jul 24, 2024 •

edited

Loading

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Size Report ¹

`firebase-crashlytics`

github-actions bot commented Jul 24, 2024 •

edited

Loading

google-oss-bot commented Jul 24, 2024 •

edited

Loading

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`