Merge GenAI Common into Vertex #6186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-vertexai/_toc.yaml 2024-08-21 20:40:30.408180266 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-vertexai/_toc.yaml 2024-08-21 20:38:01.263950648 +0000
@@ -15,6 +15,9 @@
- title: "GenerativeModel"
path: "/docs/reference/android/com/google/firebase/vertexai/GenerativeModel.html"
+- title: "com.google.firebase.vertexai.common.shared"
+ path: "/docs/reference/android/com/google/firebase/vertexai/common/shared/package-summary.html"
+
- title: "com.google.firebase.vertexai.java"
path: "/docs/reference/android/com/google/firebase/vertexai/java/package-summary.html"
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/common/shared/package-summary.html 1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/common/shared/package-summary.html 2024-08-21 20:38:01.255950635 +0000
@@ -0,0 +1,11 @@
+<html devsite="true">
+ <head>
+ <title>com.google.firebase.vertexai.common.shared</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+ </head>
+ <body>
+ <h1>com.google.firebase.vertexai.common.shared</h1>
+ </body>
+</html>
+--- /home/runner/diff/original/firebase-kotlindoc/kotlin/client/firebase-vertexai/_toc.yaml 2024-08-21 20:40:30.400180254 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/client/firebase-vertexai/_toc.yaml 2024-08-21 20:38:01.255950635 +0000
@@ -13,6 +13,9 @@
- title: "GenerativeModel"
path: "/docs/reference/kotlin/com/google/firebase/vertexai/GenerativeModel.html"
+- title: "com.google.firebase.vertexai.common.shared"
+ path: "/docs/reference/kotlin/com/google/firebase/vertexai/common/shared/package-summary.html"
+
- title: "com.google.firebase.vertexai.java"
path: "/docs/reference/kotlin/com/google/firebase/vertexai/java/package-summary.html"
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/common/shared/package-summary.html 1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/common/shared/package-summary.html 2024-08-21 20:38:01.247950622 +0000
@@ -0,0 +1,26 @@
+<html devsite="true">
+ <head>
+ <title>com.google.firebase.vertexai.common.shared</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/kotlin/_reference-head-tags.html" %}
+ </head>
+ <body>
+ <h1>com.google.firebase.vertexai.common.shared</h1>
+ <h2>Type aliases</h2>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <tbody class="list">
+ <tr>
+ <td><code>Base64</code></td>
+ <td></td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ </body>
+</html>
+ |
|
The public api surface has changed for the subproject firebase-vertexai_api.txt: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Unit Test Results 968 files + 964 968 suites +964 35m 41s ⏱️ + 35m 38s For more details on these failures, see this check. Results for commit c16d020. ± Comparison against base commit 5fe51eb. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
|
The public api surface has changed for the subproject firebase-vertexai_api.txt: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
daymxn
reviewed
Aug 20, 2024
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/common/Exceptions.kt
Outdated
Show resolved
Hide resolved
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/common/Exceptions.kt
Show resolved
Hide resolved
daymxn
approved these changes
Aug 20, 2024
|
The public api surface has changed for the subproject firebase-vertexai_api.txt: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
rlazo
approved these changes
Aug 21, 2024
rlazo
pushed a commit
that referenced
this pull request
Sep 12, 2024
A previous change, #6186, added the Kotlin serialization plugin to every single Gradle module; however, only one module actually used it. Moreover, it is becoming more conventional to define dependency versions in `gradle/libs.versions.toml`. This PR removes the global dependency on the Kotlin serialization plugin and, instead, moves the version into `gradle/libs.versions.toml`, and also modifies the dependency on the Kotlin JSON serialization library to use `gradle/libs.versions.toml`. This will make sure that every module uses the same version, which will become important once Data Connect, which also uses these libraries, is merged into main.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.