Skip to content

Avoid Tasks in checkForPreviousCrash #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -433,17 +433,11 @@ CrashlyticsController getController() {
* initialization to upload crash result. 4 seconds is chosen for the lock to prevent ANR
*/
private void finishInitSynchronously(SettingsProvider settingsProvider) {

final Runnable runnable =
new Runnable() {
@Override
public void run() {
doBackgroundInitialization(settingsProvider);
}
};

// TODO(mrober): Refactor to Tasks. Maybe just re-use async task and awaitEvenIfOnMain?
final Future<?> future = crashlyticsWorkers.common.getExecutor().submit(runnable);
Future<?> future =
crashlyticsWorkers
.common
.getExecutor()
.submit(() -> doBackgroundInitialization(settingsProvider));

Logger.getLogger()
.d(
Expand All @@ -452,12 +446,13 @@ public void run() {

try {
future.get(DEFAULT_MAIN_HANDLER_TIMEOUT_SEC, TimeUnit.SECONDS);
} catch (InterruptedException e) {
Logger.getLogger().e("Crashlytics was interrupted during initialization.", e);
} catch (ExecutionException e) {
Logger.getLogger().e("Crashlytics encountered a problem during initialization.", e);
} catch (TimeoutException e) {
Logger.getLogger().e("Crashlytics timed out during initialization.", e);
} catch (InterruptedException ex) {
Logger.getLogger().e("Crashlytics was interrupted during initialization.", ex);
Thread.currentThread().interrupt();
} catch (ExecutionException ex) {
Logger.getLogger().e("Crashlytics encountered a problem during initialization.", ex);
} catch (TimeoutException ex) {
Logger.getLogger().e("Crashlytics timed out during initialization.", ex);
}
}

Expand Down Expand Up @@ -496,13 +491,16 @@ boolean didPreviousInitializationFail() {
// region Previous crash handling

private void checkForPreviousCrash() {
Task<Boolean> task =
crashlyticsWorkers.common.submit(() -> controller.didCrashOnPreviousExecution());
Future<Boolean> future =
crashlyticsWorkers
.common
.getExecutor()
.submit(() -> controller.didCrashOnPreviousExecution());

Boolean result;
try {
result = Utils.awaitEvenIfOnMainThread(task);
} catch (Exception e) {
result = future.get(DEFAULT_MAIN_HANDLER_TIMEOUT_SEC, TimeUnit.SECONDS);
} catch (Exception ignored) {
didCrashOnPreviousExecution = false;
return;
}
Expand Down
Loading