Skip to content

Fix release notes export name #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix release notes export name #6210

merged 2 commits into from
Aug 23, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Aug 23, 2024

Per b/361778952,

This renames the exported release notes in the build artifact workflow to be release_notes instead of release_artifacts. It seems my previous commit to do this didn't make it in before the branch was merged.

This PR also fixes the following:

@daymxn daymxn self-assigned this Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn changed the title Fix release notes export name [WIP] Fix release notes export name Aug 23, 2024
@daymxn daymxn changed the title [WIP] Fix release notes export name Fix release notes export name Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Unit Test Results

     968 files  ±0       968 suites  ±0   35m 35s ⏱️ +4s
  5 323 tests ±0    5 302 ✔️ ±0  21 💤 ±0  0 ±0 
10 731 runs  ±0  10 689 ✔️ ±0  42 💤 ±0  0 ±0 

Results for commit 2dad30f. ± Comparison against base commit 0672a3c.

♻️ This comment has been updated with latest results.

@daymxn daymxn enabled auto-merge (squash) August 23, 2024 16:13
@daymxn daymxn merged commit fd01196 into main Aug 23, 2024
251 of 252 checks passed
@daymxn daymxn deleted the daymon-fix-release-notes-name branch August 23, 2024 16:23
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.20% (0672a3c) to 50.21% (a4b4873) by +0.01%.

    FilenameBase (0672a3c)Merge (a4b4873)Diff
    ViewProcessor.java91.79%92.10%+0.30%
  • firebase-messaging

    Overall coverage changed from 84.24% (0672a3c) to 84.12% (a4b4873) by -0.11%.

    FilenameBase (0672a3c)Merge (a4b4873)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (0672a3c) to 83.32% (a4b4873) by -0.06%.

    FilenameBase (0672a3c)Merge (a4b4873)Diff
    FirebaseModelDownloader.java84.66%84.05%-0.61%
  • firebase-storage

    Overall coverage changed from ? (0672a3c) to 83.92% (a4b4873) by ?.

    48 individual files with coverage change

    FilenameBase (0672a3c)Merge (a4b4873)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.29%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0cX5m1GwV2.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,612 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yGcs2rK0If/index.html

@firebase firebase locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants