Skip to content

protoc-gen-firebase-encoders.gradle: use libs.versions.toml #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 12, 2024

This is a change that will be required once data connect is merged into main so that they share the same dependency versions.

@dconeybe dconeybe self-assigned this Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Unit Test Results

     968 files  +     924       968 suites  +924   34m 56s ⏱️ + 28m 50s
  5 323 tests +  5 187    5 302 ✔️ +  5 166  21 💤 +21  0 ±0 
10 731 runs  +10 439  10 689 ✔️ +10 397  42 💤 +42  0 ±0 

Results for commit 32cb3bf. ± Comparison against base commit 27a16a1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 12, 2024

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.20% (27a16a1) to 50.17% (dcf01e1) by -0.02%.

    FilenameBase (27a16a1)Merge (dcf01e1)Diff
    BooleanNode.java92.31%100.00%+7.69%
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    DefaultPersistenceManager.java74.76%75.73%+0.97%
  • firebase-firestore

    Overall coverage changed from 46.05% (27a16a1) to 46.06% (dcf01e1) by +0.02%.

    FilenameBase (27a16a1)Merge (dcf01e1)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
  • firebase-messaging

    Overall coverage changed from 84.13% (27a16a1) to 84.24% (dcf01e1) by +0.11%.

    FilenameBase (27a16a1)Merge (dcf01e1)Diff
    Metadata.java36.51%41.27%+4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (27a16a1) to 83.14% (dcf01e1) by -0.25%.

    FilenameBase (27a16a1)Merge (dcf01e1)Diff
    FirebaseModelDownloader.java84.66%82.21%-2.45%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TCzQVdJ5kN.html

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,573 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4TB7mh9aQb/index.html

@dconeybe dconeybe requested review from rlazo and daymxn September 12, 2024 22:03
@dconeybe dconeybe merged commit d5d133b into main Sep 13, 2024
250 of 251 checks passed
@dconeybe dconeybe deleted the dconeybe/EncodersLibsVersionToml branch September 13, 2024 04:20
@firebase firebase locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants