-
Notifications
You must be signed in to change notification settings - Fork 624
Add support for allowed_function_names #6273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A note about `@SerialName("allowed_function_names")`: This is not strictly necessary, the backend will parse it if it's camel case too. We should eventually remove all unnecessary `@SerialName` declarations, but for now, and to keep consistency, I'm adding it to this declaration.
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html 2024-09-18 16:56:10.816575384 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html 2024-09-18 16:54:06.952117001 +0000
@@ -47,6 +47,13 @@
</thead>
<tbody class="list">
<tr>
+ <td><code>final <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>></code></td>
+ <td>
+ <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#allowedFunctionNames()">allowedFunctionNames</a></code></div>
+ <p>Function names to call.</p>
+ </td>
+ </tr>
+ <tr>
<td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#mode()">mode</a></code></div>
@@ -70,7 +77,7 @@
<tbody class="list">
<tr>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a> mode)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a> mode,<br> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> allowedFunctionNames<br>)</code></div>
</td>
</tr>
</tbody>
@@ -78,6 +85,11 @@
</div>
<div class="list">
<h2>Public fields</h2>
+ <div class="api-item"><a name="getAllowedFunctionNames()"></a><a name="setAllowedFunctionNames()"></a><a name="getAllowedFunctionNames--"></a><a name="setAllowedFunctionNames--"></a>
+ <h3 class="api-name" id="allowedFunctionNames()">allowedFunctionNames</h3>
+ <pre class="api-signature no-pretty-print">public final <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#allowedFunctionNames()">allowedFunctionNames</a></pre>
+ <p>Function names to call. Only set when the <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>. Function names should match <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionDeclaration.html#name()">FunctionDeclaration.name</a></code>. With <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>, model will predict a function call from the set of function names provided.</p>
+ </div>
<div class="api-item"><a name="getMode()"></a><a name="setMode()"></a><a name="getMode--"></a><a name="setMode--"></a>
<h3 class="api-name" id="mode()">mode</h3>
<pre class="api-signature no-pretty-print">public final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#mode()">mode</a></pre>
@@ -86,9 +98,9 @@
</div>
<div class="list">
<h2>Public constructors</h2>
- <div class="api-item"><a name="FunctionCallingConfig-com.google.firebase.vertexai.type.FunctionCallingConfig.Mode-"></a><a name="functioncallingconfig"></a>
- <h3 class="api-name" id="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</h3>
- <pre class="api-signature no-pretty-print">public <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a> mode)</pre>
+ <div class="api-item"><a name="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode, kotlin.collections.List)"></a><a name="FunctionCallingConfig-com.google.firebase.vertexai.type.FunctionCallingConfig.Mode-kotlin.collections.List-"></a><a name="functioncallingconfig"></a>
+ <h3 class="api-name" id="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</h3>
+ <pre class="api-signature no-pretty-print">public <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a> mode,<br> <a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> allowedFunctionNames<br>)</pre>
<div class="devsite-table-wrapper">
<table class="responsive">
<colgroup>
@@ -107,6 +119,12 @@
<p>The function calling mode of the model</p>
</td>
</tr>
+ <tr>
+ <td><code><a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> allowedFunctionNames</code></td>
+ <td>
+ <p>Function names to call. Only set when the <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>. Function names should match <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionDeclaration.html#name()">FunctionDeclaration.name</a></code>. With <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>, model will predict a function call from the set of function names provided.</p>
+ </td>
+ </tr>
</tbody>
</table>
</div> --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html 2024-09-18 16:56:10.820575400 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html 2024-09-18 16:54:06.956117016 +0000
@@ -27,8 +27,8 @@
<tr>
<td><code>static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always()">always</a>()</code></div>
- <p>Shorthand to construct a ToolConfig that restricts the model to always call some function</p>
+ <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">always</a>(<a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> allowedFunctionNames)</code></div>
+ <p>Shorthand to construct a ToolConfig that restricts the model to always call some function.</p>
</td>
</tr>
<tr>
@@ -43,10 +43,10 @@
</div>
<div class="list">
<h2>Public methods</h2>
- <div class="api-item"><a name="always--"></a><a name="always"></a>
- <h3 class="api-name" id="always()">always</h3>
- <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always()">always</a>()</pre>
- <p>Shorthand to construct a ToolConfig that restricts the model to always call some function</p>
+ <div class="api-item"><a name="always-kotlin.collections.List-"></a><a name="always"></a>
+ <h3 class="api-name" id="always(kotlin.collections.List)">always</h3>
+ <pre class="api-signature no-pretty-print">public static final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">always</a>(<a href="https://developer.android.com/reference/kotlin/java/util/List.html">List</a><@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>> allowedFunctionNames)</pre>
+ <p>Shorthand to construct a ToolConfig that restricts the model to always call some function. You can optionally <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">allowedFunctionNames</a></code> to restrict the model to only call these functions. See <code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FunctionCallingConfig.html">FunctionCallingConfig</a></code> for more information.</p>
</div>
<div class="api-item"><a name="never--"></a><a name="never"></a>
<h3 class="api-name" id="never()">never</h3> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html 2024-09-18 16:56:10.808575354 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html 2024-09-18 16:54:06.944116970 +0000
@@ -48,7 +48,7 @@
<tbody class="list">
<tr>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</a>(mode: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</a>(<br> mode: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a>,<br> allowedFunctionNames: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>?<br>)</code></div>
</td>
</tr>
</tbody>
@@ -67,6 +67,13 @@
</thead>
<tbody class="list">
<tr>
+ <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>?</code></td>
+ <td>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#allowedFunctionNames()">allowedFunctionNames</a></code></div>
+ <p>Function names to call.</p>
+ </td>
+ </tr>
+ <tr>
<td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#mode()">mode</a></code></div>
@@ -78,9 +85,9 @@
</div>
<div class="list">
<h2>Public constructors</h2>
- <div class="api-item"><a name="FunctionCallingConfig-com.google.firebase.vertexai.type.FunctionCallingConfig.Mode-"></a><a name="functioncallingconfig"></a>
- <h3 class="api-name" id="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</h3>
- <pre class="api-signature no-pretty-print"><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode)">FunctionCallingConfig</a>(mode: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a>)</pre>
+ <div class="api-item"><a name="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode, kotlin.collections.List)"></a><a name="FunctionCallingConfig-com.google.firebase.vertexai.type.FunctionCallingConfig.Mode-kotlin.collections.List-"></a><a name="functioncallingconfig"></a>
+ <h3 class="api-name" id="FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</h3>
+ <pre class="api-signature no-pretty-print"><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#FunctionCallingConfig(com.google.firebase.vertexai.type.FunctionCallingConfig.Mode,kotlin.collections.List)">FunctionCallingConfig</a>(<br> mode: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a>,<br> allowedFunctionNames: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>? = null<br>)</pre>
<div class="devsite-table-wrapper">
<table class="responsive">
<colgroup>
@@ -99,6 +106,12 @@
<p>The function calling mode of the model</p>
</td>
</tr>
+ <tr>
+ <td><code>allowedFunctionNames: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>? = null</code></td>
+ <td>
+ <p>Function names to call. Only set when the <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>. Function names should match <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionDeclaration.html#name()">FunctionDeclaration.name</a></code>. With <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>, model will predict a function call from the set of function names provided.</p>
+ </td>
+ </tr>
</tbody>
</table>
</div>
@@ -106,6 +119,11 @@
</div>
<div class="list">
<h2>Public properties</h2>
+ <div class="api-item"><a name="getAllowedFunctionNames()"></a><a name="setAllowedFunctionNames()"></a><a name="getAllowedFunctionNames--"></a><a name="setAllowedFunctionNames--"></a>
+ <h3 class="api-name" id="allowedFunctionNames()">allowedFunctionNames</h3>
+ <pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#allowedFunctionNames()">allowedFunctionNames</a>: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>?</pre>
+ <p>Function names to call. Only set when the <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>. Function names should match <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionDeclaration.html#name()">FunctionDeclaration.name</a></code>. With <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html#ANY">Mode.ANY</a></code>, model will predict a function call from the set of function names provided.</p>
+ </div>
<div class="api-item"><a name="getMode()"></a><a name="setMode()"></a><a name="getMode--"></a><a name="setMode--"></a>
<h3 class="api-name" id="mode()">mode</h3>
<pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html#mode()">mode</a>: <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.Mode.html">FunctionCallingConfig.Mode</a></pre> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ToolConfig.html 2024-09-18 16:56:10.812575369 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ToolConfig.html 2024-09-18 16:54:06.948116986 +0000
@@ -28,8 +28,8 @@
<tr>
<td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always()">always</a>()</code></div>
- <p>Shorthand to construct a ToolConfig that restricts the model to always call some function</p>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">always</a>(allowedFunctionNames: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>?)</code></div>
+ <p>Shorthand to construct a ToolConfig that restricts the model to always call some function.</p>
</td>
</tr>
<tr>
@@ -86,10 +86,10 @@
</div>
<div class="list">
<h2>Public companion functions</h2>
- <div class="api-item"><a name="always--"></a><a name="always"></a>
- <h3 class="api-name" id="always()">always</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always()">always</a>(): <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a></pre>
- <p>Shorthand to construct a ToolConfig that restricts the model to always call some function</p>
+ <div class="api-item"><a name="always-kotlin.collections.List-"></a><a name="always"></a>
+ <h3 class="api-name" id="always(kotlin.collections.List)">always</h3>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">always</a>(allowedFunctionNames: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/-list/index.html">List</a><<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>>? = null): <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.html">ToolConfig</a></pre>
+ <p>Shorthand to construct a ToolConfig that restricts the model to always call some function. You can optionally <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ToolConfig.Companion.html#always(kotlin.collections.List)">allowedFunctionNames</a></code> to restrict the model to only call these functions. See <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/FunctionCallingConfig.html">FunctionCallingConfig</a></code> for more information.</p>
</div>
<div class="api-item"><a name="never--"></a><a name="never"></a>
<h3 class="api-name" id="never()">never</h3> |
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (d153670) and merge commit (22785e1).Test Logs |
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/ToolConfig.kt
Show resolved
Hide resolved
emilypgoogle
approved these changes
Sep 18, 2024
Size Report 1Affected Products
Test Logs |
daymxn
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note about
@SerialName("allowed_function_names")
: This is not strictly necessary, the backend will parse it if it's camel case too. We should eventually remove all unnecessary@SerialName
declarations, but for now, and to keep consistency, I'm adding it to this declaration.